From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26210 invoked by alias); 24 Apr 2012 03:31:29 -0000 Received: (qmail 26191 invoked by uid 22791); 24 Apr 2012 03:31:29 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 03:31:16 +0000 Received: by vbbey12 with SMTP id ey12so223307vbb.0 for ; Mon, 23 Apr 2012 20:31:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=88+EXvu+o/I2qYe7Lb4Wxqxlvv89TUuo1DcrljxNscA=; b=lXf+hsd9rm+UEIusvS2V/2OGnNoPN/UIP159sy7t0Kyye64AF5g8DZ7m/MVM3J2Rdi Wk/FDTCMb5wFrtkGzxoW1CasE55nbYjwSw9yzdd/dKoDWMyMwn2yIQU0B65e42Uf93ie Q6si9x3iIfhzYWi8FUhPmXAEANL5MQomFMVrbzWfwg/BvphkUZEyHv1sFOysLDbH6sEl JbMuQkoIDcom9LgNSKj/UsZEebQDTZvHbDbvsCvj6G0fsWDBYrz7hdS+T1SGKx2l9kWX anq3k+ca5UmwHDvF/Fd2SVrUyILuiIqhD/VeS+uC40VXjTQN4p9MLMwVeriTfm8I1ftE Hqww== Received: by 10.52.22.162 with SMTP id e2mr15423192vdf.76.1335238275746; Mon, 23 Apr 2012 20:31:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.22.162 with SMTP id e2mr15423182vdf.76.1335238275650; Mon, 23 Apr 2012 20:31:15 -0700 (PDT) Received: by 10.52.165.2 with HTTP; Mon, 23 Apr 2012 20:31:15 -0700 (PDT) In-Reply-To: References: Date: Tue, 24 Apr 2012 03:33:00 -0000 Message-ID: Subject: Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag) From: Doug Evans To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQkKBCAzekL8pWoNgJGikEMGJMDUc3RDwoKC6f2x3fCKdul6oysM0DLh/bCM8UKtGuHxC1WAOFHP3eadEquLjf+M5GfrNUnQKP7zjeBY0tY9K/t6eP0PYFzZ5v+q6Ii5joo9HIsUM0TbiIz64TTlY5MLPQokzA== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00765.txt.bz2 On Mon, Apr 23, 2012 at 3:51 PM, Sergio Durigan Junior wrote: > Hi, > > This patch is a followup of the discussion in: > > =A0 =A0http://sourceware.org/ml/gdb/2012-04/msg00171.html > > First of all, I am sorry for the size of this patch, but I couldn't > think of a good way of splitting it, and also I thought it would be > useless since these changes are all logically related. > > I regtested the patch on a Fedora 16 x86{,_64}, without regressions. =A0I > also built the patch using `--enable-targets=3Dall --enable-plugins > --enable-gold', and everything succeeded. > > I'd like to apply it, but I have a couple of questions before: > > a) How's the ChangeLog for this patch supposed to be? =A0Can I make a > "generic" ChangeLog, saying something like `Remove unused variables from > files'? > > b) I'd like someone to take a look at the `observer.sh' change, please. > > Thank you, Hi. Can we hold off these kinds of changes to dwarf2read.c? ref: Fission patch set