From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27255 invoked by alias); 6 Aug 2012 13:44:53 -0000 Received: (qmail 27238 invoked by uid 22791); 6 Aug 2012 13:44:52 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Aug 2012 13:44:32 +0000 Received: by wgbdr1 with SMTP id dr1so2205497wgb.12 for ; Mon, 06 Aug 2012 06:44:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:content-type:x-gm-message-state; bh=ijN6zB917823vzJ1zY1O94RFSvExBxb0zwmf588rVRY=; b=oWEvdEF2h+QgacjDXEAurywEtpon6aJOwO8qbo87DHOdAefOg8nQpdej8z7Zga56oc 06hPCfLCy2RRfXGKvIQ+7vChKGF/ttOcJnE/Degt2+otj6qNHD2Btl6ch3+KLaggfk79 4NWwIhRURwIy4dDpjcO5VtXbpAlQgxL4IK7ScwDrPDGez9NHa4CmKhqqQdMX3ZCOH7T6 Vb/VTSA8OYpwEhDcSZ53sRulu9KYiMSMpNprgHa8n1S7/x/vp/8D22x45Ld0V9TLYiJf mCcR0RoogmH3IKX2MXQxPNmX6kUm2CZ0KOlNb/GGOYXcK8HkABep4HkgCbfvgbhJwm0O SfxQ== MIME-Version: 1.0 Received: by 10.180.14.34 with SMTP id m2mr18551552wic.21.1344260671221; Mon, 06 Aug 2012 06:44:31 -0700 (PDT) Received: by 10.216.137.157 with HTTP; Mon, 6 Aug 2012 06:44:30 -0700 (PDT) In-Reply-To: References: Date: Mon, 06 Aug 2012 13:44:00 -0000 Message-ID: Subject: Re: Minor refactoring of tdep-i386.c and exceptions.h to fix multiple gcc shadow warnings From: Goncalo Gomes To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=f46d040f9f54cb31e304c6991378 X-Gm-Message-State: ALoCoQkCgUo7pQsSrI70XNg3nh8ujspqRb8SHj3MTPrPtfB3wRBYtEQTCslEd9po/p1GZq+hSAJi X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00167.txt.bz2 --f46d040f9f54cb31e304c6991378 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 454 On Mon, Aug 6, 2012 at 2:42 PM, Goncalo Gomes wrote: > The attached patch fixes all the warnings in tdep-i386.c resulting from > enabling shadow warnings in gcc. This is the revised version of the > patch I sent in yesterday after applying Sergio's comments. > > http://sourceware.org/ml/gdb-patches/2012-08/msg00152.html > This time with the patch and changelog attached. -- Goncalo http://promisc.org/ --f46d040f9f54cb31e304c6991378 Content-Type: application/octet-stream; name="enable-gcc-shadow-warnings-0001.patch" Content-Disposition: attachment; filename="enable-gcc-shadow-warnings-0001.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h5jlwh0w0 Content-length: 6942 ZGlmZiAtLWdpdCBhL2dkYi9leGNlcHRpb25zLmggYi9nZGIvZXhjZXB0aW9u cy5oCmluZGV4IDBjNTlhMjUuLjFlOGYyZWMgMTAwNjQ0Ci0tLSBhL2dkYi9l eGNlcHRpb25zLmgKKysrIGIvZ2RiL2V4Y2VwdGlvbnMuaApAQCAtMTQ1LDkg KzE0NSw5IEBAIGludCBleGNlcHRpb25zX3N0YXRlX21jX2FjdGlvbl9pdGVy XzEgKHZvaWQpOwogCiAjZGVmaW5lIFRSWV9DQVRDSChFWENFUFRJT04sTUFT SykgXAogICAgICB7IFwKLSAgICAgICBFWENFUFRJT05TX1NJR0pNUF9CVUYg KmJ1ZiA9IFwKKyAgICAgICBFWENFUFRJT05TX1NJR0pNUF9CVUYgKnRyeWNh dGNoX3NqYnVmID0gXAogCSBleGNlcHRpb25zX3N0YXRlX21jX2luaXQgKCYo RVhDRVBUSU9OKSwgKE1BU0spKTsgXAotICAgICAgIEVYQ0VQVElPTlNfU0lH U0VUSk1QICgqYnVmKTsgXAorICAgICAgIEVYQ0VQVElPTlNfU0lHU0VUSk1Q ICgqdHJ5Y2F0Y2hfc2pidWYpOyBcCiAgICAgIH0gXAogICAgICB3aGlsZSAo ZXhjZXB0aW9uc19zdGF0ZV9tY19hY3Rpb25faXRlciAoKSkgXAogICAgICAg IHdoaWxlIChleGNlcHRpb25zX3N0YXRlX21jX2FjdGlvbl9pdGVyXzEgKCkp CmRpZmYgLS1naXQgYS9nZGIvaTM4Ni10ZGVwLmMgYi9nZGIvaTM4Ni10ZGVw LmMKaW5kZXggODRlOTc5NC4uMGZjYTYyZCAxMDA2NDQKLS0tIGEvZ2RiL2kz ODYtdGRlcC5jCisrKyBiL2dkYi9pMzg2LXRkZXAuYwpAQCAtMjMzNiw3ICsy MzM2LDcgQEAgaTM4Nl8xNl9ieXRlX2FsaWduX3AgKHN0cnVjdCB0eXBlICp0 eXBlKQogCiBzdGF0aWMgQ09SRV9BRERSCiBpMzg2X3B1c2hfZHVtbXlfY29k ZSAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsIENPUkVfQUREUiBzcCwgQ09S RV9BRERSIGZ1bmFkZHIsCi0JCSAgICAgIHN0cnVjdCB2YWx1ZSAqKmFyZ3Ms IGludCBuYXJncywgc3RydWN0IHR5cGUgKnZhbHVlX3R5cGUsCisJCSAgICAg IHN0cnVjdCB2YWx1ZSAqKmFyZ3MsIGludCBuYXJncywgc3RydWN0IHR5cGUg KnZhbHR5cGUsCiAJCSAgICAgIENPUkVfQUREUiAqcmVhbF9wYywgQ09SRV9B RERSICpicF9hZGRyLAogCQkgICAgICBzdHJ1Y3QgcmVnY2FjaGUgKnJlZ2Nh Y2hlKQogewpAQCAtMjUxNCw3ICsyNTE0LDcgQEAgaTM4Nl9zdG9yZV9yZXR1 cm5fdmFsdWUgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLCBzdHJ1Y3QgdHlw ZSAqdHlwZSwKIAogICBpZiAoVFlQRV9DT0RFICh0eXBlKSA9PSBUWVBFX0NP REVfRkxUKQogICAgIHsKLSAgICAgIFVMT05HRVNUIGZzdGF0OworICAgICAg VUxPTkdFU1QgZnBzdGF0OwogICAgICAgZ2RiX2J5dGUgYnVmW0kzODZfTUFY X1JFR0lTVEVSX1NJWkVdOwogCiAgICAgICBpZiAodGRlcC0+c3QwX3JlZ251 bSA8IDApCkBAIC0yNTM4LDkgKzI1MzgsOSBAQCBpMzg2X3N0b3JlX3JldHVy bl92YWx1ZSAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsIHN0cnVjdCB0eXBl ICp0eXBlLAogICAgICAgICAgYWN0dWFsIHZhbHVlIGRvZXNuJ3QgcmVhbGx5 IG1hdHRlciwgYnV0IDcgaXMgd2hhdCBhIG5vcm1hbAogICAgICAgICAgZnVu Y3Rpb24gcmV0dXJuIHdvdWxkIGVuZCB1cCB3aXRoIGlmIHRoZSBwcm9ncmFt IHN0YXJ0ZWQgb3V0CiAgICAgICAgICB3aXRoIGEgZnJlc2hseSBpbml0aWFs aXplZCBGUFUuICAqLwotICAgICAgcmVnY2FjaGVfcmF3X3JlYWRfdW5zaWdu ZWQgKHJlZ2NhY2hlLCBJMzg3X0ZTVEFUX1JFR05VTSAodGRlcCksICZmc3Rh dCk7Ci0gICAgICBmc3RhdCB8PSAoNyA8PCAxMSk7Ci0gICAgICByZWdjYWNo ZV9yYXdfd3JpdGVfdW5zaWduZWQgKHJlZ2NhY2hlLCBJMzg3X0ZTVEFUX1JF R05VTSAodGRlcCksIGZzdGF0KTsKKyAgICAgIHJlZ2NhY2hlX3Jhd19yZWFk X3Vuc2lnbmVkIChyZWdjYWNoZSwgSTM4N19GU1RBVF9SRUdOVU0gKHRkZXAp LCAmZnBzdGF0KTsKKyAgICAgIGZwc3RhdCB8PSAoNyA8PCAxMSk7CisgICAg ICByZWdjYWNoZV9yYXdfd3JpdGVfdW5zaWduZWQgKHJlZ2NhY2hlLCBJMzg3 X0ZTVEFUX1JFR05VTSAodGRlcCksIGZwc3RhdCk7CiAKICAgICAgIC8qIE1h cmsgJXN0KDEpIHRocm91Z2ggJXN0KDcpIGFzIGVtcHR5LiAgU2luY2Ugd2Ug c2V0IHRoZSB0b3Agb2YKICAgICAgICAgIHRoZSBmbG9hdGluZy1wb2ludCBy ZWdpc3RlciBzdGFjayB0byA3LCB0aGUgYXBwcm9wcmlhdGUgdmFsdWUKQEAg LTI4MjUsMTIgKzI4MjUsMTIgQEAgaTM4Nl9tbXhfcmVnbnVtX3RvX2ZwX3Jl Z251bSAoc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNoZSwgaW50IHJlZ251bSkK IHsKICAgc3RydWN0IGdkYmFyY2hfdGRlcCAqdGRlcCA9IGdkYmFyY2hfdGRl cCAoZ2V0X3JlZ2NhY2hlX2FyY2ggKHJlZ2NhY2hlKSk7CiAgIGludCBtbXhy ZWcsIGZwcmVnOwotICBVTE9OR0VTVCBmc3RhdDsKKyAgVUxPTkdFU1QgZnBz dGF0OwogICBpbnQgdG9zOwogCiAgIG1teHJlZyA9IHJlZ251bSAtIHRkZXAt Pm1tMF9yZWdudW07Ci0gIHJlZ2NhY2hlX3Jhd19yZWFkX3Vuc2lnbmVkIChy ZWdjYWNoZSwgSTM4N19GU1RBVF9SRUdOVU0gKHRkZXApLCAmZnN0YXQpOwot ICB0b3MgPSAoZnN0YXQgPj4gMTEpICYgMHg3OworICByZWdjYWNoZV9yYXdf cmVhZF91bnNpZ25lZCAocmVnY2FjaGUsIEkzODdfRlNUQVRfUkVHTlVNICh0 ZGVwKSwgJmZwc3RhdCk7CisgIHRvcyA9IChmcHN0YXQgPj4gMTEpICYgMHg3 OwogICBmcHJlZyA9IChtbXhyZWcgKyB0b3MpICUgODsKIAogICByZXR1cm4g KEkzODdfU1QwX1JFR05VTSAodGRlcCkgKyBmcHJlZyk7CkBAIC0zNTYxLDgg KzM1NjEsOCBAQCBpMzg2X3N0YXBfcGFyc2Vfc3BlY2lhbF90b2tlbiAoc3Ry dWN0IGdkYmFyY2ggKmdkYmFyY2gsCiAJCSAgY29uc3QgY2hhciAqc3RhcnQ7 CiAJCSAgY2hhciAqYmFzZTsKIAkJICBpbnQgbGVuX2Jhc2U7Ci0JCSAgY2hh ciAqaW5kZXg7Ci0JCSAgaW50IGxlbl9pbmRleDsKKwkJICBjaGFyICppZHg7 CisJCSAgaW50IGxlbl9pZHg7CiAJCSAgc3RydWN0IHN0b2tlbiBiYXNlX3Rv a2VuLCBpbmRleF90b2tlbjsKIAogCQkgIGlmICgqcyA9PSAnKycpCkBAIC0z NjA4LDE2ICszNjA4LDE2IEBAIGkzODZfc3RhcF9wYXJzZV9zcGVjaWFsX3Rv a2VuIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwKIAkJICB3aGlsZSAoaXNh bG51bSAoKnMpKQogCQkgICAgKytzOwogCi0JCSAgbGVuX2luZGV4ID0gcyAt IHN0YXJ0OwotCQkgIGluZGV4ID0gYWxsb2NhIChsZW5faW5kZXggKyAxKTsK LQkJICBzdHJuY3B5IChpbmRleCwgc3RhcnQsIGxlbl9pbmRleCk7Ci0JCSAg aW5kZXhbbGVuX2luZGV4XSA9ICdcMCc7CisJCSAgbGVuX2lkeCA9IHMgLSBz dGFydDsKKwkJICBpZHggPSBhbGxvY2EgKGxlbl9pZHggKyAxKTsKKwkJICBz dHJuY3B5IChpZHgsIHN0YXJ0LCBsZW5faWR4KTsKKwkJICBpZHhbbGVuX2lk eF0gPSAnXDAnOwogCiAJCSAgaWYgKHVzZXJfcmVnX21hcF9uYW1lX3RvX3Jl Z251bSAoZ2RiYXJjaCwKLQkJCQkJCSAgIGluZGV4LCBsZW5faW5kZXgpID09 IC0xKQorCQkJCQkJICAgaWR4LCBsZW5faWR4KSA9PSAtMSkKIAkJICAgIGVy cm9yIChfKCJJbnZhbGlkIHJlZ2lzdGVyIG5hbWUgYCVzJyAiCiAJCQkgICAg ICJvbiBleHByZXNzaW9uIGAlcycuIiksCi0JCQkgICBpbmRleCwgcC0+c2F2 ZWRfYXJnKTsKKwkJCSAgIGlkeCwgcC0+c2F2ZWRfYXJnKTsKIAogCQkgIGlm ICgqcyAhPSAnLCcgJiYgKnMgIT0gJyknKQogCQkgICAgYnJlYWs7CkBAIC0z NjYyLDggKzM2NjIsOCBAQCBpMzg2X3N0YXBfcGFyc2Vfc3BlY2lhbF90b2tl biAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsCiAJCSAgICB3cml0ZV9leHBf ZWx0X29wY29kZSAoQklOT1BfQUREKTsKIAogCQkgIHdyaXRlX2V4cF9lbHRf b3Bjb2RlIChPUF9SRUdJU1RFUik7Ci0JCSAgaW5kZXhfdG9rZW4ucHRyID0g aW5kZXg7Ci0JCSAgaW5kZXhfdG9rZW4ubGVuZ3RoID0gbGVuX2luZGV4Owor CQkgIGluZGV4X3Rva2VuLnB0ciA9IGlkeDsKKwkJICBpbmRleF90b2tlbi5s ZW5ndGggPSBsZW5faWR4OwogCQkgIHdyaXRlX2V4cF9zdHJpbmcgKGluZGV4 X3Rva2VuKTsKIAkJICB3cml0ZV9leHBfZWx0X29wY29kZSAoT1BfUkVHSVNU RVIpOwogCkBAIC0zOTcwLDcgKzM5NzAsNyBAQCBpMzg2X3JlY29yZF9sZWFf bW9kcm1fYWRkciAoc3RydWN0IGkzODZfcmVjb3JkX3MgKmlycCwgdWludDY0 X3QgKmFkZHIpCiAgICAgICBpbnQgaGF2ZXNpYiA9IDA7CiAgICAgICB1aW50 OF90IHNjYWxlID0gMDsKICAgICAgIHVpbnQ4X3QgYnl0ZTsKLSAgICAgIHVp bnQ4X3QgaW5kZXggPSAwOworICAgICAgdWludDhfdCBpZHggPSAwOwogICAg ICAgdWludDhfdCBiYXNlID0gaXJwLT5ybTsKIAogICAgICAgaWYgKGJhc2Ug PT0gNCkKQEAgLTM5ODAsNyArMzk4MCw3IEBAIGkzODZfcmVjb3JkX2xlYV9t b2RybV9hZGRyIChzdHJ1Y3QgaTM4Nl9yZWNvcmRfcyAqaXJwLCB1aW50NjRf dCAqYWRkcikKIAkgICAgcmV0dXJuIC0xOwogCSAgaXJwLT5hZGRyKys7CiAJ ICBzY2FsZSA9IChieXRlID4+IDYpICYgMzsKLQkgIGluZGV4ID0gKChieXRl ID4+IDMpICYgNykgfCBpcnAtPnJleF94OworCSAgaWR4ID0gKChieXRlID4+ IDMpICYgNykgfCBpcnAtPnJleF94OwogCSAgYmFzZSA9IChieXRlICYgNyk7 CiAJfQogICAgICAgYmFzZSB8PSBpcnAtPnJleF9iOwpAQCAtNDAyOCw5ICs0 MDI4LDkgQEAgaTM4Nl9yZWNvcmRfbGVhX21vZHJtX2FkZHIgKHN0cnVjdCBp Mzg2X3JlY29yZF9zICppcnAsIHVpbnQ2NF90ICphZGRyKQogICAgICAgZWxz ZQogICAgICAgICAqYWRkciA9ICh1aW50MzJfdCkgKG9mZnNldDY0ICsgKmFk ZHIpOwogCi0gICAgICBpZiAoaGF2ZXNpYiAmJiAoaW5kZXggIT0gNCB8fCBz Y2FsZSAhPSAwKSkKKyAgICAgIGlmIChoYXZlc2liICYmIChpZHggIT0gNCB8 fCBzY2FsZSAhPSAwKSkKIAl7Ci0JICByZWdjYWNoZV9yYXdfcmVhZF91bnNp Z25lZCAoaXJwLT5yZWdjYWNoZSwgaXJwLT5yZWdtYXBbaW5kZXhdLAorCSAg cmVnY2FjaGVfcmF3X3JlYWRfdW5zaWduZWQgKGlycC0+cmVnY2FjaGUsIGly cC0+cmVnbWFwW2lkeF0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICZvZmZzZXQ2NCk7CiAJICBpZiAoaXJwLT5hZmxhZyA9PSAy KQogCSAgICAqYWRkciArPSBvZmZzZXQ2NCA8PCBzY2FsZTsK --f46d040f9f54cb31e304c6991378 Content-Type: application/octet-stream; name="enable-gcc-shadow-warnings-0001.changelog" Content-Disposition: attachment; filename="enable-gcc-shadow-warnings-0001.changelog" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h5jlwh0y1 Content-length: 541 MjAxMi0wOC0wNSAgR29uY2FsbyBHb21lcyAgPGdvbmNhbG9AcHJvbWlzYy5v cmc+CgoJKiBleGNlcHRpb25zLmggKFRSWV9DQVRDSCk6IFJlbmFtZSBgYnVm JyB0byBgdHJ5Y2F0Y2hfc2pidWYnLgoKCSogaTM4Ni10ZGVwLmMgKGkzODZf cHVzaF9kdW1teV9jb2RlKTogUmVuYW1lIGB2YWx1ZV90eXBlYCB0byBgdmFs dHlwZWAuCgkoaTM4Nl9tbXhfcmVnbnVtX3RvX2ZwX3JlZ251bSk6IFJlbmFt ZSBgZnN0YXRgIHRvIGBmcHN0YXRgLgoJKGkzODZfc3RhcF9wYXJzZV9zcGVj aWFsX3Rva2VuKTogUmVuYW1lIGBpbmRleGAgdG8gYGlkeGA7IAoJUmVuYW1l IGBsZW5faW5kZXhgIHRvIGBsZW5faWR4YC4KCShpMzg2X3JlY29yZF9sZWFf bW9kcm1fYWRkcik6IFJlbmFtZSBgaW5kZXhgIHRvIGBpZHhgLgo= --f46d040f9f54cb31e304c6991378--