From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26714 invoked by alias); 5 Aug 2012 22:24:19 -0000 Received: (qmail 26701 invoked by uid 22791); 5 Aug 2012 22:24:19 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Aug 2012 22:24:05 +0000 Received: by wgbdr1 with SMTP id dr1so1788410wgb.12 for ; Sun, 05 Aug 2012 15:24:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=h19W9QEv8p8IJnD6hiYnnJRP+SW1JWOuW+aZEDCKQd0=; b=HbPnmWDaHxPRVIuHo3oyjWcmOsR4mMphYtq2QnxEBDwYrcRg50YihnZA8AzU4npZKo /vov3B9TfPTONwkM1j5ElMRW1heiLYmF076J0QFlF33zGeFR4cNOvfucjKbzUKG9tN+o fCD0Tgvw83NgTiLQWA//0m6dBFcNxnFAvtmqj1naPCPGgthcKpI2DM9yCZZMhq4gfW4Y SIh77pfby/1wjRnO39hDjrbnuU4BPODsoWnrZZS/ZvuKMGP5iJ6vMBYDZG8E5ppvc2dP K+XnQmTxeqrUWgpSeYs6Q0K9HiW4um+Kf5179hNKneMub950b5Dac4QQ3ruDfnoDQEHl Fy/w== MIME-Version: 1.0 Received: by 10.180.98.200 with SMTP id ek8mr13267297wib.0.1344205444330; Sun, 05 Aug 2012 15:24:04 -0700 (PDT) Received: by 10.216.137.157 with HTTP; Sun, 5 Aug 2012 15:24:04 -0700 (PDT) Date: Sun, 05 Aug 2012 22:24:00 -0000 Message-ID: Subject: Refactor tdep-i386.c to fix all -Wshadow warnings From: Goncalo Gomes To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=f46d0442886003b51204c68c3833 X-Gm-Message-State: ALoCoQm71k9YiQHLPymreqsRMsFuFjvikHkZKCIfdLWtGx9Bhe5HahVAY9ho5wSMtp8J8zun5I96 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00152.txt.bz2 --f46d0442886003b51204c68c3833 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 325 The attached patch fixes all warnings in tdep-i386.c resulting from enabling shadow warnings in gcc. As this is my first contribution to GDB, I decided to keep it short to a single file to obtain feedback. 2012-08-05 Goncalo Gomes * Refactor tdep-i386.c to fix all -Wshadow warnings Goncalo --f46d0442886003b51204c68c3833 Content-Type: application/octet-stream; name="enable-gcc-shadow-warnings-0001.patch" Content-Disposition: attachment; filename="enable-gcc-shadow-warnings-0001.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h5iorxj70 Content-length: 6784 ZGlmZiAtLWdpdCBhL2dkYi9leGNlcHRpb25zLmggYi9nZGIvZXhjZXB0aW9u cy5oCmluZGV4IDBjNTlhMjUuLjljNDdhN2IgMTAwNjQ0Ci0tLSBhL2dkYi9l eGNlcHRpb25zLmgKKysrIGIvZ2RiL2V4Y2VwdGlvbnMuaApAQCAtMTQ1LDkg KzE0NSw5IEBAIGludCBleGNlcHRpb25zX3N0YXRlX21jX2FjdGlvbl9pdGVy XzEgKHZvaWQpOwogCiAjZGVmaW5lIFRSWV9DQVRDSChFWENFUFRJT04sTUFT SykgXAogICAgICB7IFwKLSAgICAgICBFWENFUFRJT05TX1NJR0pNUF9CVUYg KmJ1ZiA9IFwKKyAgICAgICBFWENFUFRJT05TX1NJR0pNUF9CVUYgKl90cnlj YXRjaF9zamJ1ZiA9IFwKIAkgZXhjZXB0aW9uc19zdGF0ZV9tY19pbml0ICgm KEVYQ0VQVElPTiksIChNQVNLKSk7IFwKLSAgICAgICBFWENFUFRJT05TX1NJ R1NFVEpNUCAoKmJ1Zik7IFwKKyAgICAgICBFWENFUFRJT05TX1NJR1NFVEpN UCAoKl90cnljYXRjaF9zamJ1Zik7IFwKICAgICAgfSBcCiAgICAgIHdoaWxl IChleGNlcHRpb25zX3N0YXRlX21jX2FjdGlvbl9pdGVyICgpKSBcCiAgICAg ICAgd2hpbGUgKGV4Y2VwdGlvbnNfc3RhdGVfbWNfYWN0aW9uX2l0ZXJfMSAo KSkKZGlmZiAtLWdpdCBhL2dkYi9pMzg2LXRkZXAuYyBiL2dkYi9pMzg2LXRk ZXAuYwppbmRleCA4NGU5Nzk0Li42ZmJjNTFmIDEwMDY0NAotLS0gYS9nZGIv aTM4Ni10ZGVwLmMKKysrIGIvZ2RiL2kzODYtdGRlcC5jCkBAIC0yMzM2LDcg KzIzMzYsNyBAQCBpMzg2XzE2X2J5dGVfYWxpZ25fcCAoc3RydWN0IHR5cGUg KnR5cGUpCiAKIHN0YXRpYyBDT1JFX0FERFIKIGkzODZfcHVzaF9kdW1teV9j b2RlIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgQ09SRV9BRERSIHNwLCBD T1JFX0FERFIgZnVuYWRkciwKLQkJICAgICAgc3RydWN0IHZhbHVlICoqYXJn cywgaW50IG5hcmdzLCBzdHJ1Y3QgdHlwZSAqdmFsdWVfdHlwZSwKKwkJICAg ICAgc3RydWN0IHZhbHVlICoqYXJncywgaW50IG5hcmdzLCBzdHJ1Y3QgdHlw ZSAqdmFsdHlwZSwKIAkJICAgICAgQ09SRV9BRERSICpyZWFsX3BjLCBDT1JF X0FERFIgKmJwX2FkZHIsCiAJCSAgICAgIHN0cnVjdCByZWdjYWNoZSAqcmVn Y2FjaGUpCiB7CkBAIC0yNTE0LDcgKzI1MTQsNyBAQCBpMzg2X3N0b3JlX3Jl dHVybl92YWx1ZSAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsIHN0cnVjdCB0 eXBlICp0eXBlLAogCiAgIGlmIChUWVBFX0NPREUgKHR5cGUpID09IFRZUEVf Q09ERV9GTFQpCiAgICAgewotICAgICAgVUxPTkdFU1QgZnN0YXQ7CisgICAg ICBVTE9OR0VTVCBmcHN0YXQ7CiAgICAgICBnZGJfYnl0ZSBidWZbSTM4Nl9N QVhfUkVHSVNURVJfU0laRV07CiAKICAgICAgIGlmICh0ZGVwLT5zdDBfcmVn bnVtIDwgMCkKQEAgLTI1MzgsOSArMjUzOCw5IEBAIGkzODZfc3RvcmVfcmV0 dXJuX3ZhbHVlIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgc3RydWN0IHR5 cGUgKnR5cGUsCiAgICAgICAgICBhY3R1YWwgdmFsdWUgZG9lc24ndCByZWFs bHkgbWF0dGVyLCBidXQgNyBpcyB3aGF0IGEgbm9ybWFsCiAgICAgICAgICBm dW5jdGlvbiByZXR1cm4gd291bGQgZW5kIHVwIHdpdGggaWYgdGhlIHByb2dy YW0gc3RhcnRlZCBvdXQKICAgICAgICAgIHdpdGggYSBmcmVzaGx5IGluaXRp YWxpemVkIEZQVS4gICovCi0gICAgICByZWdjYWNoZV9yYXdfcmVhZF91bnNp Z25lZCAocmVnY2FjaGUsIEkzODdfRlNUQVRfUkVHTlVNICh0ZGVwKSwgJmZz dGF0KTsKLSAgICAgIGZzdGF0IHw9ICg3IDw8IDExKTsKLSAgICAgIHJlZ2Nh Y2hlX3Jhd193cml0ZV91bnNpZ25lZCAocmVnY2FjaGUsIEkzODdfRlNUQVRf UkVHTlVNICh0ZGVwKSwgZnN0YXQpOworICAgICAgcmVnY2FjaGVfcmF3X3Jl YWRfdW5zaWduZWQgKHJlZ2NhY2hlLCBJMzg3X0ZTVEFUX1JFR05VTSAodGRl cCksICZmcHN0YXQpOworICAgICAgZnBzdGF0IHw9ICg3IDw8IDExKTsKKyAg ICAgIHJlZ2NhY2hlX3Jhd193cml0ZV91bnNpZ25lZCAocmVnY2FjaGUsIEkz ODdfRlNUQVRfUkVHTlVNICh0ZGVwKSwgZnBzdGF0KTsKIAogICAgICAgLyog TWFyayAlc3QoMSkgdGhyb3VnaCAlc3QoNykgYXMgZW1wdHkuICBTaW5jZSB3 ZSBzZXQgdGhlIHRvcCBvZgogICAgICAgICAgdGhlIGZsb2F0aW5nLXBvaW50 IHJlZ2lzdGVyIHN0YWNrIHRvIDcsIHRoZSBhcHByb3ByaWF0ZSB2YWx1ZQpA QCAtMjgyNSwxMiArMjgyNSwxMiBAQCBpMzg2X21teF9yZWdudW1fdG9fZnBf cmVnbnVtIChzdHJ1Y3QgcmVnY2FjaGUgKnJlZ2NhY2hlLCBpbnQgcmVnbnVt KQogewogICBzdHJ1Y3QgZ2RiYXJjaF90ZGVwICp0ZGVwID0gZ2RiYXJjaF90 ZGVwIChnZXRfcmVnY2FjaGVfYXJjaCAocmVnY2FjaGUpKTsKICAgaW50IG1t eHJlZywgZnByZWc7Ci0gIFVMT05HRVNUIGZzdGF0OworICBVTE9OR0VTVCBm cHN0YXQ7CiAgIGludCB0b3M7CiAKICAgbW14cmVnID0gcmVnbnVtIC0gdGRl cC0+bW0wX3JlZ251bTsKLSAgcmVnY2FjaGVfcmF3X3JlYWRfdW5zaWduZWQg KHJlZ2NhY2hlLCBJMzg3X0ZTVEFUX1JFR05VTSAodGRlcCksICZmc3RhdCk7 Ci0gIHRvcyA9IChmc3RhdCA+PiAxMSkgJiAweDc7CisgIHJlZ2NhY2hlX3Jh d19yZWFkX3Vuc2lnbmVkIChyZWdjYWNoZSwgSTM4N19GU1RBVF9SRUdOVU0g KHRkZXApLCAmZnBzdGF0KTsKKyAgdG9zID0gKGZwc3RhdCA+PiAxMSkgJiAw eDc7CiAgIGZwcmVnID0gKG1teHJlZyArIHRvcykgJSA4OwogCiAgIHJldHVy biAoSTM4N19TVDBfUkVHTlVNICh0ZGVwKSArIGZwcmVnKTsKQEAgLTM1NjEs NyArMzU2MSw3IEBAIGkzODZfc3RhcF9wYXJzZV9zcGVjaWFsX3Rva2VuIChz dHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwKIAkJICBjb25zdCBjaGFyICpzdGFy dDsKIAkJICBjaGFyICpiYXNlOwogCQkgIGludCBsZW5fYmFzZTsKLQkJICBj aGFyICppbmRleDsKKwkJICBjaGFyICppZHg7CiAJCSAgaW50IGxlbl9pbmRl eDsKIAkJICBzdHJ1Y3Qgc3Rva2VuIGJhc2VfdG9rZW4sIGluZGV4X3Rva2Vu OwogCkBAIC0zNjA5LDE1ICszNjA5LDE1IEBAIGkzODZfc3RhcF9wYXJzZV9z cGVjaWFsX3Rva2VuIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwKIAkJICAg ICsrczsKIAogCQkgIGxlbl9pbmRleCA9IHMgLSBzdGFydDsKLQkJICBpbmRl eCA9IGFsbG9jYSAobGVuX2luZGV4ICsgMSk7Ci0JCSAgc3RybmNweSAoaW5k ZXgsIHN0YXJ0LCBsZW5faW5kZXgpOwotCQkgIGluZGV4W2xlbl9pbmRleF0g PSAnXDAnOworCQkgIGlkeCA9IGFsbG9jYSAobGVuX2luZGV4ICsgMSk7CisJ CSAgc3RybmNweSAoaWR4LCBzdGFydCwgbGVuX2luZGV4KTsKKwkJICBpZHhb bGVuX2luZGV4XSA9ICdcMCc7CiAKIAkJICBpZiAodXNlcl9yZWdfbWFwX25h bWVfdG9fcmVnbnVtIChnZGJhcmNoLAotCQkJCQkJICAgaW5kZXgsIGxlbl9p bmRleCkgPT0gLTEpCisJCQkJCQkgICBpZHgsIGxlbl9pbmRleCkgPT0gLTEp CiAJCSAgICBlcnJvciAoXygiSW52YWxpZCByZWdpc3RlciBuYW1lIGAlcycg IgogCQkJICAgICAib24gZXhwcmVzc2lvbiBgJXMnLiIpLAotCQkJICAgaW5k ZXgsIHAtPnNhdmVkX2FyZyk7CisJCQkgICBpZHgsIHAtPnNhdmVkX2FyZyk7 CiAKIAkJICBpZiAoKnMgIT0gJywnICYmICpzICE9ICcpJykKIAkJICAgIGJy ZWFrOwpAQCAtMzY2Miw3ICszNjYyLDcgQEAgaTM4Nl9zdGFwX3BhcnNlX3Nw ZWNpYWxfdG9rZW4gKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLAogCQkgICAg d3JpdGVfZXhwX2VsdF9vcGNvZGUgKEJJTk9QX0FERCk7CiAKIAkJICB3cml0 ZV9leHBfZWx0X29wY29kZSAoT1BfUkVHSVNURVIpOwotCQkgIGluZGV4X3Rv a2VuLnB0ciA9IGluZGV4OworCQkgIGluZGV4X3Rva2VuLnB0ciA9IGlkeDsK IAkJICBpbmRleF90b2tlbi5sZW5ndGggPSBsZW5faW5kZXg7CiAJCSAgd3Jp dGVfZXhwX3N0cmluZyAoaW5kZXhfdG9rZW4pOwogCQkgIHdyaXRlX2V4cF9l bHRfb3Bjb2RlIChPUF9SRUdJU1RFUik7CkBAIC0zOTcwLDcgKzM5NzAsNyBA QCBpMzg2X3JlY29yZF9sZWFfbW9kcm1fYWRkciAoc3RydWN0IGkzODZfcmVj b3JkX3MgKmlycCwgdWludDY0X3QgKmFkZHIpCiAgICAgICBpbnQgaGF2ZXNp YiA9IDA7CiAgICAgICB1aW50OF90IHNjYWxlID0gMDsKICAgICAgIHVpbnQ4 X3QgYnl0ZTsKLSAgICAgIHVpbnQ4X3QgaW5kZXggPSAwOworICAgICAgdWlu dDhfdCBpZHggPSAwOwogICAgICAgdWludDhfdCBiYXNlID0gaXJwLT5ybTsK IAogICAgICAgaWYgKGJhc2UgPT0gNCkKQEAgLTM5ODAsNyArMzk4MCw3IEBA IGkzODZfcmVjb3JkX2xlYV9tb2RybV9hZGRyIChzdHJ1Y3QgaTM4Nl9yZWNv cmRfcyAqaXJwLCB1aW50NjRfdCAqYWRkcikKIAkgICAgcmV0dXJuIC0xOwog CSAgaXJwLT5hZGRyKys7CiAJICBzY2FsZSA9IChieXRlID4+IDYpICYgMzsK LQkgIGluZGV4ID0gKChieXRlID4+IDMpICYgNykgfCBpcnAtPnJleF94Owor CSAgaWR4ID0gKChieXRlID4+IDMpICYgNykgfCBpcnAtPnJleF94OwogCSAg YmFzZSA9IChieXRlICYgNyk7CiAJfQogICAgICAgYmFzZSB8PSBpcnAtPnJl eF9iOwpAQCAtNDAyOCw5ICs0MDI4LDkgQEAgaTM4Nl9yZWNvcmRfbGVhX21v ZHJtX2FkZHIgKHN0cnVjdCBpMzg2X3JlY29yZF9zICppcnAsIHVpbnQ2NF90 ICphZGRyKQogICAgICAgZWxzZQogICAgICAgICAqYWRkciA9ICh1aW50MzJf dCkgKG9mZnNldDY0ICsgKmFkZHIpOwogCi0gICAgICBpZiAoaGF2ZXNpYiAm JiAoaW5kZXggIT0gNCB8fCBzY2FsZSAhPSAwKSkKKyAgICAgIGlmIChoYXZl c2liICYmIChpZHggIT0gNCB8fCBzY2FsZSAhPSAwKSkKIAl7Ci0JICByZWdj YWNoZV9yYXdfcmVhZF91bnNpZ25lZCAoaXJwLT5yZWdjYWNoZSwgaXJwLT5y ZWdtYXBbaW5kZXhdLAorCSAgcmVnY2FjaGVfcmF3X3JlYWRfdW5zaWduZWQg KGlycC0+cmVnY2FjaGUsIGlycC0+cmVnbWFwW2lkeF0sCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICZvZmZzZXQ2NCk7CiAJICBp ZiAoaXJwLT5hZmxhZyA9PSAyKQogCSAgICAqYWRkciArPSBvZmZzZXQ2NCA8 PCBzY2FsZTsK --f46d0442886003b51204c68c3833 Content-Type: application/octet-stream; name="enable-gcc-shadow-warnings-0001.changelog" Content-Disposition: attachment; filename="enable-gcc-shadow-warnings-0001.changelog" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h5iorxj91 Content-length: 151 MjAxMi0wOC0wNSAgR29uY2FsbyBHb21lcyA8Z29uY2Fsb0Bwcm9taXNjLm9y Zz4KCiAgICAgICAgKiBSZWZhY3RvciB0ZGVwLWkzODYuYyB0byBmaXggYWxs IC1Xc2hhZG93IHdhcm5pbmdzCgo= --f46d0442886003b51204c68c3833--