From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id s/GbFiswK2la+gEAWB0awg (envelope-from ) for ; Sat, 29 Nov 2025 12:40:59 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NEGxY+ZW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4C2781E0B6; Sat, 29 Nov 2025 12:40:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 604C61E08D for ; Sat, 29 Nov 2025 12:40:58 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D609448F1745 for ; Sat, 29 Nov 2025 17:40:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D609448F1745 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NEGxY+ZW Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by sourceware.org (Postfix) with ESMTPS id 82F5248F3E90 for ; Sat, 29 Nov 2025 17:40:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82F5248F3E90 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 82F5248F3E90 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764438017; cv=none; b=bfO8AT8Jn0syX4+3nAdmafj0KdSWN1Nm1A2GJi/Zzd10UFr6MKlCcMehzrZBdUuhYfAlOAFtJ9w7QfOdcSLXjCdYo9FpRKOK+PgiZwkEymdXyWjBX557cPbmyEk8hBfbQXvPSs1/LMVhevqkUHKk04lgZNhM7LMK2sxIjGxx6oc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764438017; c=relaxed/simple; bh=h9kBtFDcGtX1F5l4fJuEj3dHA3APJDzJ0Ggggg0S+Ec=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=k6Ujg8mvWNoR58E4xL1npVONvbQ5huhHRtvzsn0LbuhkkKlNrOMw5iA3RQNSFfVWp4NL5Plo0g3MXdvtE4B9prGSFBj0/R3QnSwrQBuro3TjmY787Kz/WF7/Go4mlDGedY5qRDA5fyaOshLsgh8ecaZ1N8SbK2YisWW3OoYfS4k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82F5248F3E90 Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-8804650ca32so24153376d6.0 for ; Sat, 29 Nov 2025 09:40:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764438017; x=1765042817; darn=sourceware.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=UZ9WHK2JLrHeO5TyWAXgtcUHkuhF3M01Gga8JDy8OwU=; b=NEGxY+ZWKjyy3lJM3/7vNBAL72r0KKkNnuC8nNJFornkI8rXT6evYhG3GC4/1ohkX/ 7RFq8q/b8tztGzi4Y5bLFSATamPAKE82oAoliTwZqq8YJOoCx+hLucUCEl/6BGucxIYv vk4LK7jiuUgRyJydN/grtyQ8FVb13chXDJ6GXV1E0RZ4jW6/XWZJjB8Z0gp1JjZFz36+ 9KlgfqnhNHyZmy6iAhksIGDAOE+nlO7Dy34IzX+beGEy1qxr1PX5Hjm0YXznemgXus5G zBAZ7WiBoW8G+LVdGcQAgNUnkMqJkTGedUeUx4uTZMJ3XEtci+e173KIw7QgRLPYw65f 04gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764438017; x=1765042817; h=to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UZ9WHK2JLrHeO5TyWAXgtcUHkuhF3M01Gga8JDy8OwU=; b=w4UI49W/QIekIVW7q1Af5EuMLtwVU31NcJLF7Q8EoyrZOXUMjGpAfPhQ2BMOunbrH4 MRSWAd4gdN4RvpBlkvNFM6cwylr9+0J78G6dlE9cP4sApKTTItBxQDcGPa+81xWyOgPs QhLTSaaJrnWju73wjcY9i4hh+84KMbaJbCPkVyxTKYUII1VXO3C4xRSzM09UMYCGTCWB /HtLM14YaErD3jvqoA/YDRwrhtp4hArBmt5vpsuLTPM3x6danA9sdH6OrbXR9Sje/Shh UQwaOonJMUiEhZc0Kjy5bwMqe9C42axPpLYJlkVC1+IuM58fg618IbaE1owdg5AT+5ti FDwg== X-Gm-Message-State: AOJu0Yxad/n3VsrYGuoa27hBaPbPrSYF8EglFDDp+QgWffR5Qt2sxcDs 3XqWHyf3F+d6iKlslgM7XmOFzzQCLjVavVFSXWZ8U8GXvuc3LtbE3C3Q79VC9iM49t9DG9k/E6s pygPAwiFx3Cnu580LTIfsz4hqP5mm16ErVfew X-Gm-Gg: ASbGncvN5PeZYEvFoXGqxv008MQYNa3IZdwk2c/A51YlsHG6/k7fKn5xQzW++kemj+2 1PzWH+GUzkpI0JM02uZ3l2DJssI0KpTmzm2FZM76sX98mXM+k6taSUjuRyD5Fsg2tYAcE43lzm2 dwzz6LbboFB9avFuz/22fzutH5hz3yeRpdVqPW7i+z6bkElEkmHt8Mvs+rd2w/LnuY6Y6Y5TsgU q/Tb477ZKy9uUqEtZBtUgAwishP49vqHsHRABoWc55SzIcg55NJ1qsQdXRf6YMiMqzXqfZFpcoo qpizyj0AZw== X-Google-Smtp-Source: AGHT+IEO/3BF2um8z5+DNe4Zm2TSiDewizXK5qbi5ZMDbYKWsVZqrjdg3XDrvLFAfgm9LzRn56aX1ORjSWIv+sjDojo= X-Received: by 2002:a05:6214:21aa:b0:86b:9167:b0e9 with SMTP id 6a1803df08f44-8847c489f79mr473269046d6.4.1764438016988; Sat, 29 Nov 2025 09:40:16 -0800 (PST) MIME-Version: 1.0 From: Petar Popovic Date: Sat, 29 Nov 2025 18:40:01 +0100 X-Gm-Features: AWmQ_bmaTobGtft2M7iI6fywxoIarrNlHXTzmUbFckxjKjUIL_ua3kKFhgeeWUo Message-ID: Subject: [PATCH] Fix tui new-layout -horizontal argument placement To: gdb-patches@sourceware.org Content-Type: multipart/alternative; boundary="0000000000003b18e50644bf3d3c" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --0000000000003b18e50644bf3d3c Content-Type: text/plain; charset="UTF-8" >From c3506f07eaf79a3c26e00bc6750708323cac4c99 Mon Sep 17 00:00:00 2001 From: Petar Popovic Date: Sat, 29 Nov 2025 17:41:30 +0100 Subject: [PATCH] Fix tui new-layout -horizontal argument placement The optional argument `-horizontal` from `tui new-layout` is supposed to be checked directly after the command but instead it is checked after the layout name. This commit moves the check to the correct place. --- First time using an email list for patches. Sorry for the previous "just copy/pasted" patches: https://sourceware.org/pipermail/gdb-patches/2025-November/222937.html https://sourceware.org/pipermail/gdb-patches/2025-November/223021.html gdb/tui/tui-layout.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c index 95d20fbf22c..1dcd7086cac 100644 --- a/gdb/tui/tui-layout.c +++ b/gdb/tui/tui-layout.c @@ -1207,17 +1207,17 @@ validate_window_name (const std::string &name) static void tui_new_layout_command (const char *spec, int from_tty) { + bool is_vertical = true; + spec = skip_spaces (spec); + if (check_for_argument (&spec, "-horizontal")) + is_vertical = false; + std::string new_name = extract_arg (&spec); if (new_name.empty ()) error (_("No layout name specified")); if (new_name[0] == '-') error (_("Layout name cannot start with '-'")); - bool is_vertical = true; - spec = skip_spaces (spec); - if (check_for_argument (&spec, "-horizontal")) - is_vertical = false; - std::vector> splits; splits.emplace_back (new tui_layout_split (is_vertical)); gdb::unordered_set seen_windows; -- 2.52.0 --0000000000003b18e50644bf3d3c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
From c3506f07eaf79a3c26e00bc6750708323cac4c99 Mon Sep 17 0= 0:00:00 2001
From: Petar Popovic <pjoetri@gmail.com>
Date: Sat, 29 Nov 2025 17:41:30 +0100
Sub= ject: [PATCH] Fix tui new-layout -horizontal argument placement

The = optional argument `-horizontal` from `tui new-layout` is supposed
to be = checked directly after the command but instead it is checked
after the l= ayout name.
This commit moves the check to the correct place.
---
=
First time using an email list for patches.
Sorry for the previous &= quot;just copy/pasted" patches:
https://sourceware.org/pipe= rmail/gdb-patches/2025-November/222937.html
https://sourcewa= re.org/pipermail/gdb-patches/2025-November/223021.html

=C2=A0gdb= /tui/tui-layout.c | 10 +++++-----
=C2=A01 file changed, 5 insertions(+),= 5 deletions(-)

diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layo= ut.c
index 95d20fbf22c..1dcd7086cac 100644
--- a/gdb/tui/tui-layout.c=
+++ b/gdb/tui/tui-layout.c
@@ -1207,17 +1207,17 @@ validate_window_n= ame (const std::string &name)
=C2=A0static void
=C2=A0tui_new_lay= out_command (const char *spec, int from_tty)
=C2=A0{
+ =C2=A0bool is_= vertical =3D true;
+ =C2=A0spec =3D skip_spaces (spec);
+ =C2=A0if (c= heck_for_argument (&spec, "-horizontal"))
+ =C2=A0 =C2=A0i= s_vertical =3D false;
+
=C2=A0 =C2=A0std::string new_name =3D extract= _arg (&spec);
=C2=A0 =C2=A0if (new_name.empty ())
=C2=A0 =C2=A0 = =C2=A0error (_("No layout name specified"));
=C2=A0 =C2=A0if (= new_name[0] =3D=3D '-')
=C2=A0 =C2=A0 =C2=A0error (_("Layou= t name cannot start with '-'"));
=C2=A0
- =C2=A0bool is_= vertical =3D true;
- =C2=A0spec =3D skip_spaces (spec);
- =C2=A0if (c= heck_for_argument (&spec, "-horizontal"))
- =C2=A0 =C2=A0i= s_vertical =3D false;
-
=C2=A0 =C2=A0std::vector<std::unique_ptr&l= t;tui_layout_split>> splits;
=C2=A0 =C2=A0splits.emplace_back (new= tui_layout_split (is_vertical));
=C2=A0 =C2=A0gdb::unordered_set<std= ::string> seen_windows;
--
2.52.0


--0000000000003b18e50644bf3d3c--