From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id L5zNA5n4pmpoIgkAWB0awg (envelope-from ) for ; Sun, 13 Sep 2026 15:25:13 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=BQ2ytLjX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E07351E033; Sun, 13 Sep 2026 15:25:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C330D1E033 for ; Sun, 13 Sep 2026 15:25:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 57DB14B99F7C for ; Sun, 13 Sep 2026 19:25:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57DB14B99F7C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=BQ2ytLjX Received: from mail-lf2-x10.google.com (mail-lf2-x10.google.com [IPv6:2a00:1450:4864:36::10]) by sourceware.org (Postfix) with ESMTPS id 2A69B4BA9036 for ; Sun, 13 Sep 2026 19:24:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A69B4BA9036 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A69B4BA9036 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a00:1450:4864:36::10 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1789327486; cv=pass; b=aDyZRzCiab128Fl22I98VmdWEFQHPMfr62SpKzlg7aers1h+LCB5I/aNEMLGzGqvI0BlbUqUf7UPktMzzaa3/TDwKRyz3LeNN5Em/m+eozq+nhvHhFla3oFXF26nfK/xtfG+wrPm9RsJ9Q7BKhCI4oGlLZpUUGwyx/mfnUFPa1A= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1789327486; c=relaxed/simple; bh=lg8LK1qFx+Vac8rnF12p1oxnc3IxkrD/qRX9a9LMugY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=c48yqseWEcSH3KlsLMcg9RTgz5mt6UlnnTEj2hJ2UQ8wfdNBIHqcARqFmff2KHtQrfRuIBhW/j7DjuLiNFWJaVut/DqL6xA0j8Z3dv6HhuwJIoqcVNcNS+Dk3uF5/9uLdAgLp2EhfjD63hZzEa35fI5zIayziV6XDtYTXIaVH50= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=BQ2ytLjX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A69B4BA9036 Received: by mail-lf2-x10.google.com with SMTP id 2adb3069b0e04-5b5e4f13d76so1469300e87.3 for ; Sun, 13 Sep 2026 12:24:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789327485; cv=none; d=google.com; s=arc-20260327; b=TLauRwKp3bQcnsks3mB1jeKGVLn8gvwH8FFl/YYA7aZ0kuZu/CW6X+TxXHO/IKwut5 hyWoo9ANKZtC0d/hLRqGoe0KYZtgttV2sDGQAcYK8JFGDlb2Fp0o+SodzWU9DNnveiiw I7x6leTam+wm81RGbSkrAhiMchGrQjQKEnOsW4wYV+u9dJnikSryJlor8q2uQsPN3hHh +zIGSkT4B5p2ImK28ijfl9cYDDf0+3pYQHSKMP88CqY1izEA4c5WDoWjE263r1w2CnlX 1LcxU5o9hx+AnYs7CsJc2nNMBiSw8ssFVlHvRgsHa07vectJHsliwX0xoAoxwxy49Sdp 9mcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=AwWw+0Dpa5jZCXkShDzyDjSgWnZkQpyORASM1K96+q8=; fh=ukMJ4C+itErNSz65vU7hPqqkf8zWsP3SwwD6N60MPG4=; b=WpAnGn3uogSovhf6HDxStpZtG15OfWVgAH5D9QsMCk1dNOjNC6TzBe2GMiFElqEUaK i03k+veHrB8XgwmGRDcTWsF7ulQIYLkLYkrNEOBFuYtsWge2tt9fLv2gHFSm8YLCnnrc HgZNoSZCp8pzZRXbGusBpCP5FvfRyjgUj3eKBbvlbajf8tGPC6LaA2hKPMx6TL5qwG/M PFiR1dpB9wfkTde5LzWEk8luEGa6oaKBDDoD4V+Js3D8NvVYSsuTHUmI4S1Oqdgr1j4s pstIH1UEFlJJO2HPEVCNIJIBbClBEl/v+5yge7jFNCWeqBWxbONFStFIW5CvWMYwnJG4 V61w==; darn=sourceware.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789327485; x=1789932285; darn=sourceware.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AwWw+0Dpa5jZCXkShDzyDjSgWnZkQpyORASM1K96+q8=; b=BQ2ytLjXLSsY6qLPvrmpHazb3EdA9Rb3opMpF3FbGLFbqW6X9aL0XIBAP2vAOs6Z4G 0qwKY1W6aNiEoXQECwDFBFsEJdTbLaBH3Y+XY4WgjOyRTIskY08sUBPOLArh8pJZySSH d5wm44eB9FRFOZay1Psl7VXgO2gD5gwAR5MCFztcoIb1ta/+SsfSwzakwTzh55ByYccC PVNCsEdP5eRtdtyFA9sMzCJvzpRPz4w6Yenl2MN9NkjJE4uiVad3x7QqceiEpPhsesH6 VH3p27E/KekEK2debLKrqaIcNJ0xgfPHcSHA1C/7scqrGaUc3vSwe2WdFZ6d7rPXx7rm 1xWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789327485; x=1789932285; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AwWw+0Dpa5jZCXkShDzyDjSgWnZkQpyORASM1K96+q8=; b=V4m5QLpgR6adHtknLbKBm6EFUfuflL0tDCnWpaDLcW/CQ8MuWeSJVSSGt5GXz9lK93 OXQqYLu0cKiQwR6ZNEDwj9GG3nPB+nOlYw/Dn2ZdWA0HGPWTdaU3O/PzcEWI2R/gFfBE yQc4eTW+eOxyp/Bh8x2ajSDzcobRPNTrfr9cNNqBZxK+i9Ethfe4lV2OWJ+CE3T5yzLs 1+pB4740tsrOe+pld3DJifYiVVRhy+oZBdfxj7uXKsUSqg9lDOm/7ibw8CqUa3nJX+r/ foS6zzZ29jvhH+rHP9kbhf+/I79CI4G4rbOu5koMgHJl7zUl3t03DVHl1MPv0Wyzlrqb G9Og== X-Gm-Message-State: AFuF++mjHWhlAY+hkHoALKvsgHd7RuxBwVrV1vhRG5r7aDmM5TcrrlDG hMSj4nUXGM/XiDlVY0+gjTQ2mpOxWkkOGQHXzA2Kf05hvb3qYlXsgFdwPbt7fqO+BVvskP7o4R3 H8cgNxaW9C10QdPv8pko7PenkABlxsto= X-Gm-Gg: AYBFou3zuMgNAd6u0qnsSx6r7mCU/fBDO8Xx045lCNwK/QE0hR4fzvLzlEukJAxNgIz 5fB0+WkIKrHM1hAL69IvwTLR8BItxkOPGbviYae9+mE6xn1c5rmL/wBQhxV2WTQIACkN8XWBdnT prJDbmUErJ00WDge2f66BxrVKrOkPIsnN5kAWWEllKodmtw8vEaNhThyW1DFGFz9DlGpCu1p2fT 3cM8pMpic9yGxCvgqB33uFK+KwltfNWOo3CipKVFz6Dn2TkDgRbLsnUqGg0ajirZvsUdOhhhpYs 92oYIwxiSpMrXTonmE+udR48Itxxqgzk2BMhkIPZn00CHWms7dfX5RYbZdAUa1t/PGkXsWGHIhA rYeYusPvFrg== X-Received: by 2002:a05:6512:10c6:b0:5b8:9a27:905f with SMTP id 2adb3069b0e04-5b8a8ed0998mr1588956e87.52.1789327484350; Sun, 13 Sep 2026 12:24:44 -0700 (PDT) MIME-Version: 1.0 References: <20260801160233.79-2-oleg.tolmatcev@gmail.com> <87zeyfqxrb.fsf@tromey.com> In-Reply-To: <87zeyfqxrb.fsf@tromey.com> From: Oleg Tolmatcev Date: Sun, 13 Sep 2026 21:24:31 +0200 X-Gm-Features: AcwNN1UP6BcQM0kzoyzBFH6-IHC6VeCPvEKGcOYrckMe6dzpbEoCba9ykR2Vxio Message-ID: Subject: Re: [PATCH] gdb/dap: stop setting CompletionItem.length To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org =D0=BF=D1=82, 21 =D0=B0=D0=B2=D0=B3. 2026=E2=80=AF=D0=B3. =D0=B2 17:49, Tom= Tromey : > > >>>>> "Oleg" =3D=3D Oleg Tolmatcev writes: > > Oleg> Do not set the CompletionItem.length field in completions responses= . > Oleg> According to the DAP spec, length says how many characters the > Oleg> completion text should overwrite. It is not the length of the > Oleg> completion label, so using the label length here is wrong. > > I am not so sure about this. > > The spec says: > > /** > * Length determines how many characters are overwritten by the complet= ion > * text and it is measured in UTF-16 code units. If missing the value 0= is > * assumed which results in the completion text being inserted. > */ > length?: number; > > > But IIUC the gdb 'completions' result will also include whatever prefix > was supplied. > > So for instance I think if we try to complete "print" we might get > results like "print_this" and "print_that". But here we wouldn't want > to report length=3D0, because wouldn't that mean "the completion text > being inserted" would result in "printprint_this" and "printprint_that"? > > Tom Sorry for the delayed reply. You are right, and I will send another patch that properly fixes the problem. Oleg