From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80273 invoked by alias); 27 May 2015 11:36:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80262 invoked by uid 89); 27 May 2015 11:36:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f169.google.com Received: from mail-ig0-f169.google.com (HELO mail-ig0-f169.google.com) (209.85.213.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 27 May 2015 11:36:43 +0000 Received: by igbpi8 with SMTP id pi8so82021243igb.1 for ; Wed, 27 May 2015 04:36:41 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.43.125.200 with SMTP id gt8mr2763335icc.90.1432726601664; Wed, 27 May 2015 04:36:41 -0700 (PDT) Received: by 10.36.111.206 with HTTP; Wed, 27 May 2015 04:36:41 -0700 (PDT) In-Reply-To: References: <20150507180523.19629.77846.stgit@valrhona.uglyboxes.com> <20150507180559.19629.88488.stgit@valrhona.uglyboxes.com> <555A480B.9050200@redhat.com> <555BB47E.9060500@redhat.com> <555BB53F.8040307@redhat.com> <555BB5DF.90906@redhat.com> <555BB741.4050608@redhat.com> Date: Wed, 27 May 2015 11:36:00 -0000 Message-ID: Subject: Re: [PATCH v4 6/9] Explicit locations: introduce explicit locations From: Matt Rice To: Doug Evans Cc: Keith Seitz , Pedro Alves , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00659.txt.bz2 On Tue, May 26, 2015 at 9:42 PM, Doug Evans wrote: > Keith Seitz writes: >> On 05/19/2015 03:14 PM, Pedro Alves wrote: >>> On 05/19/2015 11:12 PM, Keith Seitz wrote: >>>> On 05/19/2015 03:09 PM, Pedro Alves wrote: >>>> >>> OK, as long as >>> >>> b -source 'file with spaces -line 10' -line 20 >>> >>> works as expected (might be worth it of a test), the point is >>> moot then. >> >> I think it does what is expected: >> >> (gdb) b -source 'file with spaces -line 10' -line 20 >> No source file named file with spaces -line 10. > > This error message needs to better delineate the file name. > One could either put it in quotes (and escape internal quotes), > or change it to something like: > No such source file: file with spaces -line 10. > >> I'll add a test if one is missing. These "with spaces" tests appear in >> ls-errs.exp and can be obscured by the fact that they test the parsing >> by generating errors. > > I'm still really uneasy with supporting > b -source file with spaces -line 20 > > This is intended to be the low-level access to specifying locations. > Low level APIs shouldn't be too concerned with easing typing. hmm, I just thought of a 2nd pitfall: in objective-c "b -method" I believe is a currently working linespec to set breakpoints on all the instance methods name 'method' that accept zero arguments. thus there is the potential for collisions, the following header[1] file declares a method on line 47: - (id) source; which should currently be accepted via the linespec: 'b -source' [1] https://github.com/gnustep/gui/blob/master/Headers/AppKit/NSNibConnector.h > It's easier to relax restrictions than impose them after the fact. > Can we require such files to be quoted today, > and then later relax the restriction if there's a compelling > reason to do so?