From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8582 invoked by alias); 24 Aug 2011 05:24:54 -0000 Received: (qmail 8574 invoked by uid 22791); 24 Aug 2011 05:24:52 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Aug 2011 05:24:38 +0000 Received: by ywm13 with SMTP id 13so663989ywm.0 for ; Tue, 23 Aug 2011 22:24:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.177.20 with SMTP id z20mr854591ybe.446.1314163476640; Tue, 23 Aug 2011 22:24:36 -0700 (PDT) Received: by 10.236.34.193 with HTTP; Tue, 23 Aug 2011 22:24:36 -0700 (PDT) In-Reply-To: <20110823193156.GA30724@host1.jankratochvil.net> References: <20110823193156.GA30724@host1.jankratochvil.net> Date: Wed, 24 Aug 2011 05:24:00 -0000 Message-ID: Subject: Re: [patch] Fix target-async SIGTTOU stop (PR 12260) From: Matt Rice To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00431.txt.bz2 On Tue, Aug 23, 2011 at 12:31 PM, Jan Kratochvil wrote: > Hi, > > it is difficult to play with `set target-async on' as it usually SIGTTOU = stops > at various places. > http://sourceware.org/bugzilla/show_bug.cgi?id=3D12260 > > $ ./gdb -nx -ex 'set target-async on' -ex start ./gdb > [...] > Starting program: .../gdb/gdb > [1]+ =A0Stopped =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ./gdb -nx -ex 'set target= -async on' -ex start ./gdb > > If it has a regression it IMO only means there is missing > target_terminal_inferior call at some other place. > > No regressions on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu. =A0But = I was > unable to reproduce the problem under DejaGnu so the regression test may = not > be meaningful. > > Not going to check it in without a review. > Not really a review, just thought i'd mention this is also fixed by the following patch http://sourceware.org/ml/gdb-patches/2011-08/msg00235.html this also fixes the original report of PR 10720 which seems to be a dupe, not sure about the latter reports in 10720. the test cases i added do not cover this either. to quote from elsewhere in that thread matt> more information on PR 10720, which I'd had random difficulties matt> reproducing, I managed to figure out why, the process being attached matt> to must be on the same tty as the gdb process to reproduce it. matt> Haven't been able to reproduce that in the testsuite though. my guess is that deja-gnu doesn't meet this requirement to be able to reproduce it.