On Tue, Oct 4, 2011 at 9:51 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:
>
> Matt> sorry I realized in this argument processing I used strchrnul, but
> Matt> forgot to check if its OK
> Matt> since nothing else in gdb calls it except autoconf macros, and there
> Matt> is no libiberty replacement
> Matt> I doubt that it is... i'll come up with another patch unless someone
> Matt> feels like blessing strchrnul.
>
> Use skip_to_space, see cli-utils.h.
> This has the advantage of also recognizing \t.

Thanks,

attached patch uses skip_to_space, and skip_spaces (to handle
extraneous whitespace)
updates docs with Eli's wanted changes, and fixes a test case which
would have failed if it would run, but wasn't
because of a silly # \ style commented out line.

2011-10-04  Matt Rice  <ratmice@gmail.com>

        * macrocmd.c (macro_no_macro_info): New function.
        (macro_expand_command): Use macro_no_macro_info.
        (macro_expand_once_command): Ditto.
        (info_macro_command): Add argument processing,
        move info_definitions_command here.
        (_initialize_macrocmd): Remove info definitions command.
        Add arguments to info macro help text.
        * NEWS: Replace info definitions command with new info macro options.

 2011-10-04  Matt Rice  <ratmice@gmail.com>

        gdb.texinfo (C Preprocessor Macros): Remove info definitions.
        Add arguments to info macro.

 2011-10-04  Matt Rice  <ratmice@gmail.com>

        gdb.base/info-macros.exp: Make tests for info definitions
        test info macro.  Add tests for info macro argument processing.