From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2983 invoked by alias); 20 Jul 2011 16:56:11 -0000 Received: (qmail 2974 invoked by uid 22791); 20 Jul 2011 16:56:10 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yi0-f41.google.com (HELO mail-yi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 16:55:54 +0000 Received: by yia13 with SMTP id 13so228308yia.0 for ; Wed, 20 Jul 2011 09:55:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.35.165 with SMTP id u25mr11323668yha.188.1311180953527; Wed, 20 Jul 2011 09:55:53 -0700 (PDT) Received: by 10.236.109.131 with HTTP; Wed, 20 Jul 2011 09:55:53 -0700 (PDT) In-Reply-To: References: Date: Wed, 20 Jul 2011 17:04:00 -0000 Message-ID: Subject: Re: [patch] bfin: swapped args in bfin_extract_return_value? From: Matt Rice To: Mike Frysinger Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00550.txt.bz2 On Wed, Jul 20, 2011 at 9:03 AM, Mike Frysinger wrote: > On Tue, Jul 19, 2011 at 22:12, Matt Rice wrote: >> I don't really know this code, so this patch might be wrong, >> and don't have a setup to test it. >> >> but from the types, and the variable names, it smells of arguments >> that have been swapped. > > the Blackfin gdb port is currently being maintained against gdb-6.6 > which didnt have an endian argument. =A0when forward porting to > pre-gdb-7.3, the func now took an endian arg, so one was just thrown > in. =A0when the func was updated in mainline gdb, rather than add the > new arg to the end, it was inserted, so i guess the update review > didnt go as well as hopped. > > in my local version (which contains FDPIC support), it seems like all > calls to store_unsigned_integer() in bfin-tdep.c have the last two > args swapped. =A0so i imagine it was an upgrade thinko. > -mike > Thanks for confirming, I commited my patch as originally posted. not sure if Tom's was an OK, but it seems to at least fall under the 'its obvious now.' rule.