From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115670 invoked by alias); 15 Sep 2016 00:31:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115651 invoked by uid 89); 15 Sep 2016 00:31:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Agree, inconvenient, sits, communication X-HELO: mail-it0-f54.google.com Received: from mail-it0-f54.google.com (HELO mail-it0-f54.google.com) (209.85.214.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Sep 2016 00:31:45 +0000 Received: by mail-it0-f54.google.com with SMTP id n143so51107676ita.1 for ; Wed, 14 Sep 2016 17:31:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tY74tGuJqHytc1xagdmQ5Pm4sa+Bttzahc0FGDxpfUw=; b=WvXo2k5p1VcPNLrEgnQaYnZj5wCmU4xmjBQxZfFYWu57hjlYuDFgSg5Mk+RUpe0hk9 EPYPCbffuo4mXVAQn5XZuFNXGdmpiKrAOUow34foXdsEkVPSF5VMtDJHGs8GvxiBwJEM Nm7fwvaMpzB6YDbJEXIc8bQYXrxNaX7JbY12FOtRs3iW73w5R9tj6loTzkthyS0+GSOe ZmcBgFWfw6viXjb+DRK8NOsQQ3wteW3xT/A/guRi00GBKuNI9ErVgUbbHqsXLeJaKMzU hnJRtuAID7coKr4VUrbZz+pokI+52iXVYuo90kBKYaXNnPn3ZqG3QkiDbAsx4qPECrs7 p8qA== X-Gm-Message-State: AE9vXwO/ei4+24OugOBuft2daxNCHRmBkRrFlaxUQomUe7Ao1rZVD37d3HGpBETq57GIFxqOHDPkMU0beMuOiw== X-Received: by 10.107.38.77 with SMTP id m74mr11536366iom.139.1473899503219; Wed, 14 Sep 2016 17:31:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.140.9 with HTTP; Wed, 14 Sep 2016 17:31:42 -0700 (PDT) In-Reply-To: <87intyrt26.fsf@tromey.com> References: <3AC64B67-79FD-4F55-8F6E-3784C3C4A13B@crelg.com> <87intyrt26.fsf@tromey.com> From: Matt Rice Date: Thu, 15 Sep 2016 00:31:00 -0000 Message-ID: Subject: Re: Restored Objective-C language support To: Tom Tromey Cc: Giah de Barag , GDB Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00133.txt.bz2 On Wed, Sep 14, 2016 at 3:54 PM, Tom Tromey wrote: >>>>>> "Giah" == Giah de Barag writes: > > Giah> Patches are presented which restore objective-c language support. > Giah> These patches are relative to the head of the gdb-7.11-branch. > > I didn't read the patches really, but I feel a bit responsible since I > merged objc-exp.y into c-exp.y back in the day, and apparently not well. > > I think the most important thing to do to avoid future problems is make > sure the objc tests are working. The last time I looked at this, I > think they weren't working properly at all. I Agree, part of the problem is that during some "modernization" of the objective-c runtime, the "Object" class, the root class that is distributed with the runtime was neutered basically into non-existence... I didn't really manage to catch it before release, and gave up afterwords... https://github.com/gnustep/libobjc2/blob/master/objc/Object.h https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libobjc/objc/Object.h;h=f69f8139e8c0b0841e806f72747d09ca641dd2f8;hb=refs/heads/trunk There used to be... methods, in particular there was a method called 'new' which allowed one to actually allocate and instantiate an object in a portable fashion. given that there are about 50 different objective-c runtimes, It seemed completely out of scope for the gdb testsuite... I'm not sure what gcc and clang themselves are using to test i'd imagine the c/runtime specific interface they provide... but it's a bit inconvenient for a project like gdb that sits between gcc and something external like gnustep (which provides its own mechanism for instantiating objects). > Also, it would be good to have new tests for the patches you wrote. > > Giah> Also, this is the first time I am doing something like this, so if > Giah> I am neglecting any rule of communication of this list, please > Giah> inform me, and I will correct it. > > Nothing wrong with your email but there are some contribution > instructions for gdb: > > https://sourceware.org/gdb/wiki/ContributionChecklist > > Tom