From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8551 invoked by alias); 9 Feb 2017 04:34:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8528 invoked by uid 89); 9 Feb 2017 04:34:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=sk:depreca, Hx-languages-length:1474, H*f:sk:ab4096f, H*i:sk:ab4096f X-HELO: mail-io0-f181.google.com Received: from mail-io0-f181.google.com (HELO mail-io0-f181.google.com) (209.85.223.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Feb 2017 04:34:23 +0000 Received: by mail-io0-f181.google.com with SMTP id v96so8257403ioi.0 for ; Wed, 08 Feb 2017 20:34:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5Zl+YITidW8fVQwJJCIPJEM6DIvhPm9G83mZPCaUTEw=; b=kU1g4XIYTmTFam8Vi4Dih9KKWo+wYHG/ZYw46Qt3S++4wklPjaYK5yGqm6i8HqTn8u Wu9skVJlUaT0kXyiL1Qq7j8mIoX0ZNfR0AvzOm65DdfvvGGDhNsyI/injYE9ppCuk41h X57JQDCIxEkrP0TgWQUwKbZ6wLN9A5aXy11eIHTEKHPTudFY1ovf7COmQrxf4y744wDm 9TkrCeyCoC8mXWmEO8BQ4ZMmZRTgcXbuJmaCSiYAHFf883zIrij/O4gpmPtYEGKxNzIs IhSvkYLHRrrm476bYGc2jxj48jYGjUUFAxcfL403W5rGm7PZllK49jiFTePPtLKnwWNf 0CVg== X-Gm-Message-State: AMke39nKlerrmajYrmt/XHUrUDqIVPTDzzPV4tmdRyZbZVtofAlO5Z0yNAYovdDj+5woEjKdLp0MMQ2K6CP+QQ== X-Received: by 10.107.59.201 with SMTP id i192mr1684002ioa.196.1486614861584; Wed, 08 Feb 2017 20:34:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.36.208.84 with HTTP; Wed, 8 Feb 2017 20:34:20 -0800 (PST) In-Reply-To: References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-2-tom@tromey.com> <20170116113021.sar3yh5ivykpqmbw@ball> <87inok708e.fsf@tromey.com> From: Matt Rice Date: Thu, 09 Feb 2017 04:34:00 -0000 Message-ID: Subject: Re: [RFA 1/5] Remove some ui_out-related cleanups from Python To: Pedro Alves Cc: Tom Tromey , Trevor Saunders , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00211.txt.bz2 On Wed, Feb 8, 2017 at 3:51 PM, Pedro Alves wrote: >> Pedro> Patch LGTM with Trevor's and Simon's nits addressed. >> >> I have that done locally, but I've just been waiting until your series >> lands, so I can rebase. And then maybe the option stuff wouldn't be >> needed anyway? I don't remember the details from your branch, I was >> just waiting for the big rebase to find out. > > My series is all in master. I think we'll still need your patch, since I only > touched ui_files. I haven't done anything with ui_out list/tuple building. I haven't been following much lately due to programming mostly in languages unsupported by gdb apologies if this has been hashed out before. Wondering if this would be a good opportunity to try and transition ui_out_list construction into a more type safe manner, e.g. result ==> variable "=" value list ==> "[]" | "[" value ( "," value )* "]" | "[" result ( "," result )* "]" currently when building a list, it didn't specify whether you were declaring a list of results or a list of values, unless/until the first value or result was added, and IIRC this | property wasn't really explicitly enforced. it'd be nice to migrate this to something like: result_list, value_list, deprecated_unspecified_list, It would be nice to know if/when you guys think it would be a convenient time to introduce such a change so I could get back up to speed...