From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11803 invoked by alias); 11 Sep 2011 13:24:39 -0000 Received: (qmail 11790 invoked by uid 22791); 11 Sep 2011 13:24:38 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 11 Sep 2011 13:24:23 +0000 Received: by ywe9 with SMTP id 9so938906ywe.0 for ; Sun, 11 Sep 2011 06:24:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.191.198 with SMTP id g46mr20828826yhn.124.1315747462602; Sun, 11 Sep 2011 06:24:22 -0700 (PDT) Received: by 10.236.201.33 with HTTP; Sun, 11 Sep 2011 06:24:22 -0700 (PDT) In-Reply-To: References: <201108042110.45405.pedro@codesourcery.com> <201109101751.35845.pedro@codesourcery.com> Date: Sun, 11 Sep 2011 14:41:00 -0000 Message-ID: Subject: Re: Eliminate tui_command_loop From: Matt Rice To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf30563d5b1f5f1e04acaa54e8 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00183.txt.bz2 --20cf30563d5b1f5f1e04acaa54e8 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1124 On Sat, Sep 10, 2011 at 11:47 AM, Matt Rice wrote: > > I could easily be missing something though and it's fine. > ^ correct answer... it's handled in tui_setup_io(). the attached patch based on Pedro's WIP, fixes a small case that he missed. and makes interp.exp hit all of these failures this is PR gdb/13175 (though Nick's reproducer hits the case you missed). I modified the existing prompt checks in this file, because the gdb_expect was causing the test to take 30 seconds to complete, which is now down to 0 seconds... hopefully that change is ok... with this Pedro's patch runs through the testsuite no new failures... feel free to merge in with your patch or have me commit the tests seperately, whatever is easiest for you really... 2011-09-11 Matt Rice * mi/mi-interp.c (mi_interpreter_init): Initialize default MI version to 2. (_initialize_mi_interp): Move comment to mi_interpreter_init. 2011-09-11 Matt Rice PR gdb/13175 * gdb.base/interp.exp: New tests. * gdb.base/interp.c: New file. --20cf30563d5b1f5f1e04acaa54e8 Content-Type: text/x-patch; charset=US-ASCII; name="foo.diff" Content-Disposition: attachment; filename="foo.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gsg1zjn10 Content-length: 6946 RnJvbSBjYmFlYmZmYjY0OTJlMWZlNWIwMzNjNTY5NTczMWIwYjU5ZjY5OGY1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBtYXR0IHJpY2UgPHJh dG1pY2VAZ21haWwuY29tPgpEYXRlOiBTdW4sIDExIFNlcCAyMDExIDA0OjQw OjUxIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRGVmYXVsdCBJTlRFUl9NSSB0 byB2ZXJzaW9uIDIsIGFkZCB0ZXN0cy4KCi0tLQogZ2RiL21pL21pLWludGVy cC5jICAgICAgICAgICAgICAgIHwgICAgNyArKy0tCiBnZGIvdGVzdHN1aXRl L2dkYi5iYXNlL2ludGVycC5jICAgfCAgIDIzICsrKysrKysrKysrKysrCiBn ZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2ludGVycC5leHAgfCAgIDYwICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KIDMgZmlsZXMgY2hh bmdlZCwgNzggaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCiBjcmVh dGUgbW9kZSAxMDA2NDQgZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9pbnRlcnAu YwoKZGlmZiAtLWdpdCBhL2dkYi9taS9taS1pbnRlcnAuYyBiL2dkYi9taS9t aS1pbnRlcnAuYwppbmRleCBiZDQ5ZWJjLi5mNTYxY2Q2IDEwMDY0NAotLS0g YS9nZGIvbWkvbWktaW50ZXJwLmMKKysrIGIvZ2RiL21pL21pLWludGVycC5j CkBAIC05Myw5ICs5MywxMSBAQCBtaV9pbnRlcnByZXRlcl9pbml0IChzdHJ1 Y3QgaW50ZXJwICppbnRlcnAsIGludCB0b3BfbGV2ZWwpCiAgIG1pLT5ldmVu dF9jaGFubmVsID0gbWlfY29uc29sZV9maWxlX25ldyAocmF3X3N0ZG91dCwg Ij0iLCAwKTsKIAogICBuYW1lID0gaW50ZXJwX25hbWUgKGludGVycCk7Cisg IC8qIElOVEVSUF9NSSBzZWxlY3RzIHRoZSBtb3N0IHJlY2VudCByZWxlYXNl ZCB2ZXJzaW9uLiAgIm1pMiIgd2FzCisgICAgIHJlbGVhc2VkIGFzIHBhcnQg b2YgR0RCIDYuMC4gICovCiAgIGlmIChzdHJjbXAgKG5hbWUsIElOVEVSUF9N STEpID09IDApCiAgICAgbWlfdmVyc2lvbiA9IDE7Ci0gIGVsc2UgaWYgKHN0 cmNtcCAobmFtZSwgSU5URVJQX01JMikgPT0gMCkKKyAgZWxzZSBpZiAoc3Ry Y21wIChuYW1lLCBJTlRFUlBfTUkyKSA9PSAwIHx8IHN0cmNtcCAobmFtZSwg SU5URVJQX01JKSA9PSAwKQogICAgIG1pX3ZlcnNpb24gPSAyOwogICBlbHNl IGlmIChzdHJjbXAgKG5hbWUsIElOVEVSUF9NSTMpID09IDApCiAgICAgbWlf dmVyc2lvbiA9IDM7CkBAIC03NDIsOCArNzQ0LDUgQEAgX2luaXRpYWxpemVf bWlfaW50ZXJwICh2b2lkKQogICBpbnRlcnBfYWRkIChpbnRlcnBfbmV3IChJ TlRFUlBfTUkxLCAmcHJvY3MpKTsKICAgaW50ZXJwX2FkZCAoaW50ZXJwX25l dyAoSU5URVJQX01JMiwgJnByb2NzKSk7CiAgIGludGVycF9hZGQgKGludGVy cF9uZXcgKElOVEVSUF9NSTMsICZwcm9jcykpOwotCi0gIC8qICJtaSIgc2Vs ZWN0cyB0aGUgbW9zdCByZWNlbnQgcmVsZWFzZWQgdmVyc2lvbi4gICJtaTIi IHdhcwotICAgICByZWxlYXNlZCBhcyBwYXJ0IG9mIEdEQiA2LjAuICAqLwog ICBpbnRlcnBfYWRkIChpbnRlcnBfbmV3IChJTlRFUlBfTUksICZwcm9jcykp OwogfQpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9pbnRl cnAuYyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW50ZXJwLmMKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMmY1MmQzZQotLS0gL2Rl di9udWxsCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW50ZXJwLmMK QEAgLTAsMCArMSwyMyBAQAorLyogVGhpcyB0ZXN0IHByb2dyYW0gaXMgcGFy dCBvZiBHREIsIHRoZSBHTlUgZGVidWdnZXIuCisKKyAgIENvcHlyaWdodCAy MDExCisgICBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKworICAg VGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0 cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKyAgIGl0IHVuZGVyIHRoZSB0ZXJt cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlz aGVkIGJ5CisgICB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRo ZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorICAgKGF0IHlvdXIg b3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKworICAgVGhpcyBwcm9ncmFt IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1 c2VmdWwsCisgICBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQg ZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICAgTUVSQ0hBTlRBQklM SVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2Vl IHRoZQorICAgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUg ZGV0YWlscy4KKworICAgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29w eSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyAgIGFsb25n IHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cu Z251Lm9yZy9saWNlbnNlcy8+LgorKi8KKworaW50IG1haW4oaW50IGFyZ2Ms IGNvbnN0IGNoYXIgKiphcmd2KQoreworICByZXR1cm4gMDsKK30KZGlmZiAt LWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW50ZXJwLmV4cCBiL2dk Yi90ZXN0c3VpdGUvZ2RiLmJhc2UvaW50ZXJwLmV4cAppbmRleCBiYjExZjA0 Li5jYTA5Y2IzIDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5iYXNl L2ludGVycC5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9pbnRl cnAuZXhwCkBAIC0yMCwxNiArMjAsMjkgQEAgaWYgJHRyYWNlbGV2ZWwgdGhl biB7CiAgICAgc3RyYWNlICR0cmFjZWxldmVsCiB9CiAKK3NldCB0ZXN0Zmls ZSAiaW50ZXJwIgorc2V0IHNyY2ZpbGUgJHt0ZXN0ZmlsZX0uYworc2V0IGJp bmZpbGUgJHtvYmpkaXJ9LyR7c3ViZGlyfS8ke3Rlc3RmaWxlfQoraWYgIHsg W2dkYl9jb21waWxlICIke3NyY2Rpcn0vJHtzdWJkaXJ9LyR7c3JjZmlsZX0i ICIke2JpbmZpbGV9IiBleGVjdXRhYmxlIHtkZWJ1Z31dICE9ICIiIH0gewor ICAgIHVudGVzdGVkICJDb3VsZG4ndCBjb21waWxlICR0ZXN0ZmlsZS5leHAg dGVzdCBwcm9ncmFtIgorICAgIHJldHVybiAtMQorfQorCitnZGJfZXhpdAog Z2RiX3N0YXJ0CitnZGJfcmVpbml0aWFsaXplX2RpciAkc3JjZGlyLyRzdWJk aXIKK2dkYl9sb2FkICRiaW5maWxlCiAKKyMgRm9yY2UgdGhlc2UgdG8gb2Zm IGZvciB0d28gcHJvbXB0IG1hdGNoaW5nLgorZ2RiX3Rlc3QgIm1haW50IHRp bWUgMCIgIiIgIiIKK2dkYl90ZXN0ICJtYWludCBzcGFjZSAwIiAiIiAiIgor CitzZXQgdHdvcHJvbXB0cyAiXHJcbiRnZGJfcHJvbXB0IFxyXG4kZ2RiX3By b21wdCAkIgogIyBEbyBub3QgdXNlIGdkYl90ZXN0IGZvciB0aGlzIHRlc3Qs IHNpbmNlIGl0IGhhcyB0d28gcHJvbXB0cy4KIHNldCBjbWQgImludGVycHJl dGVyLWV4ZWMgbWkgXCItdmFyLXVwZGF0ZSAqXCIiCiBnZGJfdGVzdF9tdWx0 aXBsZSAkY21kICRjbWQgewotICAgIC1yZSAiXFxeZG9uZSxjaGFuZ2VsaXN0 PVxcXFtcXFxdXHJcbiRnZGJfcHJvbXB0ICIgeworICAgIC1yZSAiXFxeZG9u ZSxjaGFuZ2VsaXN0PVxcXFtcXFxdJHR3b3Byb21wdHMiIHsKIAlwYXNzICIk Y21kIgotCWdkYl9leHBlY3QgMSB7Ci0JICAgIC1yZSAiXHJcbiRnZGJfcHJv bXB0ICQiIHsgfQotCX0KICAgICB9CiB9CiBnZGJfdGVzdCAiaW50ZXJwcmV0 ZXItZXhlYyBjb25zb2xlIFwic2hvdyB2ZXJzaW9uXCIiICJHTlUgZ2RiIC4q IgpAQCAtMzcsMTIgKzUwLDQzIEBAIGdkYl90ZXN0ICJpbnRlcnByZXRlci1l eGVjIGNvbnNvbGUgXCJzaG93IHZlcnNpb25cIiIgIkdOVSBnZGIgLioiCiAj IFJlZ3Jlc3Npb24gdGVzdCBmb3IgY3Jhc2ggd2hlbiBhbiBleGNlcHRpb24g b2NjdXJzIGluIG1pX3BhcnNlLgogZ2RiX3Rlc3RfbXVsdGlwbGUgImludGVy cHJldGVyLWV4ZWMgbWkgXCItYnJlYWstaW5zZXJ0IC0tdGhyZWFkIGFcIiIg XAogICAgICJyZWdyZXNzaW9uIHRlc3QgZm9yIG1pX3BhcnNlIGNyYXNoIiB7 Ci0JLXJlICIuZXJyb3IsbXNnPS5JbnZhbGlkIHZhbHVlIGZvciB0aGUgJy0t dGhyZWFkJyBvcHRpb24uXHJcbiRnZGJfcHJvbXB0ICIgeworCS1yZSAiLmVy cm9yLG1zZz0uSW52YWxpZCB2YWx1ZSBmb3IgdGhlICctLXRocmVhZCcgb3B0 aW9uLiR0d29wcm9tcHRzIiB7CiAJICAgIHBhc3MgIiRjbWQiCi0JICAgIGdk Yl9leHBlY3QgMSB7Ci0JCS1yZSAiXHJcbiRnZGJfcHJvbXB0ICQiIHsgfQot CSAgICB9CiAJfQogICAgIH0KIAorc2V0IGNtZCAiaW50ZXJwcmV0ZXItZXhl YyBtaSBcIi1zdGFjay1pbmZvLWZyYW1lXCIiCitnZGJfdGVzdF9tdWx0aXBs ZSAkY21kICRjbWQgeworICAgIC1yZSAiLmVycm9yLG1zZz0uTm8gcmVnaXN0 ZXJzXC4uJHR3b3Byb21wdHMiIHsKKyAgICAgICAgcGFzcyAiJGNtZCIKKyAg ICB9Cit9CisKK3NldCBjbWQgImludGVycHJldGVyLWV4ZWMgbWkxIFwiLWJy ZWFrLWluc2VydCBtYWluXCIiCitnZGJfdGVzdF9tdWx0aXBsZSAkY21kICRj bWQgeworICAgIC1yZSAiLmRvbmUuYmtwdD0ubnVtYmVyPS5cWzAtOVxdLiok dHdvcHJvbXB0cyIgeworICAgICAgICBwYXNzICIkY21kIgorICAgIH0KK30K Kworc2V0IGNtZCAiaW50ZXJwcmV0ZXItZXhlYyBtaTIgXCItYnJlYWstaW5z ZXJ0IG1haW5cIiIKK2dkYl90ZXN0X211bHRpcGxlICRjbWQgJGNtZCB7Cisg ICAgLXJlICIuZG9uZS5ia3B0PS5udW1iZXI9LlxbMC05XF0uKiR0d29wcm9t cHRzIiB7CisgICAgICAgIHBhc3MgIiRjbWQiCisgICAgfQorfQorCitzZXQg Y21kICJpbnRlcnByZXRlci1leGVjIG1pMyBcIi1icmVhay1pbnNlcnQgbWFp blwiIgorZ2RiX3Rlc3RfbXVsdGlwbGUgJGNtZCAkY21kIHsKKyAgICAtcmUg Ii5kb25lLmJrcHQ9Lm51bWJlcj0uXFswLTlcXS4qJHR3b3Byb21wdHMiIHsK KyAgICAgICAgcGFzcyAiJGNtZCIKKyAgICB9Cit9CisKK2lmICFbcnVudG9f bWFpbl0gdGhlbiB7CisgIGZhaWwgIiR7dGVzdGZpbGV9LmV4cCBjYW4gcnVu IHRvIG1haW4uIgorICByZXR1cm4gLTE7Cit9CisKK2dkYl90ZXN0ICJsaXN0 IiAiLipcWzAtOVxdLippbnQgbWFpbi4qIiAiJHt0ZXN0ZmlsZX0uZXhwIGNh biBsaXN0IHNvdXJjZXMiCiBnZGJfZXhpdAotLSAKMS43LjQuNAoK --20cf30563d5b1f5f1e04acaa54e8--