From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18979 invoked by alias); 2 Aug 2011 17:59:06 -0000 Received: (qmail 18673 invoked by uid 22791); 2 Aug 2011 17:59:05 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-yi0-f41.google.com (HELO mail-yi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Aug 2011 17:58:48 +0000 Received: by yia13 with SMTP id 13so21171yia.0 for ; Tue, 02 Aug 2011 10:58:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.155.167 with SMTP id j27mr4162583yhk.346.1312307927131; Tue, 02 Aug 2011 10:58:47 -0700 (PDT) Received: by 10.236.34.193 with HTTP; Tue, 2 Aug 2011 10:58:47 -0700 (PDT) In-Reply-To: References: Date: Tue, 02 Aug 2011 17:59:00 -0000 Message-ID: Subject: Re: [patch] python prompt additions at first prompt. From: Matt Rice To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf302d4b68d526d504a9897f77 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00034.txt.bz2 --20cf302d4b68d526d504a9897f77 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1350 On Tue, Aug 2, 2011 at 2:07 AM, Phil Muldoon wrote: > Matt Rice writes: > >> On Mon, Aug 1, 2011 at 7:13 AM, Phil Muldoon wrote: > >> Think it was the quoting of $gdb_prompt which had me foiled. >> >> 2011-08-01 =A0Matt Rice =A0 >> >> =A0 =A0 =A0 =A0 * gdb.python/py-prompt.exp: New file. > > Thanks. > >> +++ b/gdb/testsuite/gdb.python/py-prompt.exp >> @@ -0,0 +1,60 @@ >> +# Copyright (C) 2009, 2010, 2011 Free Software Foundation, Inc. >> + > > This is a new file, so we just need 2011. Oops, > Also, the other prompt tests are in python.exp, so this standalone test > is kind of an anomaly. =A0What do you think about combining the python.exp > prompt tests into this test file? =A0If you think that is ok, then you can > just submit another consolidation patch after this one has been approved > and checked in. sure don't mind at all, with all the gdb invocations and global variables in this test and python.exp being shared between many tests I didn't want to ugly it up. > If there is a method to utilise a formal PASS/FAIL into the test I would > prefer that. I managed to finagle this into working with a modified gdb_start. I stuck it in lib because i imagine it has to be for the baseboard override to work, even though its only used by this test? --20cf302d4b68d526d504a9897f77 Content-Type: text/x-patch; charset=US-ASCII; name="testsuite.diff" Content-Disposition: attachment; filename="testsuite.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gqv5larc0 Content-length: 7316 ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1wcm9t cHQuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LXByb21wdC5l eHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTE4OWJj MwotLS0gL2Rldi9udWxsCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhv bi9weS1wcm9tcHQuZXhwCkBAIC0wLDAgKzEsNzUgQEAKKyMgQ29weXJpZ2h0 IChDKSAyMDExIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisj IFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlz dHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJt cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlz aGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhl ciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9w dGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBp cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsLAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkg b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhl CisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFp bHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGgg dGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9y Zy9saWNlbnNlcy8+LgorCisjIFRoaXMgZmlsZSBpcyBwYXJ0IG9mIHRoZSBH REIgdGVzdHN1aXRlLiAgSXQgdGVzdHMgdGhlIG1lY2hhbmlzbQorIyBmb3Ig ZGVmaW5pbmcgdGhlIHByb21wdCBpbiBQeXRob24uCisKK2lmICR0cmFjZWxl dmVsIHRoZW4geworICAgIHN0cmFjZSAkdHJhY2VsZXZlbAorfQorCitsb2Fk X2xpYiBnZGItcHl0aG9uLmV4cAorbG9hZF9saWIgcHJvbXB0LmV4cAorCisj IFN0YXJ0IHdpdGggYSBmcmVzaCBnZGIuCisKK2dkYl9leGl0CitnZGJfc3Rh cnQKK2dkYl9yZWluaXRpYWxpemVfZGlyICRzcmNkaXIvJHN1YmRpcgorCisj IFNraXAgYWxsIHRlc3RzIGlmIFB5dGhvbiBzY3JpcHRpbmcgaXMgbm90IGVu YWJsZWQuCitpZiB7IFtza2lwX3B5dGhvbl90ZXN0c10gfSB7IGNvbnRpbnVl IH0KK2dkYl9leGl0CisKK2dsb2JhbCBHREJGTEFHUworc2V0IHNhdmVkX2dk YmZsYWdzICRHREJGTEFHUworc2V0IEdEQkZMQUdTIFtjb25jYXQgJEdEQkZM QUdTICIgLWV4IFwic2V0IGhlaWdodCAwXCIiXQorc2V0IEdEQkZMQUdTIFtj b25jYXQgJEdEQkZMQUdTICIgLWV4IFwic2V0IHdpZHRoIDBcIiJdCitzZXQg R0RCRkxBR1MgW2NvbmNhdCAkR0RCRkxBR1MgIiAtZXggXCJweXRob24gaSA9 IDBcIiJdCitzZXQgcHJvbXB0X2Z1bmMgInB5dGhvbiBkZWYgZm9vKHgpOiBn bG9iYWwgaTsgaSArPSAxOyByZXR1cm4gXCcoRm9vKSBcJyIKK3NldCBHREJG TEFHUyBbY29uY2F0ICRHREJGTEFHUyAiIC1leCBcIiRwcm9tcHRfZnVuY1wi Il0KK3NldCBHREJGTEFHUyBbY29uY2F0ICRHREJGTEFHUyAiIC1leCBcInB5 dGhvbiBnZGIucHJvbXB0X2hvb2s9Zm9vXCIiXQorCitzZXQgdG1wX2dkYmZs YWdzICRHREJGTEFHUworc2V0IHNhdmVkX2dkYl9wcm9tcHQgJGdkYl9wcm9t cHQKK3NldCBnZGJfcHJvbXB0X2ZhaWwgIlxbKFxdZ2RiXFspXF0iCisKK2ds b2JhbCBnZGJfcHJvbXB0CisjIERvZXMgbm90IGluY2x1ZGUgdGhlIHNwYWNl IGF0IHRoZSBlbmQgb2YgdGhlIHByb21wdC4KKyMgZ2RiX3Rlc3QgZXhwZWN0 cyBpdCBub3QgdG8gYmUgdGhlcmUuCitzZXQgZ2RiX3Byb21wdCAiXFsoXF1G b29cWylcXSIKKworc2V0IEdEQkZMQUdTIFtjb25jYXQgJHRtcF9nZGJmbGFn cyAiIC1leCBcInNldCBlZGl0aW5nIG9uXCIiXQorcHJvbXB0X2dkYl9zdGFy dAorZ2RiX3Rlc3QgInB5dGhvbiB4ID0gaTsgcHJpbnQgZ2RiLmV4ZWN1dGUo XCJzaG93IHByb21wdFwiLCB0b19zdHJpbmcgPSBUcnVlKSIgXAorCSAiLipw cm9tcHQgaXMgXCIkZ2RiX3Byb21wdCBcIi4qIiBcCisJICJzaG93IHByb21w dCBnZXRzIHRoZSBjb3JyZWN0IHJlc3VsdCIKK2dkYl90ZXN0ICJweXRob24g cHJpbnQgeCwgaSIgIjEgMiIgXAorCSAicmV0cmlldmluZyB0aGUgcHJvbXB0 IGNhdXNlcyBubyBleHRyYSBwcm9tcHRfaG9vayBjYWxscyIKK2dkYl9leGl0 CisKKworc2V0IEdEQkZMQUdTIFtjb25jYXQgJHRtcF9nZGJmbGFncyAiIC1l eCBcInNldCBlZGl0aW5nIG9mZlwiIl0KK3Byb21wdF9nZGJfc3RhcnQKK2dk Yl90ZXN0ICJweXRob24geCA9IGk7IHByaW50IGdkYi5leGVjdXRlKFwic2hv dyBwcm9tcHRcIiwgdG9fc3RyaW5nID0gVHJ1ZSkiIFwKKwkgIi4qcHJvbXB0 IGlzIFwiJGdkYl9wcm9tcHQgXCIuKiIgXAorCSAic2hvdyBwcm9tcHQgZ2V0 cyB0aGUgY29ycmVjdCByZXN1bHQgMiIKK2dkYl90ZXN0ICJweXRob24gcHJp bnQgeCwgaSIgIjEgMiIgXAorCSAicmV0cmlldmluZyB0aGUgcHJvbXB0IGNh dXNlcyBubyBleHRyYSBwcm9tcHRfaG9vayBjYWxscyAyIgorZ2RiX2V4aXQK Kworc2V0IEdEQkZMQUdTICRzYXZlZF9nZGJmbGFncworc2V0IGdkYl9wcm9t cHQgJHNhdmVkX2dkYl9wcm9tcHQKK3JldHVybiAwCmRpZmYgLS1naXQgYS9n ZGIvdGVzdHN1aXRlL2xpYi9wcm9tcHQuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9s aWIvcHJvbXB0LmV4cApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi44NDE4NmNjCi0tLSAvZGV2L251bGwKKysrIGIvZ2RiL3Rlc3RzdWl0 ZS9saWIvcHJvbXB0LmV4cApAQCAtMCwwICsxLDg2IEBACisjIENvcHlyaWdo dCAoQykgMjAxMSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKyMK KyMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVk aXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKyMgaXQgdW5kZXIgdGhlIHRl cm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJs aXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0 aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3IKKyMgKGF0IHlvdXIg b3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyMKKyMgVGhpcyBwcm9ncmFt IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1 c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElU WSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0 aGUKKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0 YWlscy4KKyMKKyMgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBv ZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyMgYWxvbmcgd2l0 aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUu b3JnL2xpY2Vuc2VzLz4uCisKKyMgU3BlY2lhbGl6ZWQgc3Vicm91dGluZXMg Zm9yIGxhdW5jaGluZyBnZGIgYW5kIHRlc3RpbmcgdGhlIHZlcnkgZmlyc3Qg cHJvbXB0LgorCisKKyMKKyMgc3RhcnQgZ2RiIC0tIHN0YXJ0IGdkYiBydW5u aW5nLCBwcm9tcHQgcHJvY2VkdXJlCisjIHRoaXMgcHJvY2VkdXJlIGRpZmZl cnMgZnJvbSB0aGUgZGVmYXVsdCBpbiB0aGF0IHlvdSBtdXN0IHBhc3MgJ3Nl dCBoZWlnaHQgMCcsCisjIGFuZCAnc2V0IHdpZHRoIDAnLCB5b3Vyc2VsZiBp biBHREJGTEFHUywgYW5kIGl0IGhhcyBhIGdkYl9wcm9tcHRfZmFpbCB2YXJp YWJsZSwKKyMKKyMgdXNlcyBwYXNzIGlmIGl0IHNlZXMgJGdkYl9wcm9tcHQs IGFuZCBmYWlsIGlmIGl0IHNlZXMgJGdkYl9wcm9tcHRfZmFpbC4KKyMKK3By b2MgZGVmYXVsdF9wcm9tcHRfZ2RiX3N0YXJ0IHsgfSB7CisgICAgZ2xvYmFs IHZlcmJvc2UKKyAgICBnbG9iYWwgR0RCCisgICAgZ2xvYmFsIElOVEVSTkFM X0dEQkZMQUdTIEdEQkZMQUdTCisgICAgZ2xvYmFsIGdkYl9wcm9tcHQKKyAg ICBnbG9iYWwgZ2RiX3Byb21wdF9mYWlsCisgICAgZ2xvYmFsIHRpbWVvdXQK KyAgICBnbG9iYWwgZ2RiX3NwYXduX2lkOworCisgICAgZ2RiX3N0b3Bfc3Vw cHJlc3NpbmdfdGVzdHM7CisKKyAgICB2ZXJib3NlICJTcGF3bmluZyAkR0RC ICRJTlRFUk5BTF9HREJGTEFHUyAkR0RCRkxBR1MiCisKKyAgICBpZiBbaW5m byBleGlzdHMgZ2RiX3NwYXduX2lkXSB7CisJcmV0dXJuIDA7CisgICAgfQor CisgICAgaWYgIVtpc19yZW1vdGUgaG9zdF0geworCWlmIHsgW3doaWNoICRH REJdID09IDAgfSB0aGVuIHsKKwkgICAgcGVycm9yICIkR0RCIGRvZXMgbm90 IGV4aXN0LiIKKwkgICAgZXhpdCAxCisJfQorICAgIH0KKyAgICBzZXQgcmVz IFtyZW1vdGVfc3Bhd24gaG9zdCAiJEdEQiAkSU5URVJOQUxfR0RCRkxBR1Mg JEdEQkZMQUdTIFtob3N0X2luZm8gZ2RiX29wdHNdIl07CisgICAgaWYgeyAk cmVzIDwgMCB8fCAkcmVzID09ICIiIH0geworCXBlcnJvciAiU3Bhd25pbmcg JEdEQiBmYWlsZWQuIgorCXJldHVybiAxOworICAgIH0KKyAgICBnZGJfZXhw ZWN0IDM2MCB7CisJLXJlICJcW1xyXG5cXSRnZGJfcHJvbXB0X2ZhaWwgJCIg eworCSAgICBmYWlsICJHREIgaW5pdGlhbGl6aW5nIGZpcnN0IHByb21wdCIK Kwl9CisJLXJlICJcW1xyXG5cXSRnZGJfcHJvbXB0ICQiIHsKKwkgICAgcGFz cyAiR0RCIGluaXRpYWxpemluZyBmaXJzdCBwcm9tcHQiCisJfQorCS1yZSAi JGdkYl9wcm9tcHQgJCIJeworCSAgICBwZXJyb3IgIkdEQiBuZXZlciBpbml0 aWFsaXplZC4iCisJICAgIHJldHVybiAtMQorCX0KKwktcmUgIiRnZGJfcHJv bXB0X2ZhaWwgJCIJeworCSAgICBwZXJyb3IgIkdEQiBuZXZlciBpbml0aWFs aXplZC4iCisJICAgIHJldHVybiAtMQorCX0KKwl0aW1lb3V0CXsKKwkgICAg cGVycm9yICIodGltZW91dCkgR0RCIG5ldmVyIGluaXRpYWxpemVkIGFmdGVy IDEwIHNlY29uZHMuIgorCSAgICByZW1vdGVfY2xvc2UgaG9zdDsKKwkgICAg cmV0dXJuIC0xCisJfQorICAgIH0KKyAgICBzZXQgZ2RiX3NwYXduX2lkIC0x OworICAgIHJldHVybiAwOworfQorCisjCisjIE92ZXJyaWRhYmxlIGZ1bmN0 aW9uLiBZb3UgY2FuIG92ZXJyaWRlIHRoaXMgZnVuY3Rpb24gaW4geW91cgor IyBiYXNlYm9hcmQgZmlsZS4KKyMKK3Byb2MgcHJvbXB0X2dkYl9zdGFydCB7 IH0geworICAgIGRlZmF1bHRfcHJvbXB0X2dkYl9zdGFydAorfQorCg== --20cf302d4b68d526d504a9897f77--