From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6985 invoked by alias); 29 Aug 2011 15:26:30 -0000 Received: (qmail 6968 invoked by uid 22791); 29 Aug 2011 15:26:27 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gx0-f169.google.com (HELO mail-gx0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Aug 2011 15:26:01 +0000 Received: by gxk23 with SMTP id 23so5182192gxk.0 for ; Mon, 29 Aug 2011 08:26:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.9.101 with SMTP id 65mr26374036yhs.11.1314631560739; Mon, 29 Aug 2011 08:26:00 -0700 (PDT) Received: by 10.236.34.162 with HTTP; Mon, 29 Aug 2011 08:26:00 -0700 (PDT) In-Reply-To: <201108291617.25592.pedro@codesourcery.com> References: <20110823193156.GA30724@host1.jankratochvil.net> <201108291617.25592.pedro@codesourcery.com> Date: Mon, 29 Aug 2011 15:26:00 -0000 Message-ID: Subject: Re: [patch] Fix target-async SIGTTOU stop (PR 12260) From: Matt Rice To: Pedro Alves Cc: gdb-patches@sourceware.org, Jan Kratochvil Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00568.txt.bz2 On Mon, Aug 29, 2011 at 8:17 AM, Pedro Alves wrote: > On Wednesday 24 August 2011 06:24:36, Matt Rice wrote: >> On Tue, Aug 23, 2011 at 12:31 PM, Jan Kratochvil >> wrote: >> > Hi, >> > >> > it is difficult to play with `set target-async on' as it usually SIGTT= OU stops >> > at various places. >> > http://sourceware.org/bugzilla/show_bug.cgi?id=3D12260 >> > >> > $ ./gdb -nx -ex 'set target-async on' -ex start ./gdb >> > [...] >> > Starting program: .../gdb/gdb >> > [1]+ =A0Stopped =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ./gdb -nx -ex 'set tar= get-async on' -ex start ./gdb >> > >> > If it has a regression it IMO only means there is missing >> > target_terminal_inferior call at some other place. >> > >> > No regressions on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu. =A0B= ut I was >> > unable to reproduce the problem under DejaGnu so the regression test m= ay not >> > be meaningful. >> > >> > Not going to check it in without a review. >> > >> >> Not really a review, just thought i'd mention this is also fixed by >> the following patch >> http://sourceware.org/ml/gdb-patches/2011-08/msg00235.html > > I was going to look at Jan's patch, and I'm a bit confused on the state > of things, and the state of Matt's patch --- there was a follow up, which > had a problem. =A0Is the msg00235.html version the final one instead? Yes, I apologize for the confusion. the follow up was intended to be functionally equivalent to msg00235, but getting rid of the weird empty prompt case. Turns out the weird empty prompt case is required, A follow up to 00235 without simply adding comments about the empty prompt case would probably have been pruden= t. >> this also fixes the original report of PR 10720 which seems to be a >> dupe, not sure about the latter reports in 10720. >> the test cases i added do not cover this either. > > By "this" you mean Jan's or yours? either really.