From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3432 invoked by alias); 29 Aug 2011 12:06:59 -0000 Received: (qmail 3422 invoked by uid 22791); 29 Aug 2011 12:06:57 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Aug 2011 12:06:44 +0000 Received: by ywm13 with SMTP id 13so4935681ywm.0 for ; Mon, 29 Aug 2011 05:06:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.187.104 with SMTP id x68mr24368286yhm.130.1314619603268; Mon, 29 Aug 2011 05:06:43 -0700 (PDT) Received: by 10.236.34.162 with HTTP; Mon, 29 Aug 2011 05:06:42 -0700 (PDT) In-Reply-To: <201108291112.53906.pedro@codesourcery.com> References: <4E56C5A0.60802@redhat.com> <201108290920.40589.andre.poenitz@nokia.com> <201108291112.53906.pedro@codesourcery.com> Date: Mon, 29 Aug 2011 12:06:00 -0000 Message-ID: Subject: Re: [RFA] 12843 From: Matt Rice To: Pedro Alves Cc: gdb-patches@sourceware.org, =?ISO-8859-1?B?QW5kcukgUPZuaXR6?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00560.txt.bz2 On Mon, Aug 29, 2011 at 3:12 AM, Pedro Alves wrote: > On Monday 29 August 2011 08:20:40, Andr=E9 P=F6nitz wrote: >> Indeed. Something like >> >> =A025-break-insert -f "\"some thing.cpp\":794" >> >> tends to work. I found it non-obvious in the beginning... >> >> > (I'd like -break-insert to avoid linespecs completely, which would be a >> > big improvement IMO, ... >> >> From an MI client's point of view, passing all location information as >> a single argument is neither wanted nor needed. >> >> =A025-break-insert --file "some thing.cpp" --line 794 >> >> or even require everything to be quoted as in >> >> =A025-break-insert =A0--file "some thing.cpp" --line "794" >> >> would be easier to handle than what's there now. >> >> > ... but of course we still have to worry about compatibility.) >> >> Just using new flags for the parameters should do the trick in this case. > > Yeah, though I expect frontends to support letting the user specify > manually where to insert the breakpoint (say, with a popup dialog > where you write foo.exe:bar or something more complicated, thus we'd > always still need some form of linespec support in MI. there's always interpreter-exec console seems a decent way of handling user input *shrug*... that said, at some point I thought about (instead of the objfile 'break foo.so:func' syntax)... that it might be worthwhile to consider linespec parsing and the evaluation separate, thus linespec decomposes into 'objfile=3Dfoo.so symbol=3Dfunc', that means i suppose any commands (not sure there are any non-python/non-user defined ones, i at least have a python one) linespec commands would need quoting, but `operator=3D' seemed to throw a wrench into that, though keys unknown to linespec could be considered however i suppose. then making linespec accept the decomposed or traditional linespec 25-break-insert =A0"file=3D\"some thing.cpp\" line=3D794" or 25-break-insert -f "\"some thing.cpp\":794" *shrug*