From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92157 invoked by alias); 20 Jul 2017 23:44:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92114 invoked by uid 89); 20 Jul 2017 23:44:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Jul 2017 23:44:28 +0000 Received: by mail-wm0-f44.google.com with SMTP id e131so672329wme.0 for ; Thu, 20 Jul 2017 16:44:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FiAD0REaxgoOZQI+MbvcahiB0TQCK0OZhJKC2U40S5o=; b=ECDbu1tGq0j1137116Vql2383dyU4mtqXdp4pScWE/X6X9vd3m/4gBcGKwD5mLksx+ wc+xiWKYA6LENp3Ff6ubMwJwiK9EEMOaOIMzQnhTOaLkUwUD/fSIiRTDGMc3Xj33RwaX kN3u+vTbwEMFQwFBdDJ3ZVYhs/1kB/2hvDTkFzl3/D7zTebKr86owmOUGPlsCgkRRjaE vePM8ChE0v5kFoR+qBWekkUnC8m21fPhG8K7PcEyXEMCvdy4ZEwxp6Kgdvb8gTronyWz IXOHi0Flr/rS0h00IiUdpaC3t69MzTn3180CdPZnLO3MOSiZuP9s1DQqcS5enfKAFtzb DeQQ== X-Gm-Message-State: AIVw111T+0aZ9zSm3EzrsQzUPZj9DqlQyEDNm+qEDfz+ADWPtV3G5Ty6 +IfN4wP1ek8PuJ9jLx4UWogYxcE6gQ== X-Received: by 10.80.169.100 with SMTP id m33mr4095896edc.31.1500594266139; Thu, 20 Jul 2017 16:44:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.175.228 with HTTP; Thu, 20 Jul 2017 16:44:25 -0700 (PDT) In-Reply-To: References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-24-git-send-email-palves@redhat.com> <596D4238.7090905@redhat.com> <5ce823d3-1064-f14b-2e79-2ff9efdb28a0@redhat.com> From: Matt Rice Date: Thu, 20 Jul 2017 23:44:00 -0000 Message-ID: Subject: Re: Get rid of "set language local"? (was: Re: [PATCH 23/40] Make language_def O(1)) To: Pedro Alves Cc: Keith Seitz , "gdb-patches@sourceware.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00312.txt.bz2 On Thu, Jul 20, 2017 at 11:11 AM, Pedro Alves wrote: > On 07/20/2017 06:40 PM, Pedro Alves wrote: >> On 07/18/2017 12:03 AM, Keith Seitz wrote: >>> On 06/02/2017 05:22 AM, Pedro Alves wrote: >>> >>>> Note that "local_language_defn" is gone along the way. AFAICT, it's >>>> just a copy of "auto", so the new code simply maps one to the other. >>>> One fewer place to update when we need to change the language >>>> vector... >>> >>> I've searched the manual, and the "local" language is mentioned only in= two places, once in the description of "set language" (where it explains t= hat "local" and "auto" are the same) and once when we describe -data-evalua= te-expression's --language flag. >>> >>> Honestly, is there any reason to keep it at all given it is a synonym o= f auto? [I realize that it doesn't cost much to maintain with this patch.] = I'm not asking for any changes in this regard, just throwing the possibilit= y out there. TBH, I didn't even know "local" existed. >> >> I didn't know about "local" until I stumbled on it working on this >> series, either. :-) >> >> I'll send a follow up reply with a different subject >> to see if anyone else has comments on that. > > Does anyone here ever use "set language local" instead > of "set language auto"? Do we need to keep "set language local" ? > Seems odd to have two ways to do the exact same thing. Never knew about "local", and if it is a straight copy of auto don't much see the point of keeping it. if local came with some other flag, that says "when the language inference fails, fall back to the local language instead of minimal" however that would probably be better achieved by adding python/guile hooks called by the language inference mechanism for adding e.g. file extensions, or even per-symbol heuristics if that would be possible. my $0.02 from someone who has debugged some stuff where failure to infer language leads to a pretty terrible experience.