Re: [patch] bfin: swapped args in bfin_extract_return_value?

Yao Qi
2011-07-20T15:35:00Z

On 07/20/2011 09:59 PM, Tom Tromey wrote:
> I think this change is good, but I don't understand why this function
> even calls store_unsigned_integer. I thought
> regcache_cooked_read_unsigned did that for you.

regcache_cooked_read_unsigned and store_unsigned_integer can be replaced
by regcache_cooked_read, IIUC. However, in the last iteration of loop,
the size of data might not be 4, so we may have to use
regcache_cooked_read_part and consider different data layout related to
endianess. Looks like current approach doesn't have to worry about this
problem.

--
Yao (é½å°§)