Re: [patch] bfin: swapped args in bfin_extract_return_value?

Mike Frysinger
2011-07-20T16:03:45Z

On Tue, Jul 19, 2011 at 22:12, Matt Rice wrote:
> I don't really know this code, so this patch might be wrong,
> and don't have a setup to test it.
>
> but from the types, and the variable names, it smells of arguments
> that have been swapped.

the Blackfin gdb port is currently being maintained against gdb-6.6
which didnt have an endian argument. when forward porting to
pre-gdb-7.3, the func now took an endian arg, so one was just thrown
in. when the func was updated in mainline gdb, rather than add the
new arg to the end, it was inserted, so i guess the update review
didnt go as well as hopped.

in my local version (which contains FDPIC support), it seems like all
calls to store_unsigned_integer() in bfin-tdep.c have the last two
args swapped. so i imagine it was an upgrade thinko.
-mike