Re: [patch] bfin: swapped args in bfin_extract_return_value?

Mike Frysinger
2011-07-20T16:06:19Z

On Wed, Jul 20, 2011 at 09:59, Tom Tromey wrote:
>>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:
>
> Matt> 2011-07-11  Matt Rice  <ratmice@gmail.com>
> Matt>         * bfin-tdep.c (bfin_extract_return_value): Fix swapped
> Matt>         arguments to store_unsigned_integer.
>
> I think this change is good, but I don't understand why this function
> even calls store_unsigned_integer.  I thought
> regcache_cooked_read_unsigned did that for you.

most likely because regcache_cooked_read() doesnt exist in gdb-6.6
(which is where the Blackfin port originated). when moving from
something like 6.6 to 7.3, it's nigh impossible to pick out all the
idioms that have been obsoleted by new helper functions unless you're
very familiar with the gdb code base. which i am not :).

i can test your proposal and post a follow up patch if it pans out.
-mike