From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12543 invoked by alias); 20 Jul 2011 02:12:28 -0000 Received: (qmail 12535 invoked by uid 22791); 20 Jul 2011 02:12:27 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 02:12:10 +0000 Received: by ywm39 with SMTP id 39so2331357ywm.0 for ; Tue, 19 Jul 2011 19:12:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.200.131 with SMTP id z3mr10603923yhn.322.1311127929438; Tue, 19 Jul 2011 19:12:09 -0700 (PDT) Received: by 10.236.109.131 with HTTP; Tue, 19 Jul 2011 19:12:09 -0700 (PDT) Date: Wed, 20 Jul 2011 06:10:00 -0000 Message-ID: Subject: [patch] bfin: swapped args in bfin_extract_return_value? From: Matt Rice To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf305b09bc7d415c04a876c237 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00510.txt.bz2 --20cf305b09bc7d415c04a876c237 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 350 I don't really know this code, so this patch might be wrong, and don't have a setup to test it. but from the types, and the variable names, it smells of arguments that have been swapped. Thanks. 2011-07-11 Matt Rice * bfin-tdep.c (bfin_extract_return_value): Fix swapped arguments to store_unsigned_integer. --20cf305b09bc7d415c04a876c237 Content-Type: application/octet-stream; name="foo.diff" Content-Disposition: attachment; filename="foo.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gqbnlj2g0 Content-length: 643 ZGlmZiAtLWdpdCBhL2dkYi9iZmluLXRkZXAuYyBiL2dkYi9iZmluLXRkZXAu YwppbmRleCA4MzIyYWY1Li41NTIyYzViIDEwMDY0NAotLS0gYS9nZGIvYmZp bi10ZGVwLmMKKysrIGIvZ2RiL2JmaW4tdGRlcC5jCkBAIC02MjMsNyArNjIz LDcgQEAgYmZpbl9leHRyYWN0X3JldHVybl92YWx1ZSAoc3RydWN0IHR5cGUg KnR5cGUsCiAgIHdoaWxlIChsZW4gPiAwKQogICAgIHsKICAgICAgIHJlZ2Nh Y2hlX2Nvb2tlZF9yZWFkX3Vuc2lnbmVkIChyZWdzLCByZWdubysrLCAmdG1w KTsKLSAgICAgIHN0b3JlX3Vuc2lnbmVkX2ludGVnZXIgKHZhbGJ1ZiwgKGxl biA+IDQgPyA0IDogbGVuKSwgdG1wLCBieXRlX29yZGVyKTsKKyAgICAgIHN0 b3JlX3Vuc2lnbmVkX2ludGVnZXIgKHZhbGJ1ZiwgKGxlbiA+IDQgPyA0IDog bGVuKSwgYnl0ZV9vcmRlciwgdG1wKTsKICAgICAgIGxlbiAtPSA0OwogICAg ICAgdmFsYnVmICs9IDQ7CiAgICAgfQo= --20cf305b09bc7d415c04a876c237--