From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30020 invoked by alias); 5 Nov 2011 17:36:09 -0000 Received: (qmail 29885 invoked by uid 22791); 5 Nov 2011 17:36:09 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Nov 2011 17:35:55 +0000 Received: by faaf16 with SMTP id f16so4787445faa.0 for ; Sat, 05 Nov 2011 10:35:54 -0700 (PDT) Received: by 10.223.75.15 with SMTP id w15mr33438233faj.9.1320514554189; Sat, 05 Nov 2011 10:35:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.121.200 with HTTP; Sat, 5 Nov 2011 10:35:33 -0700 (PDT) In-Reply-To: References: <998639.46560.qm@web112516.mail.gq1.yahoo.com> <321260.58442.qm@web112504.mail.gq1.yahoo.com> <1316327455.23344.YahooMailNeo@web112509.mail.gq1.yahoo.com> <1316404058.27177.YahooMailNeo@web112502.mail.gq1.yahoo.com> <1318650316.91503.YahooMailNeo@web112508.mail.gq1.yahoo.com> From: =?UTF-8?B?UGV0ciBIbHV6w61u?= Date: Sat, 05 Nov 2011 17:36:00 -0000 Message-ID: Subject: Re: [PATCH] arm reversible : To: Tom Tromey , chandra krishnappa Cc: oza Pawandeep , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00132.txt.bz2 On 3 November 2011 18:40, Tom Tromey wrote: >>>>>> "Oza" =3D=3D oza Pawandeep writes: > I read the whole thread and I think at this point there are still some > unaddressed comments. =C2=A0If I am incorrect, could you point me to the = most > up-to-date version of the patch? =C2=A0Then I will review it. =C2=A0Other= wise I > will wait for your next mail. =C2=A0Thanks. The most recent version of Oza's patch is at [1], my review is at [2]. Oza fixed all issues. (I do not check whitespace, though.) Oza removed the assertions as you asked, however I believe they should have stayed (as I explained in mail few minutes ago and in [3]). However Oza improved ARM extension space insn support which introduced some bugs - I think, I have no feedback from Oza whether I misunderstood the code. [1] http://sourceware.org/ml/gdb-patches/2011-10/msg00613.html [2] http://sourceware.org/ml/gdb-patches/2011-10/msg00617.html [3] http://sourceware.org/ml/gdb-patches/2011-10/msg00449.html --=20 Petr Hluzin