Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eldar Abusalimov via Gdb-patches <gdb-patches@sourceware.org>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org, Konstantin Kharlamov <hi-angel@yandex.ru>
Subject: Re: [PATCH v2 00/16] Interrupting programs that block/ignore SIGINT
Date: Tue, 29 Jun 2021 04:15:50 +0300	[thread overview]
Message-ID: <CAC934sT4o5rVnL3Se+P3P-7P-vY-o0t5-qRkjF2EfScujL-ZCQ@mail.gmail.com> (raw)
In-Reply-To: <bcfdd950-14fd-6cb4-cf30-77276a14b9f6@palves.net>

Hi Pedro,

Let me chime in to say that the issue addressed is indeed relevant, in
case you need any reassurance. :-)  This being addressed is great news!

A related problem[1] was reported in the CLion IDE issue tracker, and
the discussion also mentions the Kernel PR linked by Konstantin.  Since
CLion signals the inferior process directly, we ended up changing the
signal sent by the IDE from SIGINT to SIGSTOP so that there's no way the
inferior program can intercept the signal.  Apparently, this is also how
LLDB handles that as well.

However, that didn't cover[2] the target-async case, that is, when the
signal is still being sent by GDB (using the "interrupt" command), and
remote targets, where it's the gdbserver who ultimately supervises the
inferior process, not GDB.

From the patchset, I gather that the target-async case has now been
fixed as well, but what about remote targets?  Do you think it makes
sense to also change gdbserver to use SIGSTOP instead of SIGINT?  As far
as I understand, unlike for a locally spawned process, this shouldn't
require waltzing with pseudo-terminals for the inferior on the remote
gdbserver side.  At the same time consistency w.r.t. signal handling on
suspending the target would definitely be a nice thing to have
eventually.

  [1]: https://youtrack.jetbrains.com/issue/CPP-14435#focus=Comments-27-3105589.0-0
  [2]: https://youtrack.jetbrains.com/issue/CPP-21975#focus=Comments-27-4635249.0-0


--
Regards,
Eldar

      reply	other threads:[~2021-06-29  1:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 21:23 Pedro Alves
2021-06-14 21:23 ` [PATCH v2 01/16] Test interrupting programs that block SIGINT [gdb/9425, gdb/14559] Pedro Alves
2021-06-14 21:23 ` [PATCH v2 02/16] prefork_hook: Remove 'args' parameter Pedro Alves
2021-06-14 21:23 ` [PATCH v2 03/16] Make gdb.base/long-inferior-output.exp fail fast Pedro Alves
2021-06-14 21:23 ` [PATCH v2 04/16] Fix gdb.multi/multi-term-settings.exp race Pedro Alves
2021-06-14 21:23 ` [PATCH v2 05/16] Don't check parent pid in gdb.threads/{ia64-sigill, siginfo-threads, watchthreads-reorder}.c Pedro Alves
2021-06-14 21:24 ` [PATCH v2 06/16] Special-case "set inferior-tty /dev/tty" Pedro Alves
2021-06-14 21:24 ` [PATCH v2 07/16] Make inferior/GDB share terminal in tests expecting output after detach Pedro Alves
2021-06-14 21:24 ` [PATCH v2 08/16] Make inferior/GDB share terminal in tests that exercise GDB/inferior reading same input Pedro Alves
2021-06-14 21:24 ` [PATCH v2 09/16] gdb.mi/mi-logging.exp, don't send input to GDB while the inferior is running Pedro Alves
2021-06-14 21:24 ` [PATCH v2 10/16] target_terminal::ours_for_output before printing signal received Pedro Alves
2021-06-14 21:24 ` [PATCH v2 11/16] Move scoped_ignore_sigttou to gdbsupport/ Pedro Alves
2021-06-17 21:49   ` Pedro Alves
2021-06-14 21:24 ` [PATCH v2 12/16] Always put inferiors in their own terminal/session [gdb/9425, gdb/14559] Pedro Alves
2021-06-14 21:24 ` [PATCH v2 13/16] exists_non_stop_target: Avoid flushing frames Pedro Alves
2021-06-14 21:24 ` [PATCH v2 14/16] convert previous_inferior_ptid to strong reference to thread_info Pedro Alves
2021-06-14 21:24 ` [PATCH v2 15/16] GNU/Linux: Interrupt/Ctrl-C with SIGSTOP instead of SIGINT [PR gdb/9425, PR gdb/14559] Pedro Alves
2021-07-08 23:05   ` Maciej W. Rozycki
2021-07-13 15:26     ` Pedro Alves
2021-06-14 21:24 ` [PATCH v2 16/16] Document pseudo-terminal and interrupting changes Pedro Alves
2021-06-15 12:56   ` Eli Zaretskii via Gdb-patches
2021-06-16  9:31     ` Pedro Alves
2021-06-16 12:29       ` Eli Zaretskii via Gdb-patches
2021-06-16 10:15     ` Pedro Alves
2021-06-16 12:15       ` Eli Zaretskii via Gdb-patches
2021-06-16 12:26         ` Pedro Alves
2021-06-16 13:05           ` Eli Zaretskii via Gdb-patches
2021-06-15 12:34 ` [PATCH v2 00/16] Interrupting programs that block/ignore SIGINT Eli Zaretskii via Gdb-patches
2021-06-16 11:27   ` Pedro Alves
2021-06-16 12:45     ` Eli Zaretskii via Gdb-patches
2021-06-18 10:12 ` Andrew Burgess
2021-06-24 18:12 ` Konstantin Kharlamov via Gdb-patches
2021-06-24 18:55   ` Pedro Alves
2021-06-29  1:15     ` Eldar Abusalimov via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC934sT4o5rVnL3Se+P3P-7P-vY-o0t5-qRkjF2EfScujL-ZCQ@mail.gmail.com \
    --to=gdb-patches@sourceware.org \
    --cc=eldar.abusalimov@jetbrains.com \
    --cc=hi-angel@yandex.ru \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox