From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by sourceware.org (Postfix) with ESMTPS id CEA9D386101C for ; Wed, 1 Jul 2020 00:10:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CEA9D386101C Received: by mail-io1-xd43.google.com with SMTP id y2so23066039ioy.3 for ; Tue, 30 Jun 2020 17:10:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wc5k7RpehC+uOVEySHtP2JwPkZQiz2kiOSrAI9+OZ7w=; b=NBZ4DkdUoTFqU1bKbhMQ45sArBeJl2iTEQIEzl2CEkWOl7wRxKv1uYX6AAzMvMIZh0 I5dZLWrDztSqIhGH8k/L8AgPmTV0muXgxn1GNxD3ltHr0N00FGBazs5RaQdsmErx0Ip4 Sfngsz54IF8UViCvm3GKDCZ/JKaj5u0wd2avcTtUg6fAJJ0mEfi3YB9CSfcZPjdhdhzP yuKzgIyt0ip2IiqEr/B88N8gVqbwMRmjFn5ZZi71pBZ9Vj4KWG5aE/7VUmShR455Nt6u 3KL7iyTbISa2SJ9HKJDb2lkU7WYZiW6ZID62ioRS8LHFu35NNGNfKRBfnwk7sh0t9RUV izAA== X-Gm-Message-State: AOAM532wtpXbPlOwnZKsw4oNtBA76knix389m7sOk6nAqSLbd5Ts/gb7 aTuHnV6nc8pdPehmf61yAPZwEVB0eK8BP+JufBdZpUna X-Google-Smtp-Source: ABdhPJybUc17CoP9Tao1HKwaJLQt/lb9J8qvmNlweALN1YMJfzQQm3wty5gMuXBLf5s4IrQpruLgtMxXvpYdOgC+bpo= X-Received: by 2002:a05:6638:1515:: with SMTP id b21mr13952474jat.84.1593562205033; Tue, 30 Jun 2020 17:10:05 -0700 (PDT) MIME-Version: 1.0 References: <87lfl634rs.fsf@tromey.com> <87h7vsqk5h.fsf@tromey.com> <87h7v815n7.fsf@tromey.com> In-Reply-To: From: Caroline Tice Date: Tue, 30 Jun 2020 17:09:53 -0700 Message-ID: Subject: Re: [PATCH] Fix issues with reading rnglists, especially from dwo files, for DWARF v5 To: Tom Tromey Cc: Caroline Tice via Gdb-patches , Eric Christopher Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-24.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 00:10:07 -0000 Ping? -- Caroline cmtice@google.com On Tue, Jun 23, 2020 at 12:04 PM Caroline Tice wrote: > > > > On Thu, Jun 18, 2020 at 1:27 PM Tom Tromey wrote: >> >> >>>>> "Caroline" == Caroline Tice via Gdb-patches writes: >> >> Thanks for the patch. >> >> Caroline> + /* if (dwarf2_attr_no_follow (comp_unit_die, DW_AT_ranges)) */ >> >> No need for commented-out code. >> > Done. > >> >> Caroline> + if (comp_unit_die->attr (DW_AT_ranges) != nullptr) >> Caroline> + { >> Caroline> + cu->cu_ranges_from_skeleton = true; >> Caroline> + } >> >> You can remove the braces here. Normally in gdb there are only braces >> if there are multiple statements (or a comment). >> > Done. > >> >> Caroline> + if (tag == DW_TAG_compile_unit && >> Caroline> + cu->cu_ranges_from_skeleton) >> >> The GNU / gdb style is to break before operators, not after (including >> assignment FWIW). There are several occurrences of this, I didn't mark >> them all. >> > Done. > >> >> Caroline> + if (section == nullptr) >> Caroline> + error(_("Cannot find .debug_rnglists section [in module %s]"), >> >> Space before "(". >> > > Done. >> >> Caroline> diff --git a/testsuite/gdb.dwarf2/dw5-rnglist-test.cc b/testsuite/gdb.dwarf2/dw5-rnglist-test.cc >> Caroline> new file mode 100644 >> Caroline> index 0000000..4d650e1279 >> Caroline> --- /dev/null >> Caroline> +++ b/testsuite/gdb.dwarf2/dw5-rnglist-test.cc >> Caroline> @@ -0,0 +1,71 @@ >> Caroline> +#include >> >> Tests also need the copyright header. >> > Done. > > >> >> Caroline> diff --git a/testsuite/gdb.dwarf2/dw5-rnglist-test.exp b/testsuite/gdb.dwarf2/dw5-rnglist-test.exp >> Caroline> new file mode 100644 >> Caroline> index 0000000..b5c6c3bfe3 >> Caroline> --- /dev/null >> Caroline> +++ b/testsuite/gdb.dwarf2/dw5-rnglist-test.exp >> Caroline> @@ -0,0 +1,40 @@ >> Caroline> +# Copyright 2011-2020 Free Software Foundation, Inc. >> >> This should probably just be 2020. >> > > Done. >> >> Tom > > > I believe I have addressed all of your comments. The updated patch is attached. Please let me know if this is ok now. Thanks! > > -- Caroline Tice > cmtice@google.com >