From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14240 invoked by alias); 25 Oct 2013 07:41:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14168 invoked by uid 89); 25 Oct 2013 07:41:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vb0-f44.google.com Received: from mail-vb0-f44.google.com (HELO mail-vb0-f44.google.com) (209.85.212.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 25 Oct 2013 07:41:31 +0000 Received: by mail-vb0-f44.google.com with SMTP id 11so2137678vbe.17 for ; Fri, 25 Oct 2013 00:41:29 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.52.106.201 with SMTP id gw9mr348329vdb.49.1382686889014; Fri, 25 Oct 2013 00:41:29 -0700 (PDT) Received: by 10.220.245.196 with HTTP; Fri, 25 Oct 2013 00:41:28 -0700 (PDT) In-Reply-To: <874n869zs9.fsf@fleche.redhat.com> References: <874n869zs9.fsf@fleche.redhat.com> Date: Fri, 25 Oct 2013 07:41:00 -0000 Message-ID: Subject: Re: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table From: hex To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=bcaec5485a98db1cf504e98be049 X-SW-Source: 2013-10/txt/msg00784.txt.bz2 --bcaec5485a98db1cf504e98be049 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 907 2013/10/25 Tom Tromey : >>>>>> ">" == hex writes: > >>> // Then compile it with `gcc -g -c test.c`(For the lastest GCC, we >>> need use 'gcc -g -O1 -c test.' to get the following DIE) >>> We could see the DIE of 'var' is as following: >>> <1><25>: Abbrev Number: 2 (DW_TAG_variable) >>> <26> DW_AT_name : var >>> <2a> DW_AT_decl_file : 1 >>> <2b> DW_AT_decl_line : 1 >>> <2c> DW_AT_type : <0x31> >>> <30> DW_AT_const_value : 3 > >>> Latest GDB will not add it to partial symbol table because its symbol >>> satisfies 'pdi->d.locdesc == NULL'. I think we need add it to partial >>> symbol table. > > This patch seems reasonable to me, but I think it needs a test case. > This should be easy to write using the DWARF assembler in the test suite. > > Tom Thank you for the review. I have attached the test case. Jun --bcaec5485a98db1cf504e98be049 Content-Type: text/plain; charset=US-ASCII; name="const-var.S" Content-Disposition: attachment; filename="const-var.S" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hn741vmt1 Content-length: 3677 LyoKICAgQ29weXJpZ2h0IDIwMDktMjAxMyBGcmVlIFNvZnR3YXJlIEZvdW5k YXRpb24sIEluYy4KCiAgIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJl OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CiAgIGl0 IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp Y2Vuc2UgYXMgcHVibGlzaGVkIGJ5CiAgIHRoZSBGcmVlIFNvZnR3YXJlIEZv dW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9y CiAgIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCgogICBU aGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBp dCB3aWxsIGJlIHVzZWZ1bCwKICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZ OyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKICAgTUVS Q0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQ T1NFLiAgU2VlIHRoZQogICBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBm b3IgbW9yZSBkZXRhaWxzLgoKICAgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVk IGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKICAg YWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDov L3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwoKLyogVGhpcyB3YXMgY29t cGlsZWQgZnJvbSBhIHRyaXZpYWwgcHJvZ3JhbSBqdXN0IHRvIHRlc3Qgd2hl dGhlciBHREIKICAgd2lsbCBhZGQgY29uc3QgdmFyaWFibGUgdG8gcGFydGlh bCBzeW1ib2wuCgogIHN0YXRpYyBjb25zdCBpbnQgY29uc3RfdmFyID0gNjsK CiAgaW50IG1haW4oKXsKICAgICAgICAgIHJldHVybiAwOwogIH0KCiAgVGhl biBpdCB3YXMgY29tcGlsZWQgd2l0aDoKCQoJZ2NjIC1nIC1PMQogIAogIFdl IGNvdWxkIHNlZSB0aGUgRElFIG9mICdjb25zdF92YXInIGlzIGFzIGZvbGxv d2luZzoKICA8MT48MjU+OiBBYmJyZXYgTnVtYmVyOiAyIChEV19UQUdfdmFy aWFibGUpCiAgICAgPDI2PiAgIERXX0FUX25hbWUgICAgICAgIDogdmFyCiAg ICAgPDJhPiAgIERXX0FUX2RlY2xfZmlsZSAgIDogMQogICAgIDwyYj4gICBE V19BVF9kZWNsX2xpbmUgICA6IDEKICAgICA8MmM+ICAgRFdfQVRfdHlwZSAg ICAgICAgOiA8MHgzMT4KICAgICA8MzA+ICAgRFdfQVRfY29uc3RfdmFsdWUg OiAzCgogIFdlIG5lZWQgYWRkIGl0IHRvIHBhcnRpYWwgc3ltYm9sIHRhYmxl LgoKKi8KCgkuZmlsZQkiY29uc3QtdmFyLmMiCgkudGV4dAouTHRleHQwOgou TGV0ZXh0MDoKCS5maWxlIDEgIi90bXAvY29uc3QtdmFyLmMiCgkuc2VjdGlv bgkuZGVidWdfaW5mbywiIixAcHJvZ2JpdHMKLkxkZWJ1Z19pbmZvMDoKCS5s b25nCTB4MzYKCS52YWx1ZQkweDIKCS5sb25nCS5MZGVidWdfYWJicmV2MAoJ LmJ5dGUJMHg0CgkudWxlYjEyOCAweDEKCS5sb25nCS5MQVNGMAoJLmJ5dGUJ MHgxCgkubG9uZwkuTEFTRjEKCS5sb25nCS5MdGV4dDAKCS5sb25nCS5MZXRl eHQwCgkubG9uZwkuTGRlYnVnX2xpbmUwCgkudWxlYjEyOCAweDIKCS5sb25n CS5MQVNGMgoJLmJ5dGUJMHgxCgkuYnl0ZQkweDEKCS5sb25nCTB4MmQKCS5i eXRlCTB4NgoJLnVsZWIxMjggMHgzCgkubG9uZwkweDMyCgkudWxlYjEyOCAw eDQKCS5ieXRlCTB4NAoJLmJ5dGUJMHg1Cgkuc3RyaW5nCSJpbnQiCgkuYnl0 ZQkwCgkuc2VjdGlvbgkuZGVidWdfYWJicmV2LCIiLEBwcm9nYml0cwouTGRl YnVnX2FiYnJldjA6CgkudWxlYjEyOCAweDEKCS51bGViMTI4IDB4MTEKCS5i eXRlCTB4MQoJLnVsZWIxMjggMHgyNQoJLnVsZWIxMjggMHhlCgkudWxlYjEy OCAweDEzCgkudWxlYjEyOCAweGIKCS51bGViMTI4IDB4MwoJLnVsZWIxMjgg MHhlCgkudWxlYjEyOCAweDExCgkudWxlYjEyOCAweDEKCS51bGViMTI4IDB4 MTIKCS51bGViMTI4IDB4MQoJLnVsZWIxMjggMHgxMAoJLnVsZWIxMjggMHg2 CgkuYnl0ZQkwCgkuYnl0ZQkwCgkudWxlYjEyOCAweDIKCS51bGViMTI4IDB4 MzQKCS5ieXRlCTAKCS51bGViMTI4IDB4MwoJLnVsZWIxMjggMHhlCgkudWxl YjEyOCAweDNhCgkudWxlYjEyOCAweGIKCS51bGViMTI4IDB4M2IKCS51bGVi MTI4IDB4YgoJLnVsZWIxMjggMHg0OQoJLnVsZWIxMjggMHgxMwoJLnVsZWIx MjggMHgxYwoJLnVsZWIxMjggMHhiCgkuYnl0ZQkwCgkuYnl0ZQkwCgkudWxl YjEyOCAweDMKCS51bGViMTI4IDB4MjYKCS5ieXRlCTAKCS51bGViMTI4IDB4 NDkKCS51bGViMTI4IDB4MTMKCS5ieXRlCTAKCS5ieXRlCTAKCS51bGViMTI4 IDB4NAoJLnVsZWIxMjggMHgyNAoJLmJ5dGUJMAoJLnVsZWIxMjggMHhiCgku dWxlYjEyOCAweGIKCS51bGViMTI4IDB4M2UKCS51bGViMTI4IDB4YgoJLnVs ZWIxMjggMHgzCgkudWxlYjEyOCAweDgKCS5ieXRlCTAKCS5ieXRlCTAKCS5i eXRlCTAKCS5zZWN0aW9uCS5kZWJ1Z19saW5lLCIiLEBwcm9nYml0cwouTGRl YnVnX2xpbmUwOgoJLnNlY3Rpb24JLmRlYnVnX3N0ciwiTVMiLEBwcm9nYml0 cywxCi5MQVNGMDoKCS5zdHJpbmcJIkdOVSBDIDQuNi4zIgouTEFTRjE6Cgku c3RyaW5nCSIvdG1wL2NvbnN0LXZhci5jIgouTEFTRjI6Cgkuc3RyaW5nCSJj b25zdF92YXIiCgkuaWRlbnQJIkdDQzogKFVidW50dS9MaW5hcm8gNC42LjMt MXVidW50dTUpIDQuNi4zIgoJLnNlY3Rpb24JLm5vdGUuR05VLXN0YWNrLCIi LEBwcm9nYml0cwo= --bcaec5485a98db1cf504e98be049 Content-Type: application/octet-stream; name="const-var.exp" Content-Disposition: attachment; filename="const-var.exp" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hn741vmj0 Content-length: 1757 IyBDb3B5cmlnaHQgMjAwOS0yMDEzIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv biwgSW5jLgoKIyBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91 IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQojIGl0IHVuZGVy IHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2Ug YXMgcHVibGlzaGVkIGJ5CiMgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv bjsgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3IKIyAoYXQg eW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgojCiMgVGhpcyBwcm9n cmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBi ZSB1c2VmdWwsCiMgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0 IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKIyBNRVJDSEFOVEFCSUxJ VFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUg dGhlCiMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0 YWlscy4KIwojIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCiMgYWxvbmcgd2l0aCB0 aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3Jn L2xpY2Vuc2VzLz4uCmxvYWRfbGliIGR3YXJmLmV4cAoKIyBUZXN0IERXX09Q X3N0YWNrX3ZhbHVlIGFuZCBEV19PUF9pbXBsaWNpdF92YWx1ZS4KCiMgVGhp cyB0ZXN0IGNhbiBvbmx5IGJlIHJ1biBvbiB0YXJnZXRzIHdoaWNoIHN1cHBv cnQgRFdBUkYtMiBhbmQgdXNlIGdhcy4KaWYgeyFbZHdhcmYyX3N1cHBvcnRd fSB7CiAgICByZXR1cm4gMCAgCn0KIyBUaGlzIHRlc3QgY2FuIG9ubHkgYmUg cnVuIG9uIHg4NiB0YXJnZXRzLgppZiB7IVtpc194ODZfbGlrZV90YXJnZXRd fSB7CiAgICByZXR1cm4gMCAgCn0KCnN0YW5kYXJkX3Rlc3RmaWxlIC5TCgpp ZiB7W3ByZXBhcmVfZm9yX3Rlc3RpbmcgJHRlc3RmaWxlLmV4cCAkdGVzdGZp bGUgXAogICAgW2xpc3QgJHNyY2ZpbGUgbWFpbi5jXSBbbGlzdCB7YWRkaXRp b25hbF9mbGFncz0tTzF9XV19IHsKICAgIHJldHVybiAtMQp9CgppZiAhW3J1 bnRvX21haW5dIHsKICAgIHJldHVybiAtMQp9CgojIFByaW50IHN0YXRpYyBj b25zdCB2YXJpYWJsZSwgdGVzdCB3aGV0aGVyIGl0IGhhcyBiZWVuIGFkZGVk IHRvIHBhcnRpYWwKIyBzeW1ib2wgdGFibGUuCmdkYl90ZXN0ICJwIGNvbnN0 X3ZhciIgIiA9IDYiICJwcmludCBjb25zdCB2YXJpYWJsZSIK --bcaec5485a98db1cf504e98be049--