From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22699 invoked by alias); 24 Jan 2014 06:19:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22689 invoked by uid 89); 24 Jan 2014 06:19:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f41.google.com Received: from mail-oa0-f41.google.com (HELO mail-oa0-f41.google.com) (209.85.219.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 24 Jan 2014 06:19:25 +0000 Received: by mail-oa0-f41.google.com with SMTP id j17so3363412oag.0 for ; Thu, 23 Jan 2014 22:19:24 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.182.74.137 with SMTP id t9mr43723obv.79.1390544364239; Thu, 23 Jan 2014 22:19:24 -0800 (PST) Received: by 10.60.136.129 with HTTP; Thu, 23 Jan 2014 22:19:24 -0800 (PST) Date: Fri, 24 Jan 2014 06:19:00 -0000 Message-ID: Subject: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table From: Jun Gong To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001a11c1fd62e0148a04f0b156d1 X-SW-Source: 2014-01/txt/msg00913.txt.bz2 --001a11c1fd62e0148a04f0b156d1 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1645 This patch intends to add symbol whose field 'has_type' has been set to partial symbol table. The patch and corresponding test case have been discussed and reviewed before at https://sourceware.org/ml/gdb-patches/2013-10/msg00747.html and https://sourceware.org/ml/gdb-patches/2013-11/msg00003.html. However it has not been committed because Tom Tromey is very busy and could not help commit it now. I have received copyright assignment. Could you help review and commit the patch? Thank you! The following are the summary of the patch, and the attachment const-var.exp is test case. 1. Change for gdb/ChangeLog 2014-01-24 Jun Gong * dwarf2read.c(add_partial_symbol): Add symbol whose field 'has_type' has been set to partial symbol table. 2. Diff for dwarf2read.c diff -up gdb-7.7.50.20140124.orig/gdb/dwarf2read.c gdb-7.7.50.20140124/gdb/dwarf2read.c --- gdb-7.7.50.20140124.orig/gdb/dwarf2read.c 2014-01-24 13:04:04.169111566 +0800 +++ gdb-7.7.50.20140124/gdb/dwarf2read.c 2014-01-24 13:26:48.445122774 +0800 @@ -6769,8 +6769,9 @@ add_partial_symbol (struct partial_die_i } else { - /* Static Variable. Skip symbols without location descriptors. */ - if (pdi->d.locdesc == NULL) + /* Static Variable. Skip symbols without location descriptors. or + has_type not set. */ + if (pdi->d.locdesc == NULL && pdi->has_type == 0) { xfree (built_actual_name); return; 3. Change for gdb/testsuite/Changelog 2014-01-24 Jun Gong * gdb.dwarf2/const-var.exp: New file. 4. Test case has been attached as const-var.exp. Best Regards, Jun --001a11c1fd62e0148a04f0b156d1 Content-Type: application/octet-stream; name="const-var.exp" Content-Disposition: attachment; filename="const-var.exp" Content-Transfer-Encoding: base64 X-Attachment-Id: 11ccb3b4c28f3926_0.1 Content-length: 2371 IyBDb3B5cmlnaHQgMjAxMyBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIElu Yy4KCiMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKIyBpdCB1bmRlciB0aGUg dGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1 Ymxpc2hlZCBieQojIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVp dGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCiMgKGF0IHlvdXIg b3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KIwojIFRoaXMgcHJvZ3JhbSBp cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsLAojIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVu IHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCiMgTUVSQ0hBTlRBQklMSVRZIG9y IEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQoj IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMu CiMKIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBH TlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQojIGFsb25nIHdpdGggdGhpcyBw cm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LgoKbG9hZF9saWIgZHdhcmYuZXhwCgojIFRoaXMgdGVzdCBjYW4g b25seSBiZSBydW4gb24gdGFyZ2V0cyB3aGljaCBzdXBwb3J0IERXQVJGLTIg YW5kIHVzZSBnYXMuCmlmIHshW2R3YXJmMl9zdXBwb3J0XX0gewogICAgcmV0 dXJuIDAKfQoKc3RhbmRhcmRfdGVzdGZpbGUgbWFpbi5jIC5TCgojIENyZWF0 ZSB0aGUgRFdBUkYuCnNldCBhc21fZmlsZSBbc3RhbmRhcmRfb3V0cHV0X2Zp bGUgJHNyY2ZpbGUyXQpEd2FyZjo6YXNzZW1ibGUgJGFzbV9maWxlIHsKICAg IGRlY2xhcmVfbGFiZWxzIGludF9sYWJlbAoKICAgIGN1IHt9IHsKCWNvbXBp bGVfdW5pdCB7e2xhbmd1YWdlIEBEV19MQU5HX0N9fSB7CgkgICAgaW50X2xh YmVsOiBiYXNlX3R5cGUgewoJCXtuYW1lIGludH0KCQl7Ynl0ZV9zaXplIDQg c2RhdGF9CgkJe2VuY29kaW5nIEBEV19BVEVfc2lnbmVkfQoJICAgIH0KCgkg ICAgRFdfVEFHX3ZhcmlhYmxlIHsKCQl7bmFtZSBjb25zdF92YXJ9CgkJe3R5 cGUgOiRpbnRfbGFiZWx9CgkJe2NvbnN0X3ZhbHVlIDYgZGF0YTF9CgkgICAg fQoJfQogICAgfQp9CgppZiAgeyBbZ2RiX2NvbXBpbGUgJHtzcmNkaXJ9LyR7 c3ViZGlyfS8ke3NyY2ZpbGV9ICR7YmluZmlsZX0xLm8gXAoJICAgb2JqZWN0 IHtub2RlYnVnfV0gIT0gIiIgfSB7CiAgICByZXR1cm4gLTEKfQoKaWYgIHsg W2dkYl9jb21waWxlICRhc21fZmlsZSAke2JpbmZpbGV9Mi5vIG9iamVjdCB7 bm9kZWJ1Z31dICE9ICIiIH0gewogICAgcmV0dXJuIC0xCn0KCmlmICB7IFtn ZGJfY29tcGlsZSBbbGlzdCAke2JpbmZpbGV9MS5vICR7YmluZmlsZX0yLm9d IFwKCSAgICIke2JpbmZpbGV9IiBleGVjdXRhYmxlIHt9XSAhPSAiIiB9IHsK ICAgIHJldHVybiAtMQp9CgpjbGVhbl9yZXN0YXJ0ICR7dGVzdGZpbGV9Cgpp ZiAhW3J1bnRvX21haW5dIHsKICAgIHJldHVybiAtMQp9CgojIFByaW50IGNv bnN0IHZhcmlhYmxlLCB0ZXN0IHdoZXRoZXIgaXQgaGFzIGJlZW4gYWRkZWQg dG8gcGFydGlhbAojIHN5bWJvbCB0YWJsZS4KZ2RiX3Rlc3QgInByaW50IGNv bnN0X3ZhciIgIiA9IDYiICJwcmludCBjb25zdCB2YXJpYWJsZSIK --001a11c1fd62e0148a04f0b156d1--