From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38874 invoked by alias); 12 Dec 2016 18:38:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38850 invoked by uid 89); 12 Dec 2016 18:38:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=vapiergentooorg, vapier@gentoo.org, simulator X-HELO: mail-yw0-f180.google.com Received: from mail-yw0-f180.google.com (HELO mail-yw0-f180.google.com) (209.85.161.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Dec 2016 18:38:12 +0000 Received: by mail-yw0-f180.google.com with SMTP id r204so69964750ywb.0 for ; Mon, 12 Dec 2016 10:38:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=X2IB3t8CRiPkifru5P0FsjfqYrvBpcwqBYkfu2Rp49E=; b=S0R7X1WD5RG5tZAE4fXQ/fv5sI6EorK6pVOcVvUnHjoTltUKxaa6mzygEWigWwIcaj jgOSnPaNDcdcsxbtJ2NM2AW2/t5qerATA8ib1tVdiLR5ovzlOd9oZZF6/YjLMohH89Cs HYnSFzF8yTT/URrT8rD7z/Asbx16CqGxpRoT/JNzxPaqjb6PwFuNpOM6vOw9giY+Iqhx jl9TfiseNF1IBGDX5EJawEK5CNDRQm9XIy8KK72NlGvrmXwtzQ3sE0i2Nf1hHQlkipaV jf2qGJF8dvKaD6g/4bASmwchHN+cuOGKOoX8S5ZBWA4A42D04l18KXE/nOR/4B+eVy32 h4Fg== X-Gm-Message-State: AKaTC00Pw/w9PJRF6ImO7JBrWaB8ZDv18/ocRyegRKS4iQwrEtgWQ6AWlpFciF/F9hG50P5ekqpozmh3D2Kl3Kbv X-Received: by 10.129.4.130 with SMTP id 124mr89340576ywe.333.1481567891174; Mon, 12 Dec 2016 10:38:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.92.4 with HTTP; Mon, 12 Dec 2016 10:38:10 -0800 (PST) In-Reply-To: References: From: Jim Wilson Date: Mon, 12 Dec 2016 18:38:00 -0000 Message-ID: Subject: Re: [PATCH] fix for aarch64 sim tbnz bug To: Nick Clifton Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-12/txt/msg00272.txt.bz2 ping https://sourceware.org/ml/gdb-patches/2016-12/msg00128.html On Sun, Dec 4, 2016 at 7:43 PM, Jim Wilson wrote: > On Fri, Dec 2, 2016 at 1:31 AM, Mike Frysinger wrote: >> can we please start getting tests added to sim too ? using gcc >> indirectly to validate the sim is a bit un > > The GCC testsuite is the part that I care most about, but it does make > sense for me to be adding simulator tests. There are currently no > interesting aarch64 tests, so it isn't clear if there is any > particular style I should be using. So I just chose a style that > seemed OK to me. I have tests for the last two simulator patches I > contributed. I verified that the tests work with current sources and > fail without my two patches. > > I had to make a few fixes to the existing testsuite.inc file. I moved > .Lpass and .Lfail out of the pass and fail macros, as otherwise I end > up with duplicate definitions. I also changed fail to return > non-zero, because it should. I find it confusing to manually run a > testcase and see it print fail, and then return a zero exit code. > > Jim > > PS set_flags_for_add64 is broken, which causes adds and cmn to fail. > I have a fix, and this will be my next aarch64 sim patch, but I > haven't written a testcase yet.