From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119636 invoked by alias); 2 Dec 2016 15:59:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119618 invoked by uid 89); 2 Dec 2016 15:59:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-yw0-f176.google.com Received: from mail-yw0-f176.google.com (HELO mail-yw0-f176.google.com) (209.85.161.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Dec 2016 15:59:03 +0000 Received: by mail-yw0-f176.google.com with SMTP id t125so219489711ywc.1 for ; Fri, 02 Dec 2016 07:59:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VS6FkJQf6s59RnlnsEGqu+yXwghrr0sC1XHafi3OSpM=; b=Kx12wkfQSY6lzmfu9kJBSGmDsGD8KUwLFmKE4bzH6rPHJCujpZow6GGaeHOKoCnj/q sZsWz4X6VFV8vs7/DdI2kMUBtyjstZDRLBkeQCsDredQmX4uPGCwK5vBPcP6rF7Df23t t+zqlCRF4wQItTQCL11KPEVqum5iaOD9zRL6gfJnEEta5zRHdsakT/qkxk48WzKpEKL2 WqK8ecnjGpwRfwwPYyjR70MFlnfw2AYH+eAk6r7+Vf6V1JjLPJEwx6L6yNBI4wlfvjy7 e/5QFOpl0mhCUJrvFdQc2BRucm6pbSlVCS71zKdoNbXzjAZRkvz1U2+NlsZ71HY3qMuv 1pZA== X-Gm-Message-State: AKaTC00WzNwzkIC1Ye7HiwJ6DaS9tfEOen/OEDqpUzDzjX3OQiSUIStv1Olza63S4Ff24H1kwWp829b8Z+1RkYrC X-Received: by 10.129.109.200 with SMTP id i191mr45581992ywc.14.1480694341980; Fri, 02 Dec 2016 07:59:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.92.4 with HTTP; Fri, 2 Dec 2016 07:59:01 -0800 (PST) In-Reply-To: <81f852ec-2ef8-9551-dd9e-de93909adef6@redhat.com> References: <81f852ec-2ef8-9551-dd9e-de93909adef6@redhat.com> From: Jim Wilson Date: Fri, 02 Dec 2016 15:59:00 -0000 Message-ID: Subject: Re: [PATCH] fix for aarch64 sim tbnz bug To: Nick Clifton Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-12/txt/msg00099.txt.bz2 On Fri, Dec 2, 2016 at 4:03 AM, Nick Clifton wrote: > Just one question: > + if (aarch64_get_reg_u64 (cpu, rt, NO_SP) & (((uint64_t) 1) << pos)) > Would: > + if (aarch64_get_reg_u64 (cpu, rt, NO_SP) & (1UL << pos) > work as well, or would this break on 32-bit hosts ? I don't think that 1UL works, as long could be 32-bits. It would have to be 1ULL. But that assumes that long long is 64-bits. aarch64_get_reg_u64 is defined to return uint64_t, so casting to that seemed the best choice to me, to keep types consistent. Jim