From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82460 invoked by alias); 5 Dec 2016 03:45:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81486 invoked by uid 89); 5 Dec 2016 03:44:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=quit, U*vapier, sk:vapier@, sk:vapier X-HELO: mail-yw0-f178.google.com Received: from mail-yw0-f178.google.com (HELO mail-yw0-f178.google.com) (209.85.161.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Dec 2016 03:43:49 +0000 Received: by mail-yw0-f178.google.com with SMTP id i145so248089589ywg.2 for ; Sun, 04 Dec 2016 19:43:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/WxPYWYC+1UJlPfzyyJkQ+Z5RtNjsFn6OlkSHIecm9E=; b=MBsx9xVaYAIjmDt74WUfam0wBwZw9DDH+TrCa1cR8RsUFjnZ3oSVUriF7tan5uO8y2 L0GJVcbHeK3OE5IUNQmEIa0d9L+LjpfqjUROaN/AG+6L9rCF4rlLH6lWVsDzQzYhZrFS ItD6eiG0jXTMI1c1MUHigHLUcq6Rf+CR+DH9UTVGkrF/NeuaQIIz38VSxIZZQX+4bEEY wxxV2CaQCC75SJiwAbb50ojxdnWUaAko6I3ZKcuUszE4ET/HZN+CcXsvuQyThaCVY4O3 yIQAUQQlDfdyoyJ7UXbM9lCDVIw3vAJH0O2puEk42xU45xlTjFOn0O9GPThqsd5JrsX9 vsTA== X-Gm-Message-State: AKaTC01H6aIbagdimrM6VNkvH5YSp37ajHT7IfxWJZJ/ETPFHy6mv/Vm1ezLoF0Ae7DsVkMi3bvxJFhEUZW+zjY6 X-Received: by 10.129.40.149 with SMTP id o143mr52690501ywo.106.1480909427787; Sun, 04 Dec 2016 19:43:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.92.4 with HTTP; Sun, 4 Dec 2016 19:43:47 -0800 (PST) In-Reply-To: References: From: Jim Wilson Date: Mon, 05 Dec 2016 03:45:00 -0000 Message-ID: Subject: Re: [PATCH] fix for aarch64 sim tbnz bug To: Mike Frysinger Cc: "gdb-patches@sourceware.org" , Nick Clifton Content-Type: multipart/mixed; boundary=001a1140865a638d5f0542e11822 X-SW-Source: 2016-12/txt/msg00128.txt.bz2 --001a1140865a638d5f0542e11822 Content-Type: text/plain; charset=UTF-8 Content-length: 1127 On Fri, Dec 2, 2016 at 1:31 AM, Mike Frysinger wrote: > can we please start getting tests added to sim too ? using gcc > indirectly to validate the sim is a bit un The GCC testsuite is the part that I care most about, but it does make sense for me to be adding simulator tests. There are currently no interesting aarch64 tests, so it isn't clear if there is any particular style I should be using. So I just chose a style that seemed OK to me. I have tests for the last two simulator patches I contributed. I verified that the tests work with current sources and fail without my two patches. I had to make a few fixes to the existing testsuite.inc file. I moved .Lpass and .Lfail out of the pass and fail macros, as otherwise I end up with duplicate definitions. I also changed fail to return non-zero, because it should. I find it confusing to manually run a testcase and see it print fail, and then return a zero exit code. Jim PS set_flags_for_add64 is broken, which causes adds and cmn to fail. I have a fix, and this will be my next aarch64 sim patch, but I haven't written a testcase yet. --001a1140865a638d5f0542e11822 Content-Type: text/x-patch; charset=US-ASCII; name="aarch64-sim-tests.patch" Content-Disposition: attachment; filename="aarch64-sim-tests.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iwbj66zn0 Content-length: 5824 MjAxNi0xMi0wNCAgSmltIFdpbHNvbiAgPGppbS53aWxzb25AbGluYXJvLm9y Zz4KCglzaW0vdGVzdHN1aXRlL3NpbS9hYXJjaDY0CgkqIHRlc3R1dGlscy5p bmMgKHBhc3MpOiBNb3ZlIC5McGFzcyBvdXRzaWRlIG1hY3JvLgoJKGZhaWwp OiBNb3ZlIC5MZmFpbCBvdXRzaWRlIG1hY3JvLiAgUmV0dXJuIDEgaW5zdGVh ZCBvZiAwLgoJKiBmc3R1ci5zOiBOZXcuCgkqIHRibnouczogTmV3LgoKZGlm ZiAtLWdpdCBhL3NpbS90ZXN0c3VpdGUvc2ltL2FhcmNoNjQvZnN0dXIucyBi L3NpbS90ZXN0c3VpdGUvc2ltL2FhcmNoNjQvZnN0dXIucwpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4yMjA2YWU1Ci0tLSAvZGV2L251 bGwKKysrIGIvc2ltL3Rlc3RzdWl0ZS9zaW0vYWFyY2g2NC9mc3R1ci5zCkBA IC0wLDAgKzEsMTM2IEBACisjIG1hY2g6IGFhcmNoNjQKKworIyBDaGVjayB0 aGUgRlAgc3RvcmUgdW5zY2FsZWQgb2Zmc2V0IGluc3RydWN0aW9uczogZnN0 dXJzLCBmc3R1cmQsIGZzdHVycS4KKyMgQ2hlY2sgdGhlIHZhbHVlcyAtMSwg YW5kIFhYWF9NQVgsIHdoaWNoIHRlc3RzIGFsbCBiaXRzLgorIyBDaGVjayB3 aXRoIG9mZnNldHMgLTI1NiBhbmQgMjU1LCB3aGljaCB0ZXN0cyBhbGwgYml0 cy4KKyMgQWxzbyB0ZXN0cyB0aGUgRlAgbG9hZCB1bnNjYWxlZCBvZmZzZXQg aW5zdHJ1Y3Rpb25zOiBmbGR1cnMsIGZsZHVyZCwgZmxkdXJxLgorCisuaW5j bHVkZSAidGVzdHV0aWxzLmluYyIKKworCS5kYXRhCitmbTE6CisJLndvcmQg MzIxMjgzNjg2NAorZm1heDoKKwkud29yZCAyMTM5MDk1MDM5CitmdG1wOgor CS53b3JkIDAKKworZG0xOgorCS53b3JkIDAKKwkud29yZCAtMTA3NDc5MDQw MAorZG1heDoKKwkud29yZCA0Mjk0OTY3Mjk1CisJLndvcmQgMjE0NjQzNTA3 MQorZHRtcDoKKwkud29yZCAwCisJLndvcmQgMAorCitsZG0xOgorCS53b3Jk CTAKKwkud29yZAkwCisJLndvcmQJMAorCS53b3JkCS0xMDczODA3MzYwCits ZG1heDoKKwkud29yZAk0Mjk0OTY3Mjk1CisJLndvcmQJNDI5NDk2NzI5NQor CS53b3JkCTQyOTQ5NjcyOTUKKwkud29yZAkyMTQ3NDE4MTExCitsZHRtcDoK Kwkud29yZCAwCisJLndvcmQgMAorCS53b3JkIDAKKwkud29yZCAwCisKKwlz dGFydAorCWFkcnAgeDEsIGZ0bXAKKwlhZGQgeDEsIHgxLCA6bG8xMjpmdG1w CisKKwlhZHJwIHgwLCBmbTEKKwlhZGQgeDAsIHgwLCA6bG8xMjpmbTEKKwlz dWIgeDUsIHgwLCAjMjU1CisJc3ViIHg2LCB4MSwgIzI1NQorCW1vdmkgZDIs ICMwCisJbGR1ciBzMiwgW3g1LCAjMjU1XQorCXN0dXIgczIsIFt4NiwgIzI1 NV0KKwlsZHIgdzMsIFt4MF0KKwlsZHIgdzQsIFt4MV0KKwljbXAgdzMsIHc0 CisJYm5lIC5MZmFpbHVyZQorCisJYWRycCB4MCwgZm1heAorCWFkZCB4MCwg eDAsIDpsbzEyOmZtYXgKKwlhZGQgeDUsIHgwLCAjMjU2CisJYWRkIHg2LCB4 MSwgIzI1NgorCW1vdmkgZDIsICMwCisJbGR1ciBzMiwgW3g1LCAjLTI1Nl0K KwlzdHVyIHMyLCBbeDYsICMtMjU2XQorCWxkciB3MywgW3gwXQorCWxkciB3 NCwgW3gxXQorCWNtcCB3MywgdzQKKwlibmUgLkxmYWlsdXJlCisKKwlhZHJw IHgxLCBkdG1wCisJYWRkIHgxLCB4MSwgOmxvMTI6ZHRtcAorCisJYWRycCB4 MCwgZG0xCisJYWRkIHgwLCB4MCwgOmxvMTI6ZG0xCisJc3ViIHg1LCB4MCwg IzI1NQorCXN1YiB4NiwgeDEsICMyNTUKKwltb3ZpIGQyLCAjMAorCWxkdXIg ZDIsIFt4NSwgIzI1NV0KKwlzdHVyIGQyLCBbeDYsICMyNTVdCisJbGRyIHgz LCBbeDBdCisJbGRyIHg0LCBbeDFdCisJY21wIHgzLCB4NAorCWJuZSAuTGZh aWx1cmUKKworCWFkcnAgeDAsIGRtYXgKKwlhZGQgeDAsIHgwLCA6bG8xMjpk bWF4CisJYWRkIHg1LCB4MCwgIzI1NgorCWFkZCB4NiwgeDEsICMyNTYKKwlt b3ZpIGQyLCAjMAorCWxkdXIgZDIsIFt4NSwgIy0yNTZdCisJc3R1ciBkMiwg W3g2LCAjLTI1Nl0KKwlsZHIgeDMsIFt4MF0KKwlsZHIgeDQsIFt4MV0KKwlj bXAgeDMsIHg0CisJYm5lIC5MZmFpbHVyZQorCisJYWRycCB4MSwgbGR0bXAK KwlhZGQgeDEsIHgxLCA6bG8xMjpsZHRtcAorCisJYWRycCB4MCwgbGRtMQor CWFkZCB4MCwgeDAsIDpsbzEyOmxkbTEKKwlzdWIgeDUsIHgwLCAjMjU1CisJ c3ViIHg2LCB4MSwgIzI1NQorCW1vdmkgdjIuMmQsICMwCisJbGR1ciBxMiwg W3g1LCAjMjU1XQorCXN0dXIgcTIsIFt4NiwgIzI1NV0KKwlsZHIgeDMsIFt4 MF0KKwlsZHIgeDQsIFt4MV0KKwljbXAgeDMsIHg0CisJYm5lIC5MZmFpbHVy ZQorCWxkciB4MywgW3gwLCA4XQorCWxkciB4NCwgW3gxLCA4XQorCWNtcCB4 MywgeDQKKwlibmUgLkxmYWlsdXJlCisKKwlhZHJwIHgwLCBsZG1heAorCWFk ZCB4MCwgeDAsIDpsbzEyOmxkbWF4CisJYWRkIHg1LCB4MCwgIzI1NgorCWFk ZCB4NiwgeDEsICMyNTYKKwltb3ZpIHYyLjJkLCAjMAorCWxkdXIgcTIsIFt4 NSwgIy0yNTZdCisJc3R1ciBxMiwgW3g2LCAjLTI1Nl0KKwlsZHIgeDMsIFt4 MF0KKwlsZHIgeDQsIFt4MV0KKwljbXAgeDMsIHg0CisJYm5lIC5MZmFpbHVy ZQorCWxkciB4MywgW3gwLCA4XQorCWxkciB4NCwgW3gxLCA4XQorCWNtcCB4 MywgeDQKKwlibmUgLkxmYWlsdXJlCisKKwlwYXNzCisuTGZhaWx1cmU6CisJ ZmFpbApkaWZmIC0tZ2l0IGEvc2ltL3Rlc3RzdWl0ZS9zaW0vYWFyY2g2NC90 Ym56LnMgYi9zaW0vdGVzdHN1aXRlL3NpbS9hYXJjaDY0L3RibnoucwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4yNDE2MTAxCi0tLSAv ZGV2L251bGwKKysrIGIvc2ltL3Rlc3RzdWl0ZS9zaW0vYWFyY2g2NC90Ym56 LnMKQEAgLTAsMCArMSw1NSBAQAorIyBtYWNoOiBhYXJjaDY0CisKKyMgQ2hl Y2sgdGhlIHRlc3QtYml0LWFuZC1icmFuY2ggaW5zdHJ1Y3Rpb25zOiB0Ym56 LCBhbmQgdGJ6LgorIyBXZSBjaGVjayB0aGUgZWRnZSBjb25kaXRpb24gYml0 IHBvc2l0aW9uczogMCwgMTw8MzEsIDE8PDMyLCAxPDw2My4KKworLmluY2x1 ZGUgInRlc3R1dGlscy5pbmMiCisKKwlzdGFydAorCW1vdiB4MCwgIzEKKwl0 Ym56IHgwLCAjMCwgLkwxCisJZmFpbAorLkwxOgorCXRieiB4MCwgIzAsIC5M ZmFpbHVyZQorCW1vdiB4MCwgIzB4RkZGRkZGRkZGRkZGRkZGRQorCXRibnog eDAsICMwLCAuTGZhaWx1cmUKKwl0YnogeDAsICMwLCAuTDIKKwlmYWlsCisu TDI6CisKKwltb3YgeDAsICMweDgwMDAwMDAwCisJdGJueiB4MCwgIzMxLCAu TDMKKwlmYWlsCisuTDM6CisJdGJ6IHgwLCAjMzEsIC5MZmFpbHVyZQorCW1v diB4MCwgIzB4RkZGRkZGRkY3RkZGRkZGRgorCXRibnogeDAsICMzMSwgLkxm YWlsdXJlCisJdGJ6IHgwLCAjMzEsIC5MNAorCWZhaWwKKy5MNDoKKworCW1v diB4MCwgIzB4MTAwMDAwMDAwCisJdGJueiB4MCwgIzMyLCAuTDUKKwlmYWls CisuTDU6CisJdGJ6IHgwLCAjMzIsIC5MZmFpbHVyZQorCW1vdiB4MCwgIzB4 RkZGRkZGRkVGRkZGRkZGRgorCXRibnogeDAsICMzMiwgLkxmYWlsdXJlCisJ dGJ6IHgwLCAjMzIsIC5MNgorCWZhaWwKKy5MNjoKKworCW1vdiB4MCwgIzB4 ODAwMDAwMDAwMDAwMDAwMAorCXRibnogeDAsICM2MywgLkw3CisJZmFpbAor Lkw3OgorCXRieiB4MCwgIzYzLCAuTGZhaWx1cmUKKwltb3YgeDAsICMweDdG RkZGRkZGRkZGRkZGRkYKKwl0Ym56IHgwLCAjNjMsIC5MZmFpbHVyZQorCXRi eiB4MCwgIzYzLCAuTDgKKwlmYWlsCisuTDg6CisKKwlwYXNzCisuTGZhaWx1 cmU6CisJZmFpbApkaWZmIC0tZ2l0IGEvc2ltL3Rlc3RzdWl0ZS9zaW0vYWFy Y2g2NC90ZXN0dXRpbHMuaW5jIGIvc2ltL3Rlc3RzdWl0ZS9zaW0vYWFyY2g2 NC90ZXN0dXRpbHMuaW5jCmluZGV4IGM4ODk3YWEuLjk5MDU3YWYgMTAwNjQ0 Ci0tLSBhL3NpbS90ZXN0c3VpdGUvc2ltL2FhcmNoNjQvdGVzdHV0aWxzLmlu YworKysgYi9zaW0vdGVzdHN1aXRlL3NpbS9hYXJjaDY0L3Rlc3R1dGlscy5p bmMKQEAgLTQzLDExICs0MywxMSBAQAogCQogCXN3aXdyaXRlIDUKIAlleGl0 IDAKKwkuZW5kbQogCiAJLmRhdGEKIC5McGFzczoKIAkuYXNjaXogInBhc3Nc biIKLQkuZW5kbQogCiAjIE1BQ1JPOiBmYWlsCiAjIFdyaXRlICdmYWlsJyB0 byBzdGRvdXQgYW5kIHF1aXQKQEAgLTU2LDEyICs1NiwxMiBAQAogCWFkcnAJ eDEsIC5MZmFpbAogCWFkZAl4MSwgeDEsIDpsbzEyOi5MZmFpbAogCXN3aXdy aXRlIDUKLQlleGl0IDAKKwlleGl0IDEKKwkuZW5kbQogCiAJLmRhdGEKIC5M ZmFpbDoKIAkuYXNjaXogImZhaWxcbiIKLQkuZW5kbQogCiAjIE1BQ1JPOiBz dGFydAogIyBBbGwgYXNzZW1ibGVyIHRlc3RzIHNob3VsZCBzdGFydCB3aXRo IGEgY2FsbCB0byAic3RhcnQiCg== --001a1140865a638d5f0542e11822--