On Fri, Dec 2, 2016 at 1:31 AM, Mike Frysinger wrote: > can we please start getting tests added to sim too ? using gcc > indirectly to validate the sim is a bit un The GCC testsuite is the part that I care most about, but it does make sense for me to be adding simulator tests. There are currently no interesting aarch64 tests, so it isn't clear if there is any particular style I should be using. So I just chose a style that seemed OK to me. I have tests for the last two simulator patches I contributed. I verified that the tests work with current sources and fail without my two patches. I had to make a few fixes to the existing testsuite.inc file. I moved .Lpass and .Lfail out of the pass and fail macros, as otherwise I end up with duplicate definitions. I also changed fail to return non-zero, because it should. I find it confusing to manually run a testcase and see it print fail, and then return a zero exit code. Jim PS set_flags_for_add64 is broken, which causes adds and cmn to fail. I have a fix, and this will be my next aarch64 sim patch, but I haven't written a testcase yet.