From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99404 invoked by alias); 14 Jan 2017 19:21:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99389 invoked by uid 89); 14 Jan 2017 19:21:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:3342 X-HELO: mail-yw0-f182.google.com Received: from mail-yw0-f182.google.com (HELO mail-yw0-f182.google.com) (209.85.161.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jan 2017 19:21:15 +0000 Received: by mail-yw0-f182.google.com with SMTP id l19so49003901ywc.2 for ; Sat, 14 Jan 2017 11:21:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=EHFE3DOnMn6ZLRqNwGvSy0b0hHBP0GejxwqvBxypOWw=; b=sFPtNk3Evv40wjdnsYI7iS0J5Xdxz9m0wJRVyEUBHLQfTDVlJJsrHYo1R/faa9IUEO pTxWOp6heCeHRgWkBFewbPPDsGROKWNpuMY+ypyQZkRQhpTqaCa+C2PsyW6XSr2jN/xD uH6tvZssd4JGyvyQW681S9THVozu0jB31QWc9+R06iqvPNHSEzdPwn8FZmb0gqJCEI0g e/WAoVnRhHzb4PKF33B1/7+FIxInskhWdvRGrLPzDzA5T74smrG9oTBaEnA7SxCjasu6 rc07hM/28wuqLmPKjQlqkSRaWExAOEIIN13bVsMBD1r1vxLfWRKW4VoV9fnQ51M7nfw/ 4Khw== X-Gm-Message-State: AIkVDXJki+W3Y1CE6CiiN+0ebJ87lLsGsrwDrk6RPjSXtI/9SYMeljj7M2rZsUabVwHcRrzEWzrJsOGPvufoh5QV X-Received: by 10.129.4.71 with SMTP id 68mr18112935ywe.333.1484421673528; Sat, 14 Jan 2017 11:21:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.92.4 with HTTP; Sat, 14 Jan 2017 11:21:13 -0800 (PST) From: Jim Wilson Date: Sat, 14 Jan 2017 19:21:00 -0000 Message-ID: Subject: [PATCH] aarch64 sim xtn2 bug fix To: gdb-patches@sourceware.org Cc: Nick Clifton Content-Type: multipart/mixed; boundary=001a113f61c48c7e27054612dafa X-SW-Source: 2017-01/txt/msg00276.txt.bz2 --001a113f61c48c7e27054612dafa Content-Type: text/plain; charset=UTF-8 Content-length: 349 The code is applying a bias (shift) to inputs which is wrong. The index in case 2 should be i + 2 not i + 4. We can simplify the code a little and remove the if statement, reducing 7 lines to 3 in each of the 3 cases. The testcase works with the patch, and fails without. The patch reduces GCC C testsuite failures from 2174 to 2108 (-66). Jim --001a113f61c48c7e27054612dafa Content-Type: text/x-patch; charset=US-ASCII; name="aarch64-sim-xtn2.patch" Content-Disposition: attachment; filename="aarch64-sim-xtn2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ixxmc0oi0 Content-length: 4230 CXNpbS9hYXJjaDY0LwoJKiBzaW11bGF0b3IuYyAoZG9fdmVjX1hUTik6IERl bGV0ZSBzaGlmdHMuICBJbiBjYXNlIDIsIGNoYW5nZSBpbmRleAoJZnJvbSBp ICsgNCB0byBpICsgMi4gIERlbGV0ZSBpZiBvbiBiaWFzLCBjaGFuZ2UgaW5k ZXggdG8gaSArIGJpYXMgKiBYLgoKCXNpbS90ZXN0c3VpdGUvc2ltL2FhcmNo NjQvCgkqIHh0bi5zOiBOZXcuCgpkaWZmIC0tZ2l0IGEvc2ltL2FhcmNoNjQv c2ltdWxhdG9yLmMgYi9zaW0vYWFyY2g2NC9zaW11bGF0b3IuYwppbmRleCAz NjEyOWU1Li5jOGU2NWM1IDEwMDY0NAotLS0gYS9zaW0vYWFyY2g2NC9zaW11 bGF0b3IuYworKysgYi9zaW0vYWFyY2g2NC9zaW11bGF0b3IuYwpAQCAtNDIw NiwzMyArNDIwMywyMSBAQCBkb192ZWNfWFROIChzaW1fY3B1ICpjcHUpCiAg IHN3aXRjaCAoSU5TVFIgKDIzLCAyMikpCiAgICAgewogICAgIGNhc2UgMDoK LSAgICAgIGlmIChiaWFzKQotCWZvciAoaSA9IDA7IGkgPCA4OyBpKyspCi0J ICBhYXJjaDY0X3NldF92ZWNfdTggKGNwdSwgdmQsIGkgKyA4LAotCQkJICAg ICAgYWFyY2g2NF9nZXRfdmVjX3UxNiAoY3B1LCB2cywgaSkgPj4gOCk7Ci0g ICAgICBlbHNlCi0JZm9yIChpID0gMDsgaSA8IDg7IGkrKykKLQkgIGFhcmNo NjRfc2V0X3ZlY191OCAoY3B1LCB2ZCwgaSwgYWFyY2g2NF9nZXRfdmVjX3Ux NiAoY3B1LCB2cywgaSkpOworICAgICAgZm9yIChpID0gMDsgaSA8IDg7IGkr KykKKwlhYXJjaDY0X3NldF92ZWNfdTggKGNwdSwgdmQsIGkgKyAoYmlhcyAq IDgpLAorCQkJICAgIGFhcmNoNjRfZ2V0X3ZlY191MTYgKGNwdSwgdnMsIGkp KTsKICAgICAgIHJldHVybjsKIAogICAgIGNhc2UgMToKLSAgICAgIGlmIChi aWFzKQotCWZvciAoaSA9IDA7IGkgPCA0OyBpKyspCi0JICBhYXJjaDY0X3Nl dF92ZWNfdTE2IChjcHUsIHZkLCBpICsgNCwKLQkJCSAgICAgICBhYXJjaDY0 X2dldF92ZWNfdTMyIChjcHUsIHZzLCBpKSA+PiAxNik7Ci0gICAgICBlbHNl Ci0JZm9yIChpID0gMDsgaSA8IDQ7IGkrKykKLQkgIGFhcmNoNjRfc2V0X3Zl Y191MTYgKGNwdSwgdmQsIGksIGFhcmNoNjRfZ2V0X3ZlY191MzIgKGNwdSwg dnMsIGkpKTsKKyAgICAgIGZvciAoaSA9IDA7IGkgPCA0OyBpKyspCisJYWFy Y2g2NF9zZXRfdmVjX3UxNiAoY3B1LCB2ZCwgaSArIChiaWFzICogNCksCisJ CQkgICAgIGFhcmNoNjRfZ2V0X3ZlY191MzIgKGNwdSwgdnMsIGkpKTsKICAg ICAgIHJldHVybjsKIAogICAgIGNhc2UgMjoKLSAgICAgIGlmIChiaWFzKQot CWZvciAoaSA9IDA7IGkgPCAyOyBpKyspCi0JICBhYXJjaDY0X3NldF92ZWNf dTMyIChjcHUsIHZkLCBpICsgNCwKLQkJCSAgICAgICBhYXJjaDY0X2dldF92 ZWNfdTY0IChjcHUsIHZzLCBpKSA+PiAzMik7Ci0gICAgICBlbHNlCi0JZm9y IChpID0gMDsgaSA8IDI7IGkrKykKLQkgIGFhcmNoNjRfc2V0X3ZlY191MzIg KGNwdSwgdmQsIGksIGFhcmNoNjRfZ2V0X3ZlY191NjQgKGNwdSwgdnMsIGkp KTsKKyAgICAgIGZvciAoaSA9IDA7IGkgPCAyOyBpKyspCisJYWFyY2g2NF9z ZXRfdmVjX3UzMiAoY3B1LCB2ZCwgaSArIChiaWFzICogMiksCisJCQkgICAg IGFhcmNoNjRfZ2V0X3ZlY191NjQgKGNwdSwgdnMsIGkpKTsKICAgICAgIHJl dHVybjsKICAgICB9CiB9CmRpZmYgLS1naXQgYS9zaW0vdGVzdHN1aXRlL3Np bS9hYXJjaDY0L3h0bi5zIGIvc2ltL3Rlc3RzdWl0ZS9zaW0vYWFyY2g2NC94 dG4ucwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5kZTM2 OWY3Ci0tLSAvZGV2L251bGwKKysrIGIvc2ltL3Rlc3RzdWl0ZS9zaW0vYWFy Y2g2NC94dG4ucwpAQCAtMCwwICsxLDc5IEBACisjIG1hY2g6IGFhcmNoNjQK KworIyBDaGVjayB0aGUgZXh0cmFjdCBuYXJyb3cgaW5zdHJ1Y3Rpb25zOiB4 dG4sIHh0bjIuCisKKy5pbmNsdWRlICJ0ZXN0dXRpbHMuaW5jIgorCisJLmRh dGEKKwkuYWxpZ24gNAoraW5wdXQ6CisJLndvcmQgMHgwNDAzMDIwMQorCS53 b3JkIDB4MDgwNzA2MDUKKwkud29yZCAweDBjMGIwYTA5CisJLndvcmQgMHgx MDBmMGUwZAoraW5wdXQyOgorCS53b3JkIDB4MTQxMzEyMTEKKwkud29yZCAw eDE4MTcxNjE1CisJLndvcmQgMHgxYzFiMWExOQorCS53b3JkIDB4MjAxZjFl MWQKK3gxNmI6CisJLndvcmQgMHgwNzA1MDMwMQorCS53b3JkIDB4MGYwZDBi MDkKKwkud29yZCAweDE3MTUxMzExCisJLndvcmQgMHgxZjFkMWIxOQoreDho OgorCS53b3JkIDB4MDYwNTAyMDEKKwkud29yZCAweDBlMGQwYTA5CisJLndv cmQgMHgxNjE1MTIxMQorCS53b3JkIDB4MWUxZDFhMTkKK3g0czoKKwkud29y ZCAweDA0MDMwMjAxCisJLndvcmQgMHgwYzBiMGEwOQorCS53b3JkIDB4MTQx MzEyMTEKKwkud29yZCAweDFjMWIxYTE5CisKKwlzdGFydAorCWFkcnAgeDAs IGlucHV0CisJbGRyIHEwLCBbeDAsICM6bG8xMjppbnB1dF0KKwlhZHJwIHgw LCBpbnB1dDIKKwlsZHIgcTEsIFt4MCwgIzpsbzEyOmlucHV0Ml0KKworCXh0 biB2Mi44YiwgdjAuOGgKKwl4dG4yIHYyLjE2YiwgdjEuOGgKKwltb3YgeDEs IHYyLmRbMF0KKwltb3YgeDIsIHYyLmRbMV0KKwlhZHJwIHgzLCB4MTZiCisJ bGRyIHg0LCBbeDMsICM6bG8xMjp4MTZiXQorCWNtcCB4MSwgeDQKKwlibmUg LkxmYWlsdXJlCisJbGRyIHg1LCBbeDMsICM6bG8xMjp4MTZiKzhdCisJY21w IHgyLCB4NQorCWJuZSAuTGZhaWx1cmUKKworCXh0biB2Mi40aCwgdjAuNHMK Kwl4dG4yIHYyLjhoLCB2MS40cworCW1vdiB4MSwgdjIuZFswXQorCW1vdiB4 MiwgdjIuZFsxXQorCWFkcnAgeDMsIHg4aAorCWxkciB4NCwgW3gzLCAjOmxv MTI6eDhoXQorCWNtcCB4MSwgeDQKKwlibmUgLkxmYWlsdXJlCisJbGRyIHg1 LCBbeDMsICM6bG8xMjp4OGgrOF0KKwljbXAgeDIsIHg1CisJYm5lIC5MZmFp bHVyZQorCisJeHRuIHYyLjJzLCB2MC4yZAorCXh0bjIgdjIuNHMsIHYxLjJk CisJbW92IHgxLCB2Mi5kWzBdCisJbW92IHgyLCB2Mi5kWzFdCisJYWRycCB4 MywgeDRzCisJbGRyIHg0LCBbeDMsICM6bG8xMjp4NHNdCisJY21wIHgxLCB4 NAorCWJuZSAuTGZhaWx1cmUKKwlsZHIgeDUsIFt4MywgIzpsbzEyOng0cys4 XQorCWNtcCB4MiwgeDUKKwlibmUgLkxmYWlsdXJlCisKKwlwYXNzCisuTGZh aWx1cmU6CisJZmFpbAo= --001a113f61c48c7e27054612dafa--