From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116620-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7943 invoked by alias); 12 Oct 2014 14:13:06 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7926 invoked by uid 89); 12 Oct 2014 14:13:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-qa0-f53.google.com
Received: from mail-qa0-f53.google.com (HELO mail-qa0-f53.google.com) (209.85.216.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 12 Oct 2014 14:13:03 +0000
Received: by mail-qa0-f53.google.com with SMTP id v10so3437412qac.40        for <gdb-patches@sourceware.org>; Sun, 12 Oct 2014 07:13:01 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.140.31.195 with SMTP id f61mr29246178qgf.34.1413123181469; Sun, 12 Oct 2014 07:13:01 -0700 (PDT)
Received: by 10.229.236.2 with HTTP; Sun, 12 Oct 2014 07:13:01 -0700 (PDT)
In-Reply-To: <543A8208.9060605@gmail.com>
References: <543A8208.9060605@gmail.com>
Date: Sun, 12 Oct 2014 14:13:00 -0000
Message-ID: <CABOHX+fLxsakVXs_nXrdTNw1g_MG=9FWJBr2MuE_7_4o8Fruaw@mail.gmail.com>
Subject: Re: [PATCH v2] gdb/i387-tdep.c: Avoid warning for "-Werror=strict-overflow"
From: Iain Buclaw <ibuclaw@gdcproject.org>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>, 	Mark Kettenis <mark.kettenis@xs4all.nl>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00296.txt.bz2

On 12 October 2014 14:28, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> gdb requires "-Werror", and I387_ST0_REGNUM (tdep) is 'variable', then
> compiler can think that I387_ST0_REGNUM (tdep) may be a large number,
> which may cause issue, so report warning.
>
> Need fix this warning, and still keep the code clear enough for readers.
> The related warning under Darwin with gnu built gcc:
>

I had noted the same on GCC 5.0.0 development, found that the line
number in the warning was wrong and raised a bug
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63510), just didn't get
round to submitting a patch for gdb.


>
> 2014-10-13  Chen Gang  <gang.chen.5i5j@gmail.com>
>
>         * i387-tdep.c (i387_supply_fsave): Avoid warning for
>         "-Werror=strict-overflow"
> ---
>  gdb/i387-tdep.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/gdb/i387-tdep.c b/gdb/i387-tdep.c
> index d66ac6a..609b5be 100644
> --- a/gdb/i387-tdep.c
> +++ b/gdb/i387-tdep.c
> @@ -450,11 +450,12 @@ i387_supply_fsave (struct regcache *regcache, int regnum, const void *fsave)
>    struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
>    enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
>    const gdb_byte *regs = fsave;
> -  int i;
> +  int i, end;
>

Also changing from int -> unsigned int fixes the warning.

-- Iain.