From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65049 invoked by alias); 20 Jul 2015 19:14:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65014 invoked by uid 89); 20 Jul 2015 19:14:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 20 Jul 2015 19:14:07 +0000 Received: by wibxm9 with SMTP id xm9so100261101wib.0 for ; Mon, 20 Jul 2015 12:14:04 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.97.7 with SMTP id dw7mr24698523wib.74.1437419644837; Mon, 20 Jul 2015 12:14:04 -0700 (PDT) Received: by 10.27.11.33 with HTTP; Mon, 20 Jul 2015 12:14:04 -0700 (PDT) Date: Mon, 20 Jul 2015 19:14:00 -0000 Message-ID: Subject: [PATCH] bfd: Fix regression when building bfd on mingw32 From: Iain Buclaw To: gdb-patches@sourceware.org, lgustavo@codesourcery.com Content-Type: multipart/mixed; boundary=f46d044304405313a7051b535777 X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00570.txt.bz2 --f46d044304405313a7051b535777 Content-Type: text/plain; charset=UTF-8 Content-length: 914 Hi, This patch is as per suggestion from Pedro, I've also added a check for vasprintf just for completeness sake, and that there is a similar condition for HAVE_DECL_VASPRINTF in libiberty.h. https://sourceware.org/ml/gdb-patches/2015-06/msg00654.html As per my comments earlier, I am going blind on this, but it looks correct to me, and I can at least verify on my machine that I can see: configure stage --- checking whether asprintf is declared... yes checking whether vasprintf is declared... yes --- config.h --- /* Define to 1 if you have the declaration of `asprintf', and to 0 if you don't. */ #define HAVE_DECL_ASPRINTF 1 /* Define to 1 if you have the declaration of `vasprintf', and to 0 if you don't. */ #define HAVE_DECL_VASPRINTF 1 --- So should either one be false, they should have a proper declaration in libiberty.h Luis, can you check this patch is good for you? Regards Iain --- --f46d044304405313a7051b535777 Content-Type: text/x-diff; charset=US-ASCII; name="bfd_asprintf.patch" Content-Disposition: attachment; filename="bfd_asprintf.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iccaj1160 Content-length: 2668 MjAxNS0wNy0yMCAgSWFpbiBCdWNsYXcgIDxpYnVjbGF3QGdkY3Byb2plY3Qu b3JnPgoKCSogY29uZmlndXJlLmluOiBBZGQgYXNwcmludGYgYW5kIHZhc3By aW50ZiB0byBBQ19DSEVDS19ERUNMUy4KCSogY29uZmlnLmluLCBjb25maWd1 cmU6IFJlZ2VuZXJhdGUuCgotLS0gYS9iZmQvY29uZmlnLmluCisrKyBiL2Jm ZC9jb25maWcuaW4KQEAgLTE3LDYgKzE3LDEwIEBACiAvKiBEZWZpbmUgdG8g MSBpZiB5b3UgaGF2ZSB0aGUgPGFsbG9jYS5oPiBoZWFkZXIgZmlsZS4gKi8K ICN1bmRlZiBIQVZFX0FMTE9DQV9ICiAKKy8qIERlZmluZSB0byAxIGlmIHlv dSBoYXZlIHRoZSBkZWNsYXJhdGlvbiBvZiBgYXNwcmludGYnLCBhbmQgdG8g MCBpZiB5b3UKKyAgIGRvbid0LiAqLworI3VuZGVmIEhBVkVfREVDTF9BU1BS SU5URgorCiAvKiBEZWZpbmUgdG8gMSBpZiB5b3UgaGF2ZSB0aGUgZGVjbGFy YXRpb24gb2YgYGJhc2VuYW1lJywgYW5kIHRvIDAgaWYgeW91CiAgICBkb24n dC4gKi8KICN1bmRlZiBIQVZFX0RFQ0xfQkFTRU5BTUUKQEAgLTcyLDYgKzc2 LDEwIEBACiAgICAqLwogI3VuZGVmIEhBVkVfREVDTF9TVFJTVFIKIAorLyog RGVmaW5lIHRvIDEgaWYgeW91IGhhdmUgdGhlIGRlY2xhcmF0aW9uIG9mIGB2 YXNwcmludGYnLCBhbmQgdG8gMCBpZiB5b3UKKyAgIGRvbid0LiAqLworI3Vu ZGVmIEhBVkVfREVDTF9WQVNQUklOVEYKKwogLyogRGVmaW5lIHRvIDEgaWYg eW91IGhhdmUgdGhlIGRlY2xhcmF0aW9uIG9mIGB2c25wcmludGYnLCBhbmQg dG8gMCBpZiB5b3UKICAgIGRvbid0LiAqLwogI3VuZGVmIEhBVkVfREVDTF9W U05QUklOVEYKLS0tIGEvYmZkL2NvbmZpZ3VyZQorKysgYi9iZmQvY29uZmln dXJlCkBAIC0xMzgxOSw2ICsxMzgxOSwyOCBAQCBjYXQgPj5jb25mZGVmcy5o IDw8X0FDRU9GCiAjZGVmaW5lIEhBVkVfREVDTF9TVFJTVFIgJGFjX2hhdmVf ZGVjbAogX0FDRU9GCiAKK2FjX2ZuX2NfY2hlY2tfZGVjbCAiJExJTkVOTyIg ImFzcHJpbnRmIiAiYWNfY3ZfaGF2ZV9kZWNsX2FzcHJpbnRmIiAiJGFjX2lu Y2x1ZGVzX2RlZmF1bHQiCitpZiB0ZXN0ICJ4JGFjX2N2X2hhdmVfZGVjbF9h c3ByaW50ZiIgPSB4IiJ5ZXM7IHRoZW4gOgorICBhY19oYXZlX2RlY2w9MQor ZWxzZQorICBhY19oYXZlX2RlY2w9MAorZmkKKworY2F0ID4+Y29uZmRlZnMu aCA8PF9BQ0VPRgorI2RlZmluZSBIQVZFX0RFQ0xfQVNQUklOVEYgJGFjX2hh dmVfZGVjbAorX0FDRU9GCisKK2FjX2ZuX2NfY2hlY2tfZGVjbCAiJExJTkVO TyIgInZhc3ByaW50ZiIgImFjX2N2X2hhdmVfZGVjbF92YXNwcmludGYiICIk YWNfaW5jbHVkZXNfZGVmYXVsdCIKK2lmIHRlc3QgIngkYWNfY3ZfaGF2ZV9k ZWNsX3Zhc3ByaW50ZiIgPSB4IiJ5ZXM7IHRoZW4gOgorICBhY19oYXZlX2Rl Y2w9MQorZWxzZQorICBhY19oYXZlX2RlY2w9MAorZmkKKworY2F0ID4+Y29u ZmRlZnMuaCA8PF9BQ0VPRgorI2RlZmluZSBIQVZFX0RFQ0xfVkFTUFJJTlRG ICRhY19oYXZlX2RlY2wKK19BQ0VPRgorCiBhY19mbl9jX2NoZWNrX2RlY2wg IiRMSU5FTk8iICJzbnByaW50ZiIgImFjX2N2X2hhdmVfZGVjbF9zbnByaW50 ZiIgIiRhY19pbmNsdWRlc19kZWZhdWx0IgogaWYgdGVzdCAieCRhY19jdl9o YXZlX2RlY2xfc25wcmludGYiID0geCIieWVzOyB0aGVuIDoKICAgYWNfaGF2 ZV9kZWNsPTEKLS0tIGEvYmZkL2NvbmZpZ3VyZS5hYworKysgYi9iZmQvY29u ZmlndXJlLmFjCkBAIC0yMzIsNiArMjMyLDggQEAgQUNfQ0hFQ0tfREVDTFMo bWFsbG9jKQogQUNfQ0hFQ0tfREVDTFMocmVhbGxvYykKIEFDX0NIRUNLX0RF Q0xTKHN0cGNweSkKIEFDX0NIRUNLX0RFQ0xTKHN0cnN0cikKK0FDX0NIRUNL X0RFQ0xTKGFzcHJpbnRmKQorQUNfQ0hFQ0tfREVDTFModmFzcHJpbnRmKQog QUNfQ0hFQ0tfREVDTFMoc25wcmludGYpCiBBQ19DSEVDS19ERUNMUyh2c25w cmludGYpCiBBQ19DSEVDS19ERUNMUyhzdHJubGVuKQo= --f46d044304405313a7051b535777--