From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30637 invoked by alias); 19 Nov 2013 17:43:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30597 invoked by uid 89); 19 Nov 2013 17:43:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.0 required=5.0 tests=AWL,BAYES_20,FREEMAIL_FROM,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-qc0-f169.google.com Received: from Unknown (HELO mail-qc0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 19 Nov 2013 17:43:25 +0000 Received: by mail-qc0-f169.google.com with SMTP id u18so5086224qcx.28 for ; Tue, 19 Nov 2013 09:43:17 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.64.200 with SMTP id f8mr45598793qai.55.1384882997331; Tue, 19 Nov 2013 09:43:17 -0800 (PST) Received: by 10.229.251.201 with HTTP; Tue, 19 Nov 2013 09:43:17 -0800 (PST) In-Reply-To: <87mwl0mlsa.fsf@fleche.redhat.com> References: <87mwl0mlsa.fsf@fleche.redhat.com> Date: Tue, 19 Nov 2013 17:50:00 -0000 Message-ID: Subject: Re: [PATCH] Add d_main_name to dlang.c From: Iain Buclaw To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00556.txt.bz2 On 19 November 2013 15:52, Tom Tromey wrote: >>>>>> "Iain" == Iain Buclaw writes: > > Iain> +2013-11-18 Iain Buclaw > Iain> + > Iain> + * d-lang.h (d_main_name): Add declaration. > Iain> + * d-lang.c (d_main_name): New function. > Iain> + * symtab.c (find_main_name): Add call to d_main_name. > > Looks good to me. > > Do you have a copyright assignment on file? > If not, contact me off-list and I'll get you started. > > Tom By the way, it is more preferable to use the mangled name of the D main function (_Dmain), or the pretty debug de-mangled name? Both work just as well in achieving the job. Regards Iain