From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16353 invoked by alias); 8 Jan 2017 10:38:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16324 invoked by uid 89); 8 Jan 2017 10:38:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=U*simon.marchi, sk:simon.m, sk:simonm, simonmarchipolymtlca X-HELO: mail-ua0-f193.google.com Received: from mail-ua0-f193.google.com (HELO mail-ua0-f193.google.com) (209.85.217.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jan 2017 10:38:39 +0000 Received: by mail-ua0-f193.google.com with SMTP id d5so39800064uag.0 for ; Sun, 08 Jan 2017 02:38:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=gsy3jz52IvoVhfvAEqSZwkISv+h7a1dBKRMCUNZDdfc=; b=amOhzraljhjif78d7PStpvpVLO4UD7sAP72tLrgR9UpzFz1gaZVLoABxBUAeza3OyP PPxQU4r9YS6VHFK3ryC5YTTQ6UZOxH4phl3W/6iokI6Q7C1bZLXpbzq0d1DfsNM2UH4W V9p7mzreJ5xgCRJw6BXW6EdD3E50DaeJCLNZeXXr04NuI0TkRrHxnz2nb6jMWK33SQSL SIThWhBHEir1hh3l43yifGjHvkqBEnz7oLReu+1iEZXuo3b/K4kAcJDVHfORCFl8nh5y t3i3MhojrZLYYy7de8IwuBBEE+s8G+uZfqP0nHsAdW6fH3paDNhd0CysSpFmrefS82mT 8HyA== X-Gm-Message-State: AIkVDXKwT5WJLxStwwSt9Rn6q7SXYUbbAdRsQt50SpvP35Fs2IYqDAiOO8Hxl2L0R9gQv1tw6g+WcJr+hDtQ9g== X-Received: by 10.159.32.99 with SMTP id 90mr53619818uam.138.1483871917845; Sun, 08 Jan 2017 02:38:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.18.199 with HTTP; Sun, 8 Jan 2017 02:38:37 -0800 (PST) In-Reply-To: References: <5806a075-dc30-b664-a834-a633b3b27256@codesourcery.com> From: Iain Buclaw Date: Sun, 08 Jan 2017 10:38:00 -0000 Message-ID: Subject: Re: [PATCH] D: Fix crash when expression debugging To: Simon Marchi Cc: Luis Machado , GDB Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00120.txt.bz2 On 5 January 2017 at 17:13, Simon Marchi wrote: >>>>>>> +if { [skip_d_tests] } { continue } >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> We should output a message: >>>>>> >>>>>> untested "skipping d language tests" >>>>>> >>>>>> It may be more reasonable to just return instead of continuing? The >>>>>> effect >>>>>> will probably be the same, but it is a bit confusing to read >>>>>> "continue" >>>>>> without a visible loop. >>>>>> >>>>> >>>>> I did a quick grep, and it seems like everyone is skippingtests in >>>>> this way except for gdb.ada and gdb.btrace which are doing { return -1 >>>>> } >>>>> >>>>> >>>> >>>> That's a bit of a stretch. Take, for example, a few of the examples in >>>> gdb.base. You will see a number of them returning. >>>> >>>> The problem here is inheriting past confusing practices when we use some >>>> existing files to create new ones, which is not your fault really. I'm >>>> guilty myself. :-) >>>> >>> >>> Yes indeed. I wasn't disagreeing, just questioning the two competing >>> ways of returning. >>> >>> I will update to use return and push this in then if there's no >>> disagreement. :-) >>> >> >> Hopefully someone will chime in for a second opinion. :-) > > > +1 :) FYI, committed patched as-is except for the following adjustment as discussed: -if { [skip_d_tests] } { continue } +if { [skip_d_tests] } { return -1 } Thanks for the review.