From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14514 invoked by alias); 9 Jan 2014 18:32:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14502 invoked by uid 89); 9 Jan 2014 18:32:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qe0-f50.google.com Received: from mail-qe0-f50.google.com (HELO mail-qe0-f50.google.com) (209.85.128.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 09 Jan 2014 18:32:46 +0000 Received: by mail-qe0-f50.google.com with SMTP id 1so3539092qec.9 for ; Thu, 09 Jan 2014 10:32:44 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.49.24.211 with SMTP id w19mr10467875qef.9.1389292364674; Thu, 09 Jan 2014 10:32:44 -0800 (PST) Received: by 10.229.195.196 with HTTP; Thu, 9 Jan 2014 10:32:44 -0800 (PST) In-Reply-To: <871u0h9g41.fsf@fleche.redhat.com> References: <871u0h9g41.fsf@fleche.redhat.com> Date: Thu, 09 Jan 2014 18:32:00 -0000 Message-ID: Subject: Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion From: Iain Buclaw To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00250.txt.bz2 On 9 January 2014 18:15, Tom Tromey wrote: >>>>>> "Iain" == Iain Buclaw writes: > > Iain> D doesn't have macros, so it makes little sense to use macro_expansion_c. > Iain> 2014-01-09 Iain Buclaw > > Iain> * d-lang.c (d_language_defn): Change macro_expansion_c to > Iain> macro_expansion_no. > > Iain> @@ -259,8 +259,8 @@ static const struct language_defn d_language_defn = > Iain> c_value_print, /* Print a top-level value. */ > Iain> default_read_var_value, /* la_read_var_value */ > Iain> NULL, /* Language specific skip_trampoline. */ > Iain> - "this", > Iain> - basic_lookup_symbol_nonlocal, > Iain> + "this", /* name_of_this */ > Iain> + basic_lookup_symbol_nonlocal, > Iain> basic_lookup_transparent_type, > Iain> d_demangle, /* Language specific symbol demangler. */ > Iain> NULL, /* Language specific > > Spurious change. > This patch is ok with this removed. > It was a comment found in every other language file, it was useful when I was studying how things were set-up. Can remove it.