Re: [PATCH v2 2/2] Sync libiberty with gcc upstream

Iain Buclaw
2015-06-29T16:30:35Z

On 29 June 2015 at 18:26, Iain Buclaw <ibuclaw@gdcproject.org> wrote:
> On 29 June 2015 at 17:50, Pedro Alves <palves@redhat.com> wrote:
>> On 06/19/2015 04:24 PM, Iain Buclaw wrote:
>>> Second downstream patch with dlang demangling related changes only.
>>> Should be a more straightforward read than the other one.
>>
>> Hi Iain, seems like this unfortunately caused regressions in
>> gdb.dlang/demangle.exp. See replies to:
>>
>> https://sourceware.org/ml/gdb-testers/2015-q2/msg07341.html
>>
>> I see the same here, e.g., on x86_64 F20:
>>
>> -PASS: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv
>> +FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv
>>
>> gdb.log shows:
>>
>> demangle.test.~this()
>> (gdb) PASS: gdb.dlang/demangle.exp: _D8demangle4test6__dtorMFZv
>> demangle _D8demangle4test6__postblitMFZv
>> Can't demangle "_D8demangle4test6__postblitMFZv"
>> (gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv
>> demangle _D8demangle4testFHAbaZv
>>
>
> Interesting, I don't understand where these tests come from.
>
> ---
> PASS -> FAIL: gdb.dlang/demangle.exp:
> _D2rt6dmain211_d_run_mainUiPPaPUAAaZiZi7tryExecMFMDFZvZv
> PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle3fnAFZv3fnBMFZv
> PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv1S3fnCFZv
> PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv1S3fnDMFZv
> PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv5localMFZi
> PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv
> ---
>
> All of these *should* fail, and they have been updated to their
> correct mangled symbols in libiberty.
>
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=f91ca6bc00c1e3c70c1d2f4527d4297b76e2eaca#patch18

Oh, I see what I've done. I forgot to update the gdb testsuite to
reflect changes in libiberty's - or just forgot about their existence
in general.

Great, I'll raise a patch to change these tests too them.

Regards
Iain.