From: Iain Buclaw <ibuclaw@gdcproject.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/2] Sync libiberty with gcc upstream
Date: Mon, 29 Jun 2015 16:26:00 -0000 [thread overview]
Message-ID: <CABOHX+daem+M4Cdrp7pcMVwutkC7a7TgOOGtoJs9CrWPomk6-g@mail.gmail.com> (raw)
In-Reply-To: <55916944.1010500@redhat.com>
On 29 June 2015 at 17:50, Pedro Alves <palves@redhat.com> wrote:
> On 06/19/2015 04:24 PM, Iain Buclaw wrote:
>> Second downstream patch with dlang demangling related changes only.
>> Should be a more straightforward read than the other one.
>
> Hi Iain, seems like this unfortunately caused regressions in
> gdb.dlang/demangle.exp. See replies to:
>
> https://sourceware.org/ml/gdb-testers/2015-q2/msg07341.html
>
> I see the same here, e.g., on x86_64 F20:
>
> -PASS: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv
> +FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv
>
> gdb.log shows:
>
> demangle.test.~this()
> (gdb) PASS: gdb.dlang/demangle.exp: _D8demangle4test6__dtorMFZv
> demangle _D8demangle4test6__postblitMFZv
> Can't demangle "_D8demangle4test6__postblitMFZv"
> (gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv
> demangle _D8demangle4testFHAbaZv
>
Interesting, I don't understand where these tests come from.
---
PASS -> FAIL: gdb.dlang/demangle.exp:
_D2rt6dmain211_d_run_mainUiPPaPUAAaZiZi7tryExecMFMDFZvZv
PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle3fnAFZv3fnBMFZv
PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv1S3fnCFZv
PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv1S3fnDMFZv
PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv5localMFZi
PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv
---
All of these *should* fail, and they have been updated to their
correct mangled symbols in libiberty.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=f91ca6bc00c1e3c70c1d2f4527d4297b76e2eaca#patch18
next prev parent reply other threads:[~2015-06-29 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 15:24 Iain Buclaw
2015-06-29 15:50 ` Pedro Alves
2015-06-29 16:26 ` Iain Buclaw [this message]
2015-06-29 16:30 ` Iain Buclaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABOHX+daem+M4Cdrp7pcMVwutkC7a7TgOOGtoJs9CrWPomk6-g@mail.gmail.com \
--to=ibuclaw@gdcproject.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox