From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99654 invoked by alias); 22 Jul 2015 15:48:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99631 invoked by uid 89); 22 Jul 2015 15:48:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f180.google.com Received: from mail-lb0-f180.google.com (HELO mail-lb0-f180.google.com) (209.85.217.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 22 Jul 2015 15:48:36 +0000 Received: by lbbyj8 with SMTP id yj8so139645089lbb.0 for ; Wed, 22 Jul 2015 08:48:33 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.152.180.134 with SMTP id do6mr2903413lac.95.1437580113294; Wed, 22 Jul 2015 08:48:33 -0700 (PDT) Received: by 10.25.87.75 with HTTP; Wed, 22 Jul 2015 08:48:33 -0700 (PDT) In-Reply-To: References: <55AE7520.1010307@adacore.com> <55AE943F.3000009@adacore.com> Date: Wed, 22 Jul 2015 15:48:00 -0000 Message-ID: Subject: Re: [PATCH] Replace the block_found global with explicit data-flow From: Iain Buclaw To: Doug Evans Cc: Pierre-Marie de Rodat , GDB Patches , Pedro Alves Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00615.txt.bz2 On 22 July 2015 at 16:15, Doug Evans wrote: > On Tue, Jul 21, 2015 at 11:49 AM, Pierre-Marie de Rodat > wrote: >> On 07/21/2015 06:36 PM, Pierre-Marie de Rodat wrote: >>> >>> As Pedro suggested on gdb-patches@ (see >>> ), this >>> change makes symbol lookup functions return a structure that includes >>> both the symbol found and the block in which it was found. This makes >>> it possible to get rid of the block_found global variable and thus makes >>> block hunting explicit. >>> >>> I saw no regression on x86_64-linux. Ok for trunk? >> >> >> Ahem=E2=80=A6 here=E2=80=99s the patch=E2=80=A6 :-/ One day I will take = some time to configure git >> send-email... > > Hi. > > Thanks. Others may approve this, but as I've had my hand in all of this = code > more than anyone recently I'd like to review it too. > I'll have time this weekend, fingers crossed. I'm also in the midst of making large changes around this area with the language_d codebase. Depending on what gets in first, one of us will need to rebase our current patches. ;-) Iain