From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94449 invoked by alias); 11 Oct 2015 12:01:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94434 invoked by uid 89); 11 Oct 2015 12:01:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f172.google.com Received: from mail-wi0-f172.google.com (HELO mail-wi0-f172.google.com) (209.85.212.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 11 Oct 2015 12:01:13 +0000 Received: by wiclk2 with SMTP id lk2so119650144wic.1 for ; Sun, 11 Oct 2015 05:01:10 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.114.104 with SMTP id jf8mr27623469wjb.155.1444564870303; Sun, 11 Oct 2015 05:01:10 -0700 (PDT) Received: by 10.27.191.196 with HTTP; Sun, 11 Oct 2015 05:01:10 -0700 (PDT) Date: Sun, 11 Oct 2015 12:01:00 -0000 Message-ID: Subject: [PATCH 2/2] [D] Remove search_parents parameter from d_lookup_symbol_imports From: Iain Buclaw To: GDB Patches Content-Type: multipart/mixed; boundary=001a1130c8a6f336000521d2f799 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00134.txt.bz2 --001a1130c8a6f336000521d2f799 Content-Type: text/plain; charset=UTF-8 Content-length: 447 Whilst looking at part one, a moment of insight came to me and I realized this code is completely nonsensical. For a start, when importing modules, you don't gain access to all parent packages of the given module. To add some confusion, even the comment was wrong. It doesn't even cater for the example given (it's d_lookup_symbol_module that walks up each block scope). I feel embarrassed it didn't come to me before. :-) Regards, Iain. --- --001a1130c8a6f336000521d2f799 Content-Type: text/x-diff; charset=US-ASCII; name="dlang-searchparents.patch" Content-Disposition: attachment; filename="dlang-searchparents.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ifmgm7uk0 Content-length: 3270 Z2RiL0NoYW5nZUxvZzoKCgkqIGQtbmFtZXNwYWNlLmMgKGRfbG9va3VwX3N5 bWJvbF9pbXBvcnRzKTogUmVtb3ZlIGFyZ3VtZW50Cgknc2VhcmNoX3BhcmVu dHMnLiAgQWxsIGNhbGxlcnMgdXBkYXRlZC4KCi0tLQpkaWZmIC0tZ2l0IGEv Z2RiL2QtbmFtZXNwYWNlLmMgYi9nZGIvZC1uYW1lc3BhY2UuYwppbmRleCBk YTVkYTU4Li4xNTI0MDQ3IDEwMDY0NAotLS0gYS9nZGIvZC1uYW1lc3BhY2Uu YworKysgYi9nZGIvZC1uYW1lc3BhY2UuYwpAQCAtMzg4LDMxICszODgsMTUg QEAgcmVzZXRfZGlyZWN0aXZlX3NlYXJjaGVkICh2b2lkICpkYXRhKQogfQog CiAvKiBTZWFyY2ggZm9yIE5BTUUgYnkgYXBwbHlpbmcgYWxsIGltcG9ydCBz dGF0ZW1lbnRzIGJlbG9uZ2luZyB0bwotICAgQkxPQ0sgd2hpY2ggYXJlIGFw cGxpY2FibGUgaW4gU0NPUEUuCi0KLSAgIElmIFNFQVJDSF9QQVJFTlRTIHRo ZSBzZWFyY2ggd2lsbCBpbmNsdWRlIGltcG9ydHMgd2hpY2ggYXJlCi0gICBh cHBsaWNhYmxlIGluIHBhcmVudHMgb2YgU0NPUEUuCi0gICBFeGFtcGxlOgot Ci0gICAgIG1vZHVsZSBBOwotICAgICBpbXBvcnQgWDsKLSAgICAgdm9pZCBC KCkgewotICAgICAgIGltcG9ydCBZOwotICAgICB9Ci0KLSAgIElmIFNDT1BF IGlzICJBLkIiIGFuZCBTRUFSQ0hfUEFSRU5UUyBpcyB0cnVlLCB0aGUgaW1w b3J0cyBvZgotICAgbW9kdWxlcyBYIGFuZCBZIHdpbGwgYmUgY29uc2lkZXJl ZC4gIElmIFNFQVJDSF9QQVJFTlRTIGlzIGZhbHNlCi0gICBvbmx5IHRoZSBp bXBvcnQgb2YgWSBpcyBjb25zaWRlcmVkLiAgKi8KKyAgIEJMT0NLIHdoaWNo IGFyZSBhcHBsaWNhYmxlIGluIFNDT1BFLiAgKi8KIAogc3RhdGljIHN0cnVj dCBibG9ja19zeW1ib2wKIGRfbG9va3VwX3N5bWJvbF9pbXBvcnRzIChjb25z dCBjaGFyICpzY29wZSwgY29uc3QgY2hhciAqbmFtZSwKIAkJCSBjb25zdCBz dHJ1Y3QgYmxvY2sgKmJsb2NrLAotCQkJIGNvbnN0IGRvbWFpbl9lbnVtIGRv bWFpbiwKLQkJCSBjb25zdCBpbnQgc2VhcmNoX3BhcmVudHMpCisJCQkgY29u c3QgZG9tYWluX2VudW0gZG9tYWluKQogewogICBzdHJ1Y3QgdXNpbmdfZGly ZWN0ICpjdXJyZW50OwogICBzdHJ1Y3QgYmxvY2tfc3ltYm9sIHN5bTsKLSAg aW50IGRpcmVjdGl2ZV9tYXRjaDsKICAgc3RydWN0IGNsZWFudXAgKnNlYXJj aGVkX2NsZWFudXA7CiAKICAgLyogRmlyc3QsIHRyeSB0byBmaW5kIHRoZSBz eW1ib2wgaW4gdGhlIGdpdmVuIG1vZHVsZS4gICovCkBAIC00MzAsMTggKzQx NCw5IEBAIGRfbG9va3VwX3N5bWJvbF9pbXBvcnRzIChjb25zdCBjaGFyICpz Y29wZSwgY29uc3QgY2hhciAqbmFtZSwKICAgICAgICBjdXJyZW50ID0gY3Vy cmVudC0+bmV4dCkKICAgICB7CiAgICAgICBjb25zdCBjaGFyICoqZXhjbHVk ZXA7Ci0gICAgICBpbnQgbGVuID0gc3RybGVuIChjdXJyZW50LT5pbXBvcnRf ZGVzdCk7Ci0KLSAgICAgIGRpcmVjdGl2ZV9tYXRjaCA9IChzZWFyY2hfcGFy ZW50cwotCQkJID8gKHN0cm5jbXAgKHNjb3BlLCBjdXJyZW50LT5pbXBvcnRf ZGVzdCwgbGVuKSA9PSAwCi0JCQkgICAgJiYgKGxlbiA9PSAwCi0JCQkJfHwg c2NvcGVbbGVuXSA9PSAnLicKLQkJCQl8fCBzY29wZVtsZW5dID09ICdcMCcp KQotCQkJIDogc3RyY21wIChzY29wZSwgY3VycmVudC0+aW1wb3J0X2Rlc3Qp ID09IDApOwotCi0gICAgICAvKiBJZiB0aGUgaW1wb3J0IGRlc3RpbmF0aW9u IGlzIHRoZSBjdXJyZW50IHNjb3BlIG9yIG9uZSBvZiBpdHMKLQkgYW5jZXN0 b3JzIHRoZW4gaXQgaXMgYXBwbGljYWJsZS4gICovCi0gICAgICBpZiAoZGly ZWN0aXZlX21hdGNoICYmICFjdXJyZW50LT5zZWFyY2hlZCkKKworICAgICAg LyogSWYgdGhlIGltcG9ydCBkZXN0aW5hdGlvbiBpcyB0aGUgY3VycmVudCBz Y29wZSB0aGVuIHNlYXJjaCBpdC4gICovCisgICAgICBpZiAoIWN1cnJlbnQt PnNlYXJjaGVkICYmIHN0cmNtcCAoc2NvcGUsIGN1cnJlbnQtPmltcG9ydF9k ZXN0KSA9PSAwKQogCXsKIAkgIC8qIE1hcmsgdGhpcyBpbXBvcnQgYXMgc2Vh cmNoZWQgc28gdGhhdCB0aGUgcmVjdXJzaXZlIGNhbGwKIAkgICAgIGRvZXMg bm90IHNlYXJjaCBpdCBhZ2Fpbi4gICovCkBAIC01NTQsNyArNTI5LDcgQEAg ZF9sb29rdXBfc3ltYm9sX21vZHVsZSAoY29uc3QgY2hhciAqc2NvcGUsIGNv bnN0IGNoYXIgKm5hbWUsCiAgICAgIGJsb2Nrcy4gICovCiAgIHdoaWxlIChi bG9jayAhPSBOVUxMKQogICAgIHsKLSAgICAgIHN5bSA9IGRfbG9va3VwX3N5 bWJvbF9pbXBvcnRzIChzY29wZSwgbmFtZSwgYmxvY2ssIGRvbWFpbiwgMSk7 CisgICAgICBzeW0gPSBkX2xvb2t1cF9zeW1ib2xfaW1wb3J0cyAoc2NvcGUs IG5hbWUsIGJsb2NrLCBkb21haW4pOwogCiAgICAgICBpZiAoc3ltLnN5bWJv bCAhPSBOVUxMKQogCXJldHVybiBzeW07Cg== --001a1130c8a6f336000521d2f799--