From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92104 invoked by alias); 29 Jun 2015 16:30:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92085 invoked by uid 89); 29 Jun 2015 16:30:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f47.google.com Received: from mail-wg0-f47.google.com (HELO mail-wg0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 29 Jun 2015 16:30:32 +0000 Received: by wguu7 with SMTP id u7so145959633wgu.3 for ; Mon, 29 Jun 2015 09:30:29 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.84.170 with SMTP id a10mr24335741wiz.52.1435595429496; Mon, 29 Jun 2015 09:30:29 -0700 (PDT) Received: by 10.194.104.197 with HTTP; Mon, 29 Jun 2015 09:30:29 -0700 (PDT) In-Reply-To: References: <55916944.1010500@redhat.com> Date: Mon, 29 Jun 2015 16:30:00 -0000 Message-ID: Subject: Re: [PATCH v2 2/2] Sync libiberty with gcc upstream From: Iain Buclaw To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00609.txt.bz2 On 29 June 2015 at 18:26, Iain Buclaw wrote: > On 29 June 2015 at 17:50, Pedro Alves wrote: >> On 06/19/2015 04:24 PM, Iain Buclaw wrote: >>> Second downstream patch with dlang demangling related changes only. >>> Should be a more straightforward read than the other one. >> >> Hi Iain, seems like this unfortunately caused regressions in >> gdb.dlang/demangle.exp. See replies to: >> >> https://sourceware.org/ml/gdb-testers/2015-q2/msg07341.html >> >> I see the same here, e.g., on x86_64 F20: >> >> -PASS: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv >> +FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv >> >> gdb.log shows: >> >> demangle.test.~this() >> (gdb) PASS: gdb.dlang/demangle.exp: _D8demangle4test6__dtorMFZv >> demangle _D8demangle4test6__postblitMFZv >> Can't demangle "_D8demangle4test6__postblitMFZv" >> (gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv >> demangle _D8demangle4testFHAbaZv >> > > Interesting, I don't understand where these tests come from. > > --- > PASS -> FAIL: gdb.dlang/demangle.exp: > _D2rt6dmain211_d_run_mainUiPPaPUAAaZiZi7tryExecMFMDFZvZv > PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle3fnAFZv3fnBMFZv > PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv1S3fnCFZv > PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv1S3fnDMFZv > PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4mainFZv5localMFZi > PASS -> FAIL: gdb.dlang/demangle.exp: _D8demangle4test6__postblitMFZv > --- > > All of these *should* fail, and they have been updated to their > correct mangled symbols in libiberty. > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=f91ca6bc00c1e3c70c1d2f4527d4297b76e2eaca#patch18 Oh, I see what I've done. I forgot to update the gdb testsuite to reflect changes in libiberty's - or just forgot about their existence in general. Great, I'll raise a patch to change these tests too them. Regards Iain.