From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13002 invoked by alias); 13 Aug 2015 11:06:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12988 invoked by uid 89); 13 Aug 2015 11:06:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f170.google.com Received: from mail-wi0-f170.google.com (HELO mail-wi0-f170.google.com) (209.85.212.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 13 Aug 2015 11:06:44 +0000 Received: by wicne3 with SMTP id ne3so254407286wic.1 for ; Thu, 13 Aug 2015 04:06:41 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.192.166 with SMTP id hh6mr74926092wjc.127.1439464001670; Thu, 13 Aug 2015 04:06:41 -0700 (PDT) Received: by 10.27.16.2 with HTTP; Thu, 13 Aug 2015 04:06:41 -0700 (PDT) In-Reply-To: References: Date: Thu, 13 Aug 2015 11:06:00 -0000 Message-ID: Subject: Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules From: Iain Buclaw To: Doug Evans Cc: GDB Patches , Pierre-Marie de Rodat Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00341.txt.bz2 On 13 August 2015 at 06:01, Doug Evans wrote: > Iain Buclaw writes: >> Third times a charm. >> >> Rebased this against master, in particular to make it compatible with >> the recent block_symbol additions. I don't have a GCC-4.1 compiler at >> hand, but I don't think I'm doing anything that may trigger build >> warnings. Pierre, maybe you want to confirm? >> >> I've also gotten round to completing the d-exp expression parser >> rewrite - or at least to a nice stable point. Will be submitting that >> in patch #2. >> >> Regards >> Iain >> >> --- >> >> --- >> 2015-08-03 Iain Buclaw >> >> * Makefile.in (SFILES): Add d-namespace.c. >> (COMMON_OBS): Add d-namespace.o. >> * d-lang.c (d_language_defn): Use d_lookup_symbol_nonlocal as the >> la_lookup_symbol_nonlocal callback function pointer. >> * d-lang.h (d_lookup_symbol_nonlocal): New declaration. >> (d_lookup_nested_symbol): New declaration. >> * d-namespace.c: New file. > > Hi. > LGTM (with the one nit fixed that Pierre-Marie pointed out). Thanks. Will also tweak the includes to use the new namespace.h too. I'll push this and the other in tonight. Regards Iain