From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7553 invoked by alias); 16 Jan 2014 17:03:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7492 invoked by uid 89); 16 Jan 2014 17:03:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f170.google.com Received: from mail-qc0-f170.google.com (HELO mail-qc0-f170.google.com) (209.85.216.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Jan 2014 17:03:54 +0000 Received: by mail-qc0-f170.google.com with SMTP id e9so2609942qcy.1 for ; Thu, 16 Jan 2014 09:03:52 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.29.4 with SMTP id o4mr17703881qac.43.1389891832794; Thu, 16 Jan 2014 09:03:52 -0800 (PST) Received: by 10.229.195.196 with HTTP; Thu, 16 Jan 2014 09:03:52 -0800 (PST) In-Reply-To: <87ha94ngh3.fsf@fleche.redhat.com> References: <871u0h9g41.fsf@fleche.redhat.com> <8738kv7o9y.fsf@fleche.redhat.com> <87ha94ngh3.fsf@fleche.redhat.com> Date: Thu, 16 Jan 2014 17:03:00 -0000 Message-ID: Subject: Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion From: Iain Buclaw To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00622.txt.bz2 On 16 January 2014 14:34, Tom Tromey wrote: >>>>>> "Iain" =3D=3D Iain Buclaw writes: > > Iain> Is there anything else needed to be done from me? Just asking as I > Iain> noticed a change to the way that requires this patch to be updated. > > I wasn't keeping score, but if all the patches are approved, you can > rebase (our git repository rejects merge commits on master), merge to > master, and push. If a patch needs any changes during the rebase, you > can use your judgment -- if it is just a trivial change, post the > updated patch as an FYI; if it required some work, usually another round > of review is needed. > It's just trivial, see the change you did to set_main_name (sorry in advanced for long url link) https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;a=3Dblobdiff;f= =3Dgdb/symtab.c;h=3Da8073b8ef7e8027566949952b9115631e33a5f5f;hp=3D5e988c88e= fceebfbc90192151e57938884ce62ea;hb=3D9e6c82ad4f55d0ff125721b94fa2191f1cc100= 0a;hpb=3D6ef55de768d4ab9065bc92aa00d828212c4af4f0 Regards Iain