Re: [PATCH] Renesas SH (sh4) native support

Joel Brobecker
2011-11-18T15:55:39Z

> I glanced through the patch a little. It had the usual formatting
> issues, and was lacking ChangeLog entries, but otherwise nothing stood
> out for me.

The biggest issue I have besides copyright assignment (from the original
author, right?) is the fact that it hasn't been tested. If we could
involve the author a bit, and ask him to rebase the patch against
HEAD, and test it a bit, at least we could have a little bit of
confidence.

I've also spotted the following:

+#include <sys/ptrace.h>
+#include <sys/types.h>
+#include <sys/param.h>
+#include <sys/user.h>
+#include <sys/syscall.h>
+
+#include <asm/ptrace.h>

which is a big no-no in a -tdep file. Tdep files should be compilable
on any host.

I haven't been able to review the file much beyond that...

--
Joel