Re: [PATCH] Renesas SH (sh4) native support

Nobuhiro Iwamatsu
2011-11-18T21:46:10Z

Hi, all.

Hector, thanks for your work!

2011/11/19 Hector Oron <zumbi@debian.org>:
> Hi Joel,
>
> 2011/11/18 Joel Brobecker <brobecker@adacore.com>:
>
>> The biggest issue I have besides copyright assignment (from the original
>> author, right?) is the fact that it hasn't been tested. If we could
>> involve the author a bit, and ask him to rebase the patch against
>> HEAD, and test it a bit, at least we could have a little bit of
>> confidence.
>
> Surely, before merging the code, it must be built and tested properly.
> The original author was CC, but apparently that email was wrong and it
> was bouncing the email, so I am adding another known address, and see
> if we can add support into main GDB for Renesas SH.
>
> @Yoshii-san, please, look at
> <http://www.cygwin.com/ml/gdb-patches/2011-11/msg00490.html> for
> context.
>
>> I've also spotted the following:
>>
>>    +#include <sys/ptrace.h>
>>    +#include <sys/types.h>
>>    +#include <sys/param.h>
>>    +#include <sys/user.h>
>>    +#include <sys/syscall.h>
>>    +
>>    +#include <asm/ptrace.h>
>>
>> which is a big no-no in a -tdep file. Tdep files should be compilable
>> on any host.
>>
>> I haven't been able to review the file much beyond that...
>
> Thanks for the comments!

Takashi and me will discuss this problem at next week.

Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6