From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19269 invoked by alias); 18 Nov 2011 21:46:10 -0000 Received: (qmail 19258 invoked by uid 22791); 18 Nov 2011 21:46:09 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Nov 2011 21:45:54 +0000 Received: by eye4 with SMTP id 4so4507062eye.0 for ; Fri, 18 Nov 2011 13:45:53 -0800 (PST) Received: by 10.180.0.100 with SMTP id 4mr4840652wid.48.1321652753165; Fri, 18 Nov 2011 13:45:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.93.8 with HTTP; Fri, 18 Nov 2011 13:45:32 -0800 (PST) In-Reply-To: References: <20111117232006.GA22252@enorme.TCLDOMAIN.OFFICE> <20111118155522.GD2703@adacore.com> From: Nobuhiro Iwamatsu Date: Fri, 18 Nov 2011 21:46:00 -0000 Message-ID: Subject: Re: [PATCH] Renesas SH (sh4) native support To: Hector Oron Cc: Joel Brobecker , Tom Tromey , gdb-patches@sourceware.org, takashi.yoshii.zj@renesas.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00512.txt.bz2 Hi, all. Hector, thanks for your work! 2011/11/19 Hector Oron : > Hi Joel, > > 2011/11/18 Joel Brobecker : > >> The biggest issue I have besides copyright assignment (from the original >> author, right?) is the fact that it hasn't been tested. If we could >> involve the author a bit, and ask him to rebase the patch against >> HEAD, and test it a bit, at least we could have a little bit of >> confidence. > > Surely, before merging the code, it must be built and tested properly. > The original author was CC, but apparently that email was wrong and it > was bouncing the email, so I am adding another known address, and see > if we can add support into main GDB for Renesas SH. > > @Yoshii-san, please, look at > for > context. > >> I've also spotted the following: >> >> =A0 =A0+#include >> =A0 =A0+#include >> =A0 =A0+#include >> =A0 =A0+#include >> =A0 =A0+#include >> =A0 =A0+ >> =A0 =A0+#include >> >> which is a big no-no in a -tdep file. Tdep files should be compilable >> on any host. >> >> I haven't been able to review the file much beyond that... > > Thanks for the comments! Takashi and me will discuss this problem at next week. Best regards, Nobuhiro --=20 Nobuhiro Iwamatsu =A0=A0 iwamatsu at {nigauri.org / debian.org} =A0=A0 GPG ID: 40AD1FA6