From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6238 invoked by alias); 21 Jan 2014 19:20:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6228 invoked by uid 89); 21 Jan 2014 19:20:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS,UPPERCASE_50_75 autolearn=ham version=3.3.2 X-HELO: mail-ie0-f171.google.com Received: from mail-ie0-f171.google.com (HELO mail-ie0-f171.google.com) (209.85.223.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 21 Jan 2014 19:20:23 +0000 Received: by mail-ie0-f171.google.com with SMTP id as1so3326402iec.2 for ; Tue, 21 Jan 2014 11:20:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=K5aO0LsuckiMa7MLdfz3FReqB5Aka9kW+SMNls905mU=; b=VSD7QFAvsCjwpUGUvIAF0gsCFIsWboxuuVxsBU/h8qHHKpWfEwXeLfG75xiho+349b vA0QLOxlki/mpDryIVHQ834d0/o9QNRsZkUUeb0y9jpRXTpFBLH1DO5BMpBhGaEd9EkR hOeVLL2FYFoTAkWUVKY8et3+S5VrtjI4iYgL0i59/8rplKLtGbWXoAAlHTUBhFSKhk67 GQu8kTAmgs2ySzZTq+59TdY7sMrxypa75tr5NmOLPmMChNH7Rga+YdL/sEbn0P/j8vUE wZ+2s1DAmLxsTlEoB4COWDyPlchnd7tyPTgXCYuKoODMgMJ9wcl0UlUGTi0+uGjZYiTl 8JVg== X-Gm-Message-State: ALoCoQmH4/HSKSZB6YI8V0w9v92SPj1NzhIDKFJjZIT4eRoCZvGULDdk95bQKblAFCxXYnlsHmcA2MFbfj0D1nS2VH7QcoGqSp+mD53Ksldz8AAWNSGvl0C1XWF7qN8DPYF8wyVwJcyWS4+kU+X+Igb19L2XjfldD01ntl5MBuwyxHcrftbKDVEeFbsoXXqfvDX+K04T23zM1bzNXEgCYP4/Cn9VDqMFjg== X-Received: by 10.43.180.133 with SMTP id pe5mr2098967icc.71.1390332022107; Tue, 21 Jan 2014 11:20:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.148.34 with HTTP; Tue, 21 Jan 2014 11:20:02 -0800 (PST) In-Reply-To: <87y52ej9zm.fsf@fleche.redhat.com> References: <87y52ej9zm.fsf@fleche.redhat.com> From: Roland McGrath Date: Tue, 21 Jan 2014 19:20:00 -0000 Message-ID: Subject: Re: [PATCH] gdb: Support install-strip target To: Tom Tromey Cc: GDB Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-01/txt/msg00813.txt.bz2 On Fri, Jan 17, 2014 at 6:32 PM, Tom Tromey wrote: > My only question is what happens when install -s is run on 'gcore', > which is a shell script; I don't remember if install is smart about this > or not. I think automake defines a separate INSTALL_SCRIPT to handle > this. Good catch. Here's what I've committed. Thanks, Roland gdb/ 2014-01-21 Roland McGrath * configure.ac: Call AM_PROG_INSTALL_STRIP. * configure: Regenerate. * aclocal.m4: Regenerate. * Makefile.in (install_sh, INSTALL_STRIP_PROGRAM, STRIP): New substituted variables. (install-strip): New target. (INSTALL_SCRIPT): New substituted variable. (FLAGS_TO_PASS): Add it. (install-only): Use $(INSTALL_SCRIPT) rather than $(INSTALL_PROGRAM) for gcore. --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -44,6 +44,8 @@ htmldir = @htmldir@ pdfdir = @pdfdir@ includedir = @includedir@ +install_sh = @install_sh@ + # This can be referenced by `LIBINTL' as computed by # ZW_GNU_GETTEXT_SISTER_DIR. top_builddir = . @@ -56,6 +58,8 @@ LN_S = @LN_S@ INSTALL = @INSTALL@ INSTALL_PROGRAM = @INSTALL_PROGRAM@ +INSTALL_SCRIPT = @INSTALL_SCRIPT@ +INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@ INSTALL_DATA = @INSTALL_DATA@ DESTDIR = @@ -66,6 +70,7 @@ RANLIB = @RANLIB@ DLLTOOL = @DLLTOOL@ WINDRES = @WINDRES@ MIG = @MIG@ +STRIP = @STRIP@ XGETTEXT = @XGETTEXT@ GMSGFMT = @GMSGFMT@ @@ -648,6 +653,7 @@ FLAGS_TO_PASS = \ "MAKEHTMLFLAGS=$(MAKEHTMLFLAGS)" \ "INSTALL=$(INSTALL)" \ "INSTALL_PROGRAM=$(INSTALL_PROGRAM)" \ + "INSTALL_SCRIPT=$(INSTALL_SCRIPT)" \ "INSTALL_DATA=$(INSTALL_DATA)" \ "RUNTEST=$(RUNTEST)" \ "RUNTESTFLAGS=$(RUNTESTFLAGS)" @@ -1107,11 +1113,17 @@ install-only: $(CONFIG_INSTALL) true ; \ fi ; \ $(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(bindir) ; \ - $(INSTALL_PROGRAM) gcore \ + $(INSTALL_SCRIPT) gcore \ $(DESTDIR)$(bindir)/$$transformed_name; \ fi @$(MAKE) DO=install "DODIRS=$(SUBDIRS)" $(FLAGS_TO_PASS) subdir_do +install-strip: + $(MAKE) $(FLAGS_TO_PASS) INSTALL_PROGRAM="$(INSTALL_STRIP_PROGRAM)" \ + install_sh_PROGRAM="$(INSTALL_STRIP_PROGRAM)" INSTALL_STRIP_FLAG=-s \ + `test -z '$(STRIP)' || \ + echo "INSTALL_PROGRAM_ENV=STRIPPROG='$(STRIP)'"` install-only + install-python: $(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(GDB_DATADIR)/python/gdb --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -30,6 +30,7 @@ AC_PROG_CC AC_USE_SYSTEM_EXTENSIONS ACX_LARGEFILE AM_PROG_CC_STDC +AM_PROG_INSTALL_STRIP AC_CONFIG_AUX_DIR(..) AC_CANONICAL_SYSTEM