From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22027 invoked by alias); 19 Jan 2015 22:08:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22015 invoked by uid 89); 19 Jan 2015 22:08:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f180.google.com Received: from mail-ob0-f180.google.com (HELO mail-ob0-f180.google.com) (209.85.214.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 19 Jan 2015 22:08:17 +0000 Received: by mail-ob0-f180.google.com with SMTP id uz6so15554355obc.11 for ; Mon, 19 Jan 2015 14:08:16 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.202.54.86 with SMTP id d83mr18605877oia.55.1421705296050; Mon, 19 Jan 2015 14:08:16 -0800 (PST) Received: by 10.182.46.193 with HTTP; Mon, 19 Jan 2015 14:08:16 -0800 (PST) In-Reply-To: <1421217481-18204-1-git-send-email-agentzh@gmail.com> References: <1421217481-18204-1-git-send-email-agentzh@gmail.com> Date: Mon, 19 Jan 2015 22:08:00 -0000 Message-ID: Subject: Re: [PATCH] [python] Optimize python_string_to_host_string() for Python 2. From: "Yichun Zhang (agentzh)" To: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00534.txt.bz2 Hello! On Tue, Jan 13, 2015 at 10:38 PM, Yichun Zhang (agentzh) wrote: > With the following patch, my most complicated Python tools > finally have comparable performance between Python 2 and > Python 3. In the case of Python 2, some real-world Python scripts' > overall speedup can be as big as 34% (for my "lgcpath" command [3]) > or even 57% (for my "lgcstat" command [4]). And from the new Flame > Graph [5], we can see that the corresponding function frames are > indeed gone. > > Comments are welcome! > Does the silence in the last 6 days mean that this patch is completely wrong? Actually I have a few more patches to submit to optimize this gdb/python part even further. The silence here makes me hesitate ;) Please let me know if I'm doing something wrong here. Very much appreciated! Thanks! -agentzh