From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129204 invoked by alias); 29 Nov 2017 10:59:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129190 invoked by uid 89); 29 Nov 2017 10:59:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:1210 X-HELO: mail-it0-f65.google.com Received: from mail-it0-f65.google.com (HELO mail-it0-f65.google.com) (209.85.214.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 10:59:37 +0000 Received: by mail-it0-f65.google.com with SMTP id t1so3497594ite.5 for ; Wed, 29 Nov 2017 02:59:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DDL9S/x3v34rtUs8oqwu6fZD7jvK18SNv2LC1uB2q4U=; b=F/IjlA77qqp1HU3ky0/t1yg0S8UzKmWx4gsI/qnqaoMwXoG5khtW6EJcwMfgKUY+DD 5ZGXNB/mp2HvVtJnCIUM7n8McqA0u1aTQr7U+oF89y1AHk0zUhZbt17EK/vLygUoj2vx Yr99Nzv1OqjasFhUIfJCG7uZMyvxeEAmUjzna3Zm3pS8WxjIavsP8PCwQJmMqL9CREBa CDv4VrvtPVxaW4HrwR138M6cu/fu1i4/Ga15kD68CkJKegIUham5NHbCBPP9DEhNJEY4 fBwRO9qVHnqhEXCQ55xvuyCgG2ek0YYkLJlp8TpyyBsSS52FFmwVNJOp4Gbh/kKJG5cU tpNw== X-Gm-Message-State: AJaThX56qdYMm1yzhSy+13oTFyVoV734Ec+g90xkeluCJReSiTrS2Noe qS4zfeKXncyc/mzL2zE+tvSbf2hUkGoIj6SHu+pDxw== X-Google-Smtp-Source: AGs4zMZ6BWAjYtJ+eZivNe+K48WbDnm26/QPTOsnMK2/lzP1ORpEJri5HcNvKHoi1ekGG1RRCKxDenYc98st8ar7Z8I= X-Received: by 10.36.1.200 with SMTP id 191mr6674521itk.55.1511953175370; Wed, 29 Nov 2017 02:59:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.72.71 with HTTP; Wed, 29 Nov 2017 02:59:34 -0800 (PST) In-Reply-To: <87induo1ey.fsf@redhat.com> References: <20171128132148.31802-1-slp@redhat.com> <20171128132148.31802-2-slp@redhat.com> <87induo1ey.fsf@redhat.com> From: Sergio Lopez Date: Wed, 29 Nov 2017 10:59:00 -0000 Message-ID: Subject: Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-11/txt/msg00760.txt.bz2 On Tue, Nov 28, 2017 at 4:42 PM, Sergio Durigan Junior wrote: > On Tuesday, November 28 2017, Sergio Lopez wrote: >> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c >> index 24237b8d39..5f4a1cdad1 100644 >> --- a/gdb/linux-tdep.c >> +++ b/gdb/linux-tdep.c >> @@ -93,6 +93,11 @@ struct smaps_vmflags >> >> static int use_coredump_filter = 1; >> >> +/* Whether to honor the VM_DONTDUMP flag in /proc/PID/smaps when >> + generating a corefile. */ >> + >> +static int honor_dontdump_flag = 1; > > No empty line between command and definition of variable. This is the only suggestion that I haven't applied because it would break the coding style of the previous lines: gdb/linux-tdep.c: 89 }; 90 91 /* Whether to take the /proc/PID/coredump_filter into account when 92 generating a corefile. */ 93 94 static int use_coredump_filter = 1; 95 96 /* Whether the value of smaps_vmflags->exclude_coredump should be 97 ignored, including mappings marked with the VM_DONTDUMP flag in 98 the dump. */ 99 100 static int dump_excluded_mappings = 0; 101 102 /* This enum represents the signals' numbers on a generic architecture -- Sergio