From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11083 invoked by alias); 9 Nov 2013 19:48:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11070 invoked by uid 89); 9 Nov 2013 19:48:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.9 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-wi0-f169.google.com Received: from Unknown (HELO mail-wi0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 09 Nov 2013 19:48:02 +0000 Received: by mail-wi0-f169.google.com with SMTP id cb5so974293wib.2 for ; Sat, 09 Nov 2013 11:47:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=fP0tYRXSN/oH9nku+XIF8n1yaGMqZFNzGo3qwdKoAkc=; b=MUuF/yysCIVBjbmlBIgEi7RBuFIbIhnXdFj1i5xyt197YAAqPSyCdZ14rY6bl4Tp3p djeeKyoxSx1anRryO4tQiaXhRsQ/gSdSTZWeunVVUHNgSO8Ms5gFuV7mErpUT+/iCizK WpH89avee0XUWVe5/G5/HgNwu2zGcRrSRYol+X9qE731w9kB76mHFJYzqKEx9AjYBb31 Nx20QVzO5I2ce7c1E6ozI6axOKyPBaKpWGLiXgQYlY3Bv9Crm+KoQMaQqDiLhrC7Bupq zAC7NK3uAayf03ME0mT5FJ6wdCD/7fb5VghCXXcaf95C3CL3GWekYBdxGWLZ2kgx+s0X d7wQ== X-Gm-Message-State: ALoCoQkTpteBWT0seGSwzG1l5r9XRzLQcKQn7dGOWu+05IASAktwdYU7NimeNFlGrnRWBeHFo0kI MIME-Version: 1.0 X-Received: by 10.194.216.225 with SMTP id ot1mr897wjc.80.1384026473276; Sat, 09 Nov 2013 11:47:53 -0800 (PST) Received: by 10.216.73.198 with HTTP; Sat, 9 Nov 2013 11:47:53 -0800 (PST) In-Reply-To: References: <527AB482.80600@earthlink.net> <87ppqd1a0t.fsf@fleche.redhat.com> <87r4asz3be.fsf@fleche.redhat.com> Date: Sat, 09 Nov 2013 19:50:00 -0000 Message-ID: Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c From: Doug Evans To: Tom Tromey Cc: Stan Shebs , gdb-patches@sourceware.org, xdje42@gmail.com Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-11/txt/msg00259.txt.bz2 On Thu, Nov 7, 2013 at 8:40 AM, Doug Evans wrote: > On Thu, Nov 7, 2013 at 6:36 AM, Tom Tromey wrote: >>>>>>> "Doug" == Doug Evans writes: >> >> Doug> Tom Tromey writes: >> Stan> +/* A helper function for tyscm_richcompare that checks two types for >> Stan> + "deep" equality. Returns non-zero if the types are considered the >> Stan> + same, zero otherwise. */ >>>> >> Stan> "tyscm_richcompare"? Should that be typy_... ? >>>> >>>> It would be helpful if Doug could list all the change he made when >>>> moving the code. >> >> Doug> I don't understand. >> Doug> Which changes? While useful beyond its present state, this is in >> Doug> essence just a cleanup. >> >> I had thought this patch was more or less a straight move of the code. >> But Stan's note revealed a change from what is currently in the tree. >> So the question is, can you say what else changed? >> That would be handy so I don't have to go over it line-by-line myself. > > Ah. Except for the comment (*1) the only substantive change is in the result: > Py_{NE,EQ} -> 0.1. > > (*1): Early on I made a copy because I wasn't sure how things would end up, > and left in a FIXME to remind myself to revisit. > I revisited and realized there's no need for the copy, but missed the > comment. Blech. > "diff -b before after" shows nothing of note to me. Here's v2 of the patch. I fixed the comment and added an assert to check type1,type2 != NULL. I changed the email address in the ChangeLog entry 'cus I'm having problems with this domain. After this email hopefully the switchover is complete.