From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eBoQA38va1+xIAAAWB0awg (envelope-from ) for ; Wed, 23 Sep 2020 07:20:31 -0400 Received: by simark.ca (Postfix, from userid 112) id EFE7E1EDF4; Wed, 23 Sep 2020 07:20:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9BCC71E790 for ; Wed, 23 Sep 2020 07:20:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 338D03851C2E; Wed, 23 Sep 2020 11:20:23 +0000 (GMT) Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by sourceware.org (Postfix) with ESMTPS id 00AE33857036 for ; Wed, 23 Sep 2020 11:20:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 00AE33857036 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=undo.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=grees@undo.io Received: by mail-ot1-x343.google.com with SMTP id n61so18568063ota.10 for ; Wed, 23 Sep 2020 04:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undo-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AWOhbuwCtgt9n7fRaQPxOXq4v7xgM0PEloJRUbS/EDM=; b=YAhpvCq2r/naXRZosXmVI0/t8ndeB3MOP7vJ9URMhJxWWm4j27O6PT6YSCksrjCnbe jEdcQ39K6o03s9XZ6IjTL5Vt/J/kmOl/50Or6FK6S7DFLDli2LepZEwC0R4qB2Q21HYs QtnHFnLDqaphKs/+CG2f6vmVRCgeytcIVr83mJi0jpZP590wNpGT/DdxQmjLNQjabfIW Ok7GogcQ4uWf0WcVuEa/zWmgLIh3BBzo757BJtb11Y9wjXw5uKXaH9XQIPPH+TI85Yz2 oXEGBf8YaKzvEEAsDIntiuaKGv5VraU1iN46S5qpsrCChky8STmhkId1nSS1LyYqd7kO GA5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AWOhbuwCtgt9n7fRaQPxOXq4v7xgM0PEloJRUbS/EDM=; b=EoemfsANLX7j8YBO/jn5ZxPaSlcLESCS6v34KRDPgAcQ+2aGPeOq3nTjEfoUj51/jo blqQSjqavLRfWc8rah7vZzoDFAkVWKoBedQdwgGcfAGUtEFx+vAP+J6NQmUBr1X1XKbZ PG03b4qMSMKyStndOKwX6W2r5DAhK8aKTSV9QDR8wfldJD/E5FLttdakqtc+KIx4Ldvx TCJeSQiVgowbtZ16OOYXn+2MgwJu0HuCvsczJtwI/vdcQcvxA+9zzcqBC6gZsTIuGGzH BJO7eXNJy/eCz+ZdJA5JiCoJbqCeYX3m+7B52AOhOkEAktbRwwRACJZD7Ewlv4RP57eO 27bg== X-Gm-Message-State: AOAM531k6VpIs6MWsQzooxbkSz97QdoXpyKPFQhTGNZPMnjkJFUS/k4I IUdkWq5FOxVHfyBTU4hUifLQFukcwN7pGjtpX+b8+5kyNqs= X-Google-Smtp-Source: ABdhPJxRllQDDTu51r58yQBsJpxC8kgMLFIJTeerwCOxpCBAY8Fmjv5ujQZEdSvvSOf1liRdYetceNbvf1OU+rrdsnw= X-Received: by 2002:a9d:a01:: with SMTP id 1mr5450191otg.43.1600860017488; Wed, 23 Sep 2020 04:20:17 -0700 (PDT) MIME-Version: 1.0 References: <20200922102343.8440-1-grees@undo.io> <20200922135157.GH1540618@embecosm.com> In-Reply-To: From: Gareth Rees Date: Wed, 23 Sep 2020 12:20:06 +0100 Message-ID: Subject: Re: [PATCH] gdb: Fix from_tty argument to gdb.execute in Python. To: Andrew Burgess Content-Type: multipart/mixed; boundary="000000000000adb14705aff94455" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --000000000000adb14705aff94455 Content-Type: text/plain; charset="UTF-8" Here's the updated patch with just the instream change. --000000000000adb14705aff94455 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gdb-Fix-from_tty-argument-to-gdb.execute-in-Python.patch" Content-Disposition: attachment; filename="0001-gdb-Fix-from_tty-argument-to-gdb.execute-in-Python.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kffapgiw0 RnJvbSA5MmRiOGY3OWVlMGRiZmFhZjY4OTIxMGE0NjU2NTEzYTU1YTgyZDY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYXJldGggUmVlcyA8Z3JlZXNAdW5kby5pbz4KRGF0ZTogVHVl LCA4IFNlcCAyMDIwIDE1OjUyOjQ0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gZ2RiOiBGaXggZnJv bV90dHkgYXJndW1lbnQgdG8gZ2RiLmV4ZWN1dGUgaW4gUHl0aG9uLgoKUHJpb3IgdG8gY29tbWl0 IDU2YmNkYmVhMmIsIHRoZSBmcm9tX3R0eSBrZXl3b3JkIGFyZ3VtZW50IHRvIHRoZQpQeXRob24g ZnVuY3Rpb24gZ2RiLmV4ZWN1dGUgY29udHJvbGxlZCB3aGV0aGVyIHRoZSBjb21tYW5kIHRvb2sg aW5wdXQKZnJvbSB0aGUgdGVybWluYWwuIFdoZW4gZnJvbV90dHk9VHJ1ZSwgInN0YXJ0aSIgYW5k IHNpbWlsYXIgY29tbWFuZHMKcHJvbXB0ZWQgdGhlIHVzZXI6CgogICAgKGdkYikgcHl0aG9uIGdk Yi5leGVjdXRlKCJzdGFydGkiLCBmcm9tX3R0eT1UcnVlKQogICAgVGhlIHByb2dyYW0gYmVpbmcg ZGVidWdnZWQgaGFzIGJlZW4gc3RhcnRlZCBhbHJlYWR5LgogICAgU3RhcnQgaXQgZnJvbSB0aGUg YmVnaW5uaW5nPyAoeSBvciBuKSB5CiAgICBTdGFydGluZyBwcm9ncmFtOiAvYmluL3RydWUKCiAg ICBQcm9ncmFtIHN0b3BwZWQuCgpXaGVuIGZyb21fdHR5PUZhbHNlLCB0aGVzZSBjb21tYW5kcyBk aWQgbm90IHByb21wdCB0aGUgdXNlciwgYW5kICJ5ZXMiCndhcyBhc3N1bWVkOgoKICAgIChnZGIp IHB5dGhvbiBnZGIuZXhlY3V0ZSgic3RhcnRpIiwgZnJvbV90dHk9RmFsc2UpCgogICAgUHJvZ3Jh bSBzdG9wcGVkLgoKSG93ZXZlciwgYWZ0ZXIgY29tbWl0IDU2YmNkYmVhMmIsIHRoZSBmcm9tX3R0 eSBrZXl3b3JkIGFyZ3VtZW50IG5vCmxvbmdlciBoYWQgdGhpcyBlZmZlY3QuIEZvciBleGFtcGxl LCBhcyBvZiBjb21taXQgN2FkZTdmYmE3NToKCiAgICAoZ2RiKSBweXRob24gZ2RiLmV4ZWN1dGUo InN0YXJ0aSIsIGZyb21fdHR5PVRydWUpCiAgICBUaGUgcHJvZ3JhbSBiZWluZyBkZWJ1Z2dlZCBo YXMgYmVlbiBzdGFydGVkIGFscmVhZHkuCiAgICBTdGFydCBpdCBmcm9tIHRoZSBiZWdpbm5pbmc/ ICh5IG9yIG4pIFthbnN3ZXJlZCBZOyBpbnB1dCBub3QgZnJvbSB0ZXJtaW5hbF0KICAgIFN0YXJ0 aW5nIHByb2dyYW06IC9iaW4vdHJ1ZQoKICAgIFByb2dyYW0gc3RvcHBlZC4KCk5vdGUgdGhlICJb YW5zd2VyZWQgWTsgaW5wdXQgbm90IGZyb20gdGVybWluYWxdIiBpbiB0aGUgb3V0cHV0IGV2ZW4K dGhvdWdoIGZyb21fdHR5PVRydWUgd2FzIHJlcXVlc3RlZC4KCkxvb2tpbmcgYXQgY29tbWl0IDU2 YmNkYmVhMmIsIGl0IHNlZW1zIHRoYXQgdGhlIGJlaGF2aW91ciBvZiB0aGUKZnJvbV90dHkgYXJn dW1lbnQgd2FzIGNoYW5nZWQgYWNjaWRlbnRhbGx5LiBUaGUgY29tbWl0IG1lc3NhZ2Ugc2FpZDoK CiAgICBMZXQgZ2RiLmV4ZWN1dGUgaGFuZGxlIG11bHRpLWxpbmUgY29tbWFuZHMKCiAgICBUaGlz IGNoYW5nZXMgdGhlIFB5dGhvbiBBUEkgc28gdGhhdCBnZGIuZXhlY3V0ZSBjYW4gbm93IGhhbmRs ZQogICAgbXVsdGktbGluZSBjb21tYW5kcywgbGlrZSAiY29tbWFuZHMiIG9yICJkZWZpbmUiLgoK YW5kIHRoZXJlIHdhcyBubyBtZW50aW9uIG9mIGNoYW5naW5nIHRoZSBlZmZlY3Qgb2YgdGhlIGZy b21fdHR5CmFyZ3VtZW50LiBJdCBsb29rcyBhcyB0aG91Z2ggdGhlIGNvZGUgZm9yIHNldHRpbmcg dGhlIGluc3RyZWFtIHRvIDAKd2FzIGFjY2lkZW50YWxseSBtb3ZlZCBmcm9tIGV4ZWN1dGVfdXNl cl9jb21tYW5kKCkgdG8KZXhlY3V0ZV9jb250cm9sX2NvbW1hbmRzKCkgYWxvbmcgd2l0aCB0aGUg b3RoZXIgc2NvcGVkIHJlc3RvcmVzLgoKQWNjb3JkaW5nbHksIHRoZSBzaW1wbGVzdCB3YXkgdG8g Zml4IHRoaXMgaXMgdG8gcGFydGlhbGx5IHJldmVyc2UKY29tbWl0IDU2YmNkYmVhMmIgYnkgbW92 aW5nIHRoZSBjb2RlIGZvciBzZXR0aW5nIHRoZSBpbnN0cmVhbSB0byAwCmJhY2sgdG8gZXhlY3V0 ZV91c2VyX2NvbW1hbmQoKSB3aGVyZSBpdCB3YXMgdG8gYmVnaW4gd2l0aC4KCkFkZGl0aW9uYWxs eSwgYWRkIGEgdGVzdCBjYXNlIHRvIHJlZHVjZSB0aGUgcmlzayBvZiBzaW1pbGFyIGJyZWFrYWdl CmluIGZ1dHVyZS4KCmdkYi9DaGFuZ2VMb2c6CgoJKiBjbGkvY2xpLXNjcmlwdC5jIChleGVjdXRl X2NvbnRyb2xfY29tbWFuZHMpOiBkb24ndCBzZXQKICAgICAgICBpbnN0cmVhbSB0byAwIGhlcmUg YXMgdGhpcyBicmVha3MgdGhlIGZyb21fdHR5IGFyZ3VtZW50IHRvCiAgICAgICAgZ2RiLmV4ZWN1 dGUgaW4gUHl0aG9uLgogICAgICAgIChleGVjdXRlX3VzZXJfY29tbWFuZCk6IHNldCBpbnN0cmVh bSB0byAwIGhlcmUgaW5zdGVhZC4KCmdkYi90ZXN0c3VpdGUvQ2hhbmdlTG9nOgoKCSogZ2RiLnB5 dGhvbi9weXRob24uZXhwOiBhZGQgdGVzdCBjYXNlcyBmb3IgdGhlIGZyb21fdHR5CiAgICAgICAg YXJndW1lbnQgdG8gZ2RiLmV4ZWN1dGUuCi0tLQogZ2RiL2NsaS9jbGktc2NyaXB0LmMgICAgICAg ICAgICAgICAgfCAgOSArKysrKy0tLS0KIGdkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weXRob24u ZXhwIHwgMTMgKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCsp LCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dkYi9jbGkvY2xpLXNjcmlwdC5jIGIvZ2Ri L2NsaS9jbGktc2NyaXB0LmMKaW5kZXggZGE0YTQxMDIzYS4uOTc1NDFmY2NhMyAxMDA2NDQKLS0t IGEvZ2RiL2NsaS9jbGktc2NyaXB0LmMKKysrIGIvZ2RiL2NsaS9jbGktc2NyaXB0LmMKQEAgLTM5 MiwxMCArMzkyLDYgQEAgZXhlY3V0ZV9jbWRfcG9zdF9ob29rIChzdHJ1Y3QgY21kX2xpc3RfZWxl bWVudCAqYykKIHZvaWQKIGV4ZWN1dGVfY29udHJvbF9jb21tYW5kcyAoc3RydWN0IGNvbW1hbmRf bGluZSAqY21kbGluZXMsIGludCBmcm9tX3R0eSkKIHsKLSAgLyogU2V0IHRoZSBpbnN0cmVhbSB0 byAwLCBpbmRpY2F0aW5nIGV4ZWN1dGlvbiBvZiBhCi0gICAgIHVzZXItZGVmaW5lZCBmdW5jdGlv bi4gICovCi0gIHNjb3BlZF9yZXN0b3JlIHJlc3RvcmVfaW5zdHJlYW0KLSAgICA9IG1ha2Vfc2Nv cGVkX3Jlc3RvcmUgKCZjdXJyZW50X3VpLT5pbnN0cmVhbSwgbnVsbHB0cik7CiAgIHNjb3BlZF9y ZXN0b3JlIHNhdmVfYXN5bmMgPSBtYWtlX3Njb3BlZF9yZXN0b3JlICgmY3VycmVudF91aS0+YXN5 bmMsIDApOwogICBzY29wZWRfcmVzdG9yZSBzYXZlX25lc3RpbmcKICAgICA9IG1ha2Vfc2NvcGVk X3Jlc3RvcmUgKCZjb21tYW5kX25lc3RfZGVwdGgsIGNvbW1hbmRfbmVzdF9kZXB0aCArIDEpOwpA QCAtNDY0LDYgKzQ2MCwxMSBAQCBleGVjdXRlX3VzZXJfY29tbWFuZCAoc3RydWN0IGNtZF9saXN0 X2VsZW1lbnQgKmMsIGNvbnN0IGNoYXIgKmFyZ3MpCiAgIGlmICh1c2VyX2FyZ3Nfc3RhY2suc2l6 ZSAoKSA+IG1heF91c2VyX2NhbGxfZGVwdGgpCiAgICAgZXJyb3IgKF8oIk1heCB1c2VyIGNhbGwg ZGVwdGggZXhjZWVkZWQgLS0gY29tbWFuZCBhYm9ydGVkLiIpKTsKIAorICAvKiBTZXQgdGhlIGlu c3RyZWFtIHRvIDAsIGluZGljYXRpbmcgZXhlY3V0aW9uIG9mIGEKKyAgICAgdXNlci1kZWZpbmVk IGZ1bmN0aW9uLiAgKi8KKyAgc2NvcGVkX3Jlc3RvcmUgcmVzdG9yZV9pbnN0cmVhbQorICAgID0g bWFrZV9zY29wZWRfcmVzdG9yZSAoJmN1cnJlbnRfdWktPmluc3RyZWFtLCBudWxscHRyKTsKKwog ICBleGVjdXRlX2NvbnRyb2xfY29tbWFuZHMgKGNtZGxpbmVzLCAwKTsKIH0KIApkaWZmIC0tZ2l0 IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5dGhvbi5leHAgYi9nZGIvdGVzdHN1aXRlL2dk Yi5weXRob24vcHl0aG9uLmV4cAppbmRleCBhMDMxZWE1YTE4Li4wMTdmMzNhZmU1IDEwMDY0NAot LS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHl0aG9uLmV4cAorKysgYi9nZGIvdGVzdHN1 aXRlL2dkYi5weXRob24vcHl0aG9uLmV4cApAQCAtNTI2LDMgKzUyNiwxNiBAQCBnZGJfdGVzdCAi cHJpbnQgXCRjdmFyMyIgIj0gdm9pZCIgXAogIyBUZXN0IFBSIDIzNjY5LCB0aGUgZm9sbG93aW5n IHdvdWxkIGludm9rZSB0aGUgImNvbW1hbmRzIiBjb21tYW5kIGluc3RlYWQgb2YKICMgInNob3cg Y29tbWFuZHMiLgogZ2RiX3Rlc3QgInB5dGhvbiBnZGIuZXhlY3V0ZShcInNob3cgY29tbWFuZHNc IikiICIkZGVjaW1hbCAgcHJpbnQgXFxcJGN2YXIzLioiCisKKyMgVGVzdCB0aGF0IHRoZSBmcm9t X3R0eSBhcmd1bWVudCB0byBnZGIuZXhlY3V0ZSBpcyBlZmZlY3RpdmUuIElmCisjIEZhbHNlLCB0 aGUgdXNlciBpcyBub3QgcHJvbXB0ZWQgZm9yIGRlY2lzaW9ucyBzdWNoIGFzIHJlc3RhcnRpbmcg dGhlCisjIHByb2dyYW0sIGFuZCAieWVzIiBpcyBhc3N1bWVkLiBJZiBUcnVlLCB0aGUgdXNlciBp cyBwcm9tcHRlZC4KK2dkYl90ZXN0ICJweXRob24gZ2RiLmV4ZWN1dGUoJ3N0YXJ0aScsIGZyb21f dHR5PUZhbHNlKSIgXAorICAgICJQcm9ncmFtIHN0b3BwZWQuKiIgXAorICAgICJzdGFydGkgdmlh IGdkYi5leGVjdXRlLCBub3QgZnJvbSB0dHkiCitnZGJfdGVzdF9tdWx0aXBsZSAicHl0aG9uIGdk Yi5leGVjdXRlKCdzdGFydGknLCBmcm9tX3R0eT1UcnVlKSIgXAorICAgICJzdGFydGkgdmlhIGdk Yi5leGVjdXRlLCBmcm9tIHR0eSIgeworICAgIC1yZSB7VGhlIHByb2dyYW0gYmVpbmcgZGVidWdn ZWQgaGFzIGJlZW4gc3RhcnRlZCBhbHJlYWR5XC5cclxuU3RhcnQgaXQgZnJvbSB0aGUgYmVnaW5u aW5nXD8gXCh5IG9yIG5cKSAkfSB7CisJZ2RiX3Rlc3QgInkiICJTdGFydGluZyBwcm9ncmFtOi4q IiAic3RhcnRpIHZpYSBpbnRlcmFjdGl2ZSBpbnB1dCIKKyAgICB9Cit9Ci0tIAoyLjI2LjAKCg== --000000000000adb14705aff94455--