From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Kgu4OSCAbF9OegAAWB0awg (envelope-from ) for ; Thu, 24 Sep 2020 07:16:48 -0400 Received: by simark.ca (Postfix, from userid 112) id D75F21EE05; Thu, 24 Sep 2020 07:16:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 92F271E509 for ; Thu, 24 Sep 2020 07:16:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5250F3857033; Thu, 24 Sep 2020 11:16:46 +0000 (GMT) Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by sourceware.org (Postfix) with ESMTPS id D34893857800 for ; Thu, 24 Sep 2020 11:16:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D34893857800 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=undo.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=grees@undo.io Received: by mail-oi1-x241.google.com with SMTP id u126so3194162oif.13 for ; Thu, 24 Sep 2020 04:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undo-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kAFRm/EaeJqzVSIrtH0wLC3zR9GX1tlAekWIyMheoI8=; b=jCsIqVk4YOCJczaQnuv9c+ZnqdOmi2nRjQZ5d2eA20K3Ku3JSwOMjro2zeUG7Ap2uT qAnUw4FnLOksplxTG+3F1W22D6Qhf593R8TrgO8kF1Hqk772gWMewxrEAWWat2ITqxmk U9RTq1D1biF59x8PwSpM6gW+mQdOOQmpcvmOECa3AWTvSIyYeONJUu6wwhO70NYCK172 8BgUBiKlJQFn+hMJpVa0ZNBYNWUYlnk7Y9Pc8qYEQknTr80MlaLPvbblAFdZ9yiOPHz2 huiSljNTW18R174CSt1KyGRmBB3RxDh/HikStfx1XmAXie6LAX78z4/CPsj/OT5P9xLo ZELQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kAFRm/EaeJqzVSIrtH0wLC3zR9GX1tlAekWIyMheoI8=; b=cFzwdZbdWgPEf3h/RE8ngwEXWd1WUjhvyRxchVUHugUkoq17qksw9Ay+i448i9WPuP 9YANPRbukZSC2LCTpjQXQ1uWpPPh+OlY8OMffNzqqQ/zbd85+nVmOfcUm/f5LRvjR8pL luEdXG5u0BxFeHGQLhMH7lx4kWSDwTyerL68F9/bm0xc2miHHRyK6Ny6uAH+J8aCdJ4h lOtvFYGllIfQ+KGrtKvrAj35sAvJcCNAxfVk95k95g1A14wS3lP/Zn66LGDhQrK2OjaP btAr1i355qVvdNFaAWN6bA6qcC7BbqCzckLq9e+Xa9Lv8X031JiRHALYPJNSkHgi1/Es uuIg== X-Gm-Message-State: AOAM53307DL+sqj2FfumUYQdTr8OWim4CQJogGc3cnkVCo/Ea6gnt2ER iEAkZjRbSHI/CgaQVf2DD/tfWuQhaClUGBwkK8rM7S04SuE= X-Google-Smtp-Source: ABdhPJxNMNKjR79DWXzwZbe+ea7CwR/AW4otG6IavQfNYVJFgn86labUmWfAQR0PqMzhomk9llwTo5Ale8MMUt0tgRk= X-Received: by 2002:aca:b4c4:: with SMTP id d187mr2229067oif.21.1600946203280; Thu, 24 Sep 2020 04:16:43 -0700 (PDT) MIME-Version: 1.0 References: <20200922102343.8440-1-grees@undo.io> <20200922135157.GH1540618@embecosm.com> <20200924110912.GK1540618@embecosm.com> In-Reply-To: <20200924110912.GK1540618@embecosm.com> From: Gareth Rees Date: Thu, 24 Sep 2020 12:16:32 +0100 Message-ID: Subject: Re: [PATCH] gdb: Fix from_tty argument to gdb.execute in Python. To: Andrew Burgess Content-Type: multipart/mixed; boundary="000000000000c0848e05b00d5586" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" --000000000000c0848e05b00d5586 Content-Type: text/plain; charset="UTF-8" Here's a patch with a comment and commit message updated to use "nullptr" instead of "0". --000000000000c0848e05b00d5586 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gdb-Fix-from_tty-argument-to-gdb.execute-in-Python.patch" Content-Disposition: attachment; filename="0001-gdb-Fix-from_tty-argument-to-gdb.execute-in-Python.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kfgq0tbu0 RnJvbSA3ZWZhYTM2NTdjOGI3MmMxMjg2NzViMjdhMmNiMmYyMWUyZTA1YjE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYXJldGggUmVlcyA8Z3JlZXNAdW5kby5pbz4KRGF0ZTogVHVl LCA4IFNlcCAyMDIwIDE1OjUyOjQ0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gZ2RiOiBGaXggZnJv bV90dHkgYXJndW1lbnQgdG8gZ2RiLmV4ZWN1dGUgaW4gUHl0aG9uLgoKUHJpb3IgdG8gY29tbWl0 IDU2YmNkYmVhMmIsIHRoZSBmcm9tX3R0eSBrZXl3b3JkIGFyZ3VtZW50IHRvIHRoZQpQeXRob24g ZnVuY3Rpb24gZ2RiLmV4ZWN1dGUgY29udHJvbGxlZCB3aGV0aGVyIHRoZSBjb21tYW5kIHRvb2sg aW5wdXQKZnJvbSB0aGUgdGVybWluYWwuIFdoZW4gZnJvbV90dHk9VHJ1ZSwgInN0YXJ0aSIgYW5k IHNpbWlsYXIgY29tbWFuZHMKcHJvbXB0ZWQgdGhlIHVzZXI6CgogICAgKGdkYikgcHl0aG9uIGdk Yi5leGVjdXRlKCJzdGFydGkiLCBmcm9tX3R0eT1UcnVlKQogICAgVGhlIHByb2dyYW0gYmVpbmcg ZGVidWdnZWQgaGFzIGJlZW4gc3RhcnRlZCBhbHJlYWR5LgogICAgU3RhcnQgaXQgZnJvbSB0aGUg YmVnaW5uaW5nPyAoeSBvciBuKSB5CiAgICBTdGFydGluZyBwcm9ncmFtOiAvYmluL3RydWUKCiAg ICBQcm9ncmFtIHN0b3BwZWQuCgpXaGVuIGZyb21fdHR5PUZhbHNlLCB0aGVzZSBjb21tYW5kcyBk aWQgbm90IHByb21wdCB0aGUgdXNlciwgYW5kICJ5ZXMiCndhcyBhc3N1bWVkOgoKICAgIChnZGIp IHB5dGhvbiBnZGIuZXhlY3V0ZSgic3RhcnRpIiwgZnJvbV90dHk9RmFsc2UpCgogICAgUHJvZ3Jh bSBzdG9wcGVkLgoKSG93ZXZlciwgYWZ0ZXIgY29tbWl0IDU2YmNkYmVhMmIsIHRoZSBmcm9tX3R0 eSBrZXl3b3JkIGFyZ3VtZW50IG5vCmxvbmdlciBoYWQgdGhpcyBlZmZlY3QuIEZvciBleGFtcGxl LCBhcyBvZiBjb21taXQgN2FkZTdmYmE3NToKCiAgICAoZ2RiKSBweXRob24gZ2RiLmV4ZWN1dGUo InN0YXJ0aSIsIGZyb21fdHR5PVRydWUpCiAgICBUaGUgcHJvZ3JhbSBiZWluZyBkZWJ1Z2dlZCBo YXMgYmVlbiBzdGFydGVkIGFscmVhZHkuCiAgICBTdGFydCBpdCBmcm9tIHRoZSBiZWdpbm5pbmc/ ICh5IG9yIG4pIFthbnN3ZXJlZCBZOyBpbnB1dCBub3QgZnJvbSB0ZXJtaW5hbF0KICAgIFN0YXJ0 aW5nIHByb2dyYW06IC9iaW4vdHJ1ZQoKICAgIFByb2dyYW0gc3RvcHBlZC4KCk5vdGUgdGhlICJb YW5zd2VyZWQgWTsgaW5wdXQgbm90IGZyb20gdGVybWluYWxdIiBpbiB0aGUgb3V0cHV0IGV2ZW4K dGhvdWdoIGZyb21fdHR5PVRydWUgd2FzIHJlcXVlc3RlZC4KCkxvb2tpbmcgYXQgY29tbWl0IDU2 YmNkYmVhMmIsIGl0IHNlZW1zIHRoYXQgdGhlIGJlaGF2aW91ciBvZiB0aGUKZnJvbV90dHkgYXJn dW1lbnQgd2FzIGNoYW5nZWQgYWNjaWRlbnRhbGx5LiBUaGUgY29tbWl0IG1lc3NhZ2Ugc2FpZDoK CiAgICBMZXQgZ2RiLmV4ZWN1dGUgaGFuZGxlIG11bHRpLWxpbmUgY29tbWFuZHMKCiAgICBUaGlz IGNoYW5nZXMgdGhlIFB5dGhvbiBBUEkgc28gdGhhdCBnZGIuZXhlY3V0ZSBjYW4gbm93IGhhbmRs ZQogICAgbXVsdGktbGluZSBjb21tYW5kcywgbGlrZSAiY29tbWFuZHMiIG9yICJkZWZpbmUiLgoK YW5kIHRoZXJlIHdhcyBubyBtZW50aW9uIG9mIGNoYW5naW5nIHRoZSBlZmZlY3Qgb2YgdGhlIGZy b21fdHR5CmFyZ3VtZW50LiBJdCBsb29rcyBhcyB0aG91Z2ggdGhlIGNvZGUgZm9yIHNldHRpbmcg dGhlIGluc3RyZWFtIHRvCm51bGxwdHIgd2FzIGFjY2lkZW50YWxseSBtb3ZlZCBmcm9tIGV4ZWN1 dGVfdXNlcl9jb21tYW5kKCkgdG8KZXhlY3V0ZV9jb250cm9sX2NvbW1hbmRzKCkgYWxvbmcgd2l0 aCB0aGUgb3RoZXIgc2NvcGVkIHJlc3RvcmVzLgoKQWNjb3JkaW5nbHksIHRoZSBzaW1wbGVzdCB3 YXkgdG8gZml4IHRoaXMgaXMgdG8gcGFydGlhbGx5IHJldmVyc2UKY29tbWl0IDU2YmNkYmVhMmIg YnkgbW92aW5nIHRoZSBjb2RlIGZvciBzZXR0aW5nIHRoZSBpbnN0cmVhbSB0bwpudWxscHRyIGJh Y2sgdG8gZXhlY3V0ZV91c2VyX2NvbW1hbmQoKSB3aGVyZSBpdCB3YXMgdG8gYmVnaW4gd2l0aC4K CkFkZGl0aW9uYWxseSwgYWRkIGEgdGVzdCBjYXNlIHRvIHJlZHVjZSB0aGUgcmlzayBvZiBzaW1p bGFyIGJyZWFrYWdlCmluIGZ1dHVyZS4KCmdkYi9DaGFuZ2VMb2c6CgoJKiBjbGkvY2xpLXNjcmlw dC5jIChleGVjdXRlX2NvbnRyb2xfY29tbWFuZHMpOiBkb24ndCBzZXQKICAgICAgICBpbnN0cmVh bSB0byBudWxscHRyIGhlcmUgYXMgdGhpcyBicmVha3MgdGhlIGZyb21fdHR5IGFyZ3VtZW50CiAg ICAgICAgdG8gZ2RiLmV4ZWN1dGUgaW4gUHl0aG9uLgogICAgICAgIChleGVjdXRlX3VzZXJfY29t bWFuZCk6IHNldCBpbnN0cmVhbSB0byBudWxscHRyIGhlcmUgaW5zdGVhZC4KCmdkYi90ZXN0c3Vp dGUvQ2hhbmdlTG9nOgoKCSogZ2RiLnB5dGhvbi9weXRob24uZXhwOiBhZGQgdGVzdCBjYXNlcyBm b3IgdGhlIGZyb21fdHR5CiAgICAgICAgYXJndW1lbnQgdG8gZ2RiLmV4ZWN1dGUuCi0tLQogZ2Ri L2NsaS9jbGktc2NyaXB0LmMgICAgICAgICAgICAgICAgfCAgOSArKysrKy0tLS0KIGdkYi90ZXN0 c3VpdGUvZ2RiLnB5dGhvbi9weXRob24uZXhwIHwgMTMgKysrKysrKysrKysrKwogMiBmaWxlcyBj aGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dk Yi9jbGkvY2xpLXNjcmlwdC5jIGIvZ2RiL2NsaS9jbGktc2NyaXB0LmMKaW5kZXggZGE0YTQxMDIz YS4uZjhhYzYxMGQ0ZCAxMDA2NDQKLS0tIGEvZ2RiL2NsaS9jbGktc2NyaXB0LmMKKysrIGIvZ2Ri L2NsaS9jbGktc2NyaXB0LmMKQEAgLTM5MiwxMCArMzkyLDYgQEAgZXhlY3V0ZV9jbWRfcG9zdF9o b29rIChzdHJ1Y3QgY21kX2xpc3RfZWxlbWVudCAqYykKIHZvaWQKIGV4ZWN1dGVfY29udHJvbF9j b21tYW5kcyAoc3RydWN0IGNvbW1hbmRfbGluZSAqY21kbGluZXMsIGludCBmcm9tX3R0eSkKIHsK LSAgLyogU2V0IHRoZSBpbnN0cmVhbSB0byAwLCBpbmRpY2F0aW5nIGV4ZWN1dGlvbiBvZiBhCi0g ICAgIHVzZXItZGVmaW5lZCBmdW5jdGlvbi4gICovCi0gIHNjb3BlZF9yZXN0b3JlIHJlc3RvcmVf aW5zdHJlYW0KLSAgICA9IG1ha2Vfc2NvcGVkX3Jlc3RvcmUgKCZjdXJyZW50X3VpLT5pbnN0cmVh bSwgbnVsbHB0cik7CiAgIHNjb3BlZF9yZXN0b3JlIHNhdmVfYXN5bmMgPSBtYWtlX3Njb3BlZF9y ZXN0b3JlICgmY3VycmVudF91aS0+YXN5bmMsIDApOwogICBzY29wZWRfcmVzdG9yZSBzYXZlX25l c3RpbmcKICAgICA9IG1ha2Vfc2NvcGVkX3Jlc3RvcmUgKCZjb21tYW5kX25lc3RfZGVwdGgsIGNv bW1hbmRfbmVzdF9kZXB0aCArIDEpOwpAQCAtNDY0LDYgKzQ2MCwxMSBAQCBleGVjdXRlX3VzZXJf Y29tbWFuZCAoc3RydWN0IGNtZF9saXN0X2VsZW1lbnQgKmMsIGNvbnN0IGNoYXIgKmFyZ3MpCiAg IGlmICh1c2VyX2FyZ3Nfc3RhY2suc2l6ZSAoKSA+IG1heF91c2VyX2NhbGxfZGVwdGgpCiAgICAg ZXJyb3IgKF8oIk1heCB1c2VyIGNhbGwgZGVwdGggZXhjZWVkZWQgLS0gY29tbWFuZCBhYm9ydGVk LiIpKTsKIAorICAvKiBTZXQgdGhlIGluc3RyZWFtIHRvIG51bGxwdHIsIGluZGljYXRpbmcgZXhl Y3V0aW9uIG9mIGEKKyAgICAgdXNlci1kZWZpbmVkIGZ1bmN0aW9uLiAgKi8KKyAgc2NvcGVkX3Jl c3RvcmUgcmVzdG9yZV9pbnN0cmVhbQorICAgID0gbWFrZV9zY29wZWRfcmVzdG9yZSAoJmN1cnJl bnRfdWktPmluc3RyZWFtLCBudWxscHRyKTsKKwogICBleGVjdXRlX2NvbnRyb2xfY29tbWFuZHMg KGNtZGxpbmVzLCAwKTsKIH0KIApkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9u L3B5dGhvbi5leHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHl0aG9uLmV4cAppbmRleCBh MDMxZWE1YTE4Li4wMTdmMzNhZmU1IDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5weXRo b24vcHl0aG9uLmV4cAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHl0aG9uLmV4cApA QCAtNTI2LDMgKzUyNiwxNiBAQCBnZGJfdGVzdCAicHJpbnQgXCRjdmFyMyIgIj0gdm9pZCIgXAog IyBUZXN0IFBSIDIzNjY5LCB0aGUgZm9sbG93aW5nIHdvdWxkIGludm9rZSB0aGUgImNvbW1hbmRz IiBjb21tYW5kIGluc3RlYWQgb2YKICMgInNob3cgY29tbWFuZHMiLgogZ2RiX3Rlc3QgInB5dGhv biBnZGIuZXhlY3V0ZShcInNob3cgY29tbWFuZHNcIikiICIkZGVjaW1hbCAgcHJpbnQgXFxcJGN2 YXIzLioiCisKKyMgVGVzdCB0aGF0IHRoZSBmcm9tX3R0eSBhcmd1bWVudCB0byBnZGIuZXhlY3V0 ZSBpcyBlZmZlY3RpdmUuIElmCisjIEZhbHNlLCB0aGUgdXNlciBpcyBub3QgcHJvbXB0ZWQgZm9y IGRlY2lzaW9ucyBzdWNoIGFzIHJlc3RhcnRpbmcgdGhlCisjIHByb2dyYW0sIGFuZCAieWVzIiBp cyBhc3N1bWVkLiBJZiBUcnVlLCB0aGUgdXNlciBpcyBwcm9tcHRlZC4KK2dkYl90ZXN0ICJweXRo b24gZ2RiLmV4ZWN1dGUoJ3N0YXJ0aScsIGZyb21fdHR5PUZhbHNlKSIgXAorICAgICJQcm9ncmFt IHN0b3BwZWQuKiIgXAorICAgICJzdGFydGkgdmlhIGdkYi5leGVjdXRlLCBub3QgZnJvbSB0dHki CitnZGJfdGVzdF9tdWx0aXBsZSAicHl0aG9uIGdkYi5leGVjdXRlKCdzdGFydGknLCBmcm9tX3R0 eT1UcnVlKSIgXAorICAgICJzdGFydGkgdmlhIGdkYi5leGVjdXRlLCBmcm9tIHR0eSIgeworICAg IC1yZSB7VGhlIHByb2dyYW0gYmVpbmcgZGVidWdnZWQgaGFzIGJlZW4gc3RhcnRlZCBhbHJlYWR5 XC5cclxuU3RhcnQgaXQgZnJvbSB0aGUgYmVnaW5uaW5nXD8gXCh5IG9yIG5cKSAkfSB7CisJZ2Ri X3Rlc3QgInkiICJTdGFydGluZyBwcm9ncmFtOi4qIiAic3RhcnRpIHZpYSBpbnRlcmFjdGl2ZSBp bnB1dCIKKyAgICB9Cit9Ci0tIAoyLjI2LjAKCg== --000000000000c0848e05b00d5586--