Re: [PATCH 4/5] ARM: read_pieced_value do big endian processing only in case of valid gdb_regnum

Yao Qi
2014-10-23T06:24:06Z

Victor Kamensky <victor.kamensky@linaro.org> writes:

> I've posted updated V3 version only for this patch. I've modified
> commit message to include more details as you suggested.
> And I moved reg_offset var to more specific blocks as you noted.
> Please take a look.

Thanks, I'll take a look.

> Would you like me to repost the whole series again (all 4
> patches) or it would be OK just like this?

Well, we have two options usually, supposing you post a patch series,

- if you only update one or two patches after review, you can
just reply to reviewer's mail and post the updated patches in the same
mail thread as your original post. It'll be convenient to search in
archive, because all of them are in the same thread.

- if you update all the patches, for example, change the design, better
to post the updated series, like what you did for V2.

In this case, you don't have to post them again.
>
> Also it came up on binutils@ patch discussion with Alan -
> I do not have git commit permission. Is it my correct
> expectation once folks are OK with the patches, you or
> some other gdb maintainer will commit those?

It is better for you to create your own account, and commit your patches
after approval in the future.

Please fill in the form here https://sourceware.org/cgi-bin/pdw/ps_form.cgi
I think I can approve your request, so please fill in my mail address in
box "email address of person who approved request".

Once your account is ready, you can commit approved patches first. I am
still thinking about patch 4/4, it may take some time.

--
Yao (齐尧)