From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22270 invoked by alias); 21 Oct 2014 14:45:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22243 invoked by uid 89); 21 Oct 2014 14:45:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f41.google.com Received: from mail-qg0-f41.google.com (HELO mail-qg0-f41.google.com) (209.85.192.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 21 Oct 2014 14:45:13 +0000 Received: by mail-qg0-f41.google.com with SMTP id a108so971158qge.14 for ; Tue, 21 Oct 2014 07:45:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=AGd8ovUQz6hUkNYd3F6ApAT1Vuskf3Jq7cNB0AHU7+A=; b=l/3YQoPx3PrrsscVFO3YGWBG0IF/JTXTsrm0TjSzBqcdXkdeeXgBWZmz4Vy1ZD6+IT P0Yunrqalntf2IZdbNZ7Xv7EQiMpWH0IHmj+tYUZCblWsY8oVCYx/968000JNvW+Z6JX RsL+5jntyaPX4HiUzjqTDJBNCrucs6JDG/c1aPz1GC0e5xhrLNwpi1AEvOTjESaw7OZl BMQhp4Cer6IjAgBUpyaB4tRIVVM63jcYGM/VGt6GOjf14/wZd3skAv6fkLdiXc1UYPY5 53zYWf7eyDChNnKEUAsemLzOUP5GSW0w31BlmvVvVMyjeQ+EB425LEcGKlcLZdmNrt1F kC0A== X-Gm-Message-State: ALoCoQmLs47Jfr3j9HyaFzNkcBpTBmypSYNLeD2qXsFziMBzpVAokIYUk1+6F32+LfiIH9jrEG+z MIME-Version: 1.0 X-Received: by 10.229.86.194 with SMTP id t2mr46343263qcl.20.1413902679042; Tue, 21 Oct 2014 07:44:39 -0700 (PDT) Received: by 10.229.93.203 with HTTP; Tue, 21 Oct 2014 07:44:38 -0700 (PDT) In-Reply-To: <871tq1kgc2.fsf@codesourcery.com> References: <1413853021-4393-1-git-send-email-victor.kamensky@linaro.org> <1413853021-4393-3-git-send-email-victor.kamensky@linaro.org> <871tq1kgc2.fsf@codesourcery.com> Date: Tue, 21 Oct 2014 14:45:00 -0000 Message-ID: Subject: Re: [PATCH 2/5] ARM: extract_arm_insn function need to read instrs correctly in be8 case From: Victor Kamensky To: Yao Qi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-10/txt/msg00550.txt.bz2 On 21 October 2014 00:54, Yao Qi wrote: > Victor Kamensky writes: > >> Fix is to change gdbarch_byte_order to gdbarch_byte_order_for_code, >> when passed to extract_unsigned_integer that reads instruction. >> --- >> gdb/ChangeLog | 5 +++++ >> gdb/arm-tdep.c | 2 +- >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index c967a93..2aef5dc 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,3 +1,8 @@ >> +2014-10-13 Victor Kamensky >> + >> + * arm-tdep.c (extract_arm_insn): use dbarch_byte_order_for_code >> + to read arm instruction. >> + >> 2014-09-30 Don Breazeal >> >> * inf-ptrace.c (inf_ptrace_follow_fork): Remove target-independent > > Looks good to me. > > We don't include the ChangeLog changes in the patch, because that will > cause conflicts when applying your patch locally in the review. > Instead, we include ChangeLog entries in the commit messages, see > https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_= commit_messages Thanks! It is good pointer. I have not seen it before. Maybe gdb/CONTRIBUTE could mention this wiki page. I will move all proposed commit ChangeLogs as per wiki, will incorporate review comments and repost updated series. Thanks, Victor > -- > Yao (=E9=BD=90=E5=B0=A7)